public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: Jeff Brasen <jbrasen@nvidia.com>, devel@edk2.groups.io
Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
	Sami.Mujawar@arm.com
Subject: Re: [edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources
Date: Tue, 12 Sep 2023 10:54:21 +0200	[thread overview]
Message-ID: <616f3e9c-891f-6e2b-1d05-65c045ffb6ff@arm.com> (raw)
In-Reply-To: <cover.1694475927.git.jbrasen@nvidia.com>

Hello Jeff,
I had some trouble applying PATCH [1/2], but the changes look good
to me otherwise:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 9/12/23 01:48, Jeff Brasen wrote:
> Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of
> AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses
> can be used to generate I/O packets over the PCIe bus.
> 
> Vidya Sagar (2):
>    DynamicTablesPkg: AML Code generation for I/O ranges
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord to describe I/O range
> 
>   .../Include/Library/AmlLib/AmlLib.h           | 67 ++++++++++++++
>   .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c    |  2 +-
>   .../AmlLib/CodeGen/AmlResourceDataCodeGen.c   | 90 +++++++++++++++++++
>   3 files changed, 158 insertions(+), 1 deletion(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108521): https://edk2.groups.io/g/devel/message/108521
Mute This Topic: https://groups.io/mt/101305537/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-09-12  8:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 23:48 [edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources Jeff Brasen via groups.io
2023-09-11 23:48 ` [edk2-devel] [PATCH 1/2] DynamicTablesPkg: AML Code generation for I/O ranges Jeff Brasen via groups.io
2023-09-12  9:35   ` Leif Lindholm
2023-09-12  9:55     ` PierreGondois
2023-09-12 19:32       ` Leif Lindholm
2023-09-12 19:04     ` Jeff Brasen via groups.io
2023-09-12 19:31       ` Leif Lindholm
2023-09-11 23:48 ` [edk2-devel] [PATCH 2/2] DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord to describe I/O range Jeff Brasen via groups.io
2023-09-12  8:54 ` PierreGondois [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=616f3e9c-891f-6e2b-1d05-65c045ffb6ff@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox