From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 62C667803D8 for ; Tue, 12 Sep 2023 08:54:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=TigorMEWgAlGMZe7xW6I6Vd64gr1srHrVfer/yVePqg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694508868; v=1; b=Z6K3MoGAa97ICmrT6b0CS/TV0N/YbJjPluAB9LqSLgQhMuO4rpwcUzerPHopf137mbxrR0Rl 4JaQaCAei2kwMoxlS1NQFnpshnNQbT8454iiV9YHcw3ZfYdBAQ+F1Yyi0aNF5k3EOXCKlXd1PNf ZOkVJlPMaXhaavOtXQiLtpYU= X-Received: by 127.0.0.2 with SMTP id pMXSYY7687511x2XeDQJOMEH; Tue, 12 Sep 2023 01:54:28 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.20588.1694508868055868313 for ; Tue, 12 Sep 2023 01:54:28 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 05A65C15; Tue, 12 Sep 2023 01:55:04 -0700 (PDT) X-Received: from [10.34.100.121] (e126645.nice.arm.com [10.34.100.121]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 208DA3F738; Tue, 12 Sep 2023 01:54:25 -0700 (PDT) Message-ID: <616f3e9c-891f-6e2b-1d05-65c045ffb6ff@arm.com> Date: Tue, 12 Sep 2023 10:54:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [edk2-devel] [PATCH 0/2] Add support for PCI IO using Qword resources To: Jeff Brasen , devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, Sami.Mujawar@arm.com References: From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B13yBujw5uayg4AnhrWPlbKMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z6K3MoGA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Jeff, I had some trouble applying PATCH [1/2], but the changes look good to me otherwise: Reviewed-by: Pierre Gondois Regards, Pierre On 9/12/23 01:48, Jeff Brasen wrote: > Use AmlCodeGenRdQWordIo() to generate the I/O range in _CRS instead of > AmlCodeGenRdDWordIo() to cater to the scenarios where 64-bit addresses > can be used to generate I/O packets over the PCIe bus. >=20 > Vidya Sagar (2): > DynamicTablesPkg: AML Code generation for I/O ranges > DynamicTablesPkg: AcpiSsdtPcieLibArm: Use QWord to describe I/O range >=20 > .../Include/Library/AmlLib/AmlLib.h | 67 ++++++++++++++ > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 90 +++++++++++++++++++ > 3 files changed, 158 insertions(+), 1 deletion(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108521): https://edk2.groups.io/g/devel/message/108521 Mute This Topic: https://groups.io/mt/101305537/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-