Re: [PATCH] MdePkg: resolve bug 741

[Zenith432 <zenith432@users.sourceforge.net>]

It's the package maintainer's choice.  As a practical matter, silencing the warning also works because...

1. clang is the only compiler that complains.  Even though it complains, it generates correct code because it has __builtin implementation of va_start that takes register argument and stack granularity into account.
2. In MdePkg/Include/Base.h there are __builtin implementations of VA_START for __CC_ARM, GCC and clang which should all work despite the argument promotion.
3. For the other architectures (i.e. Windows) there's an implementation of VA_START in Base.h that uses _INT_SIZE_OF for the parameter always a multiple of UINTN.  The Windows compilers also have builtin forms of va_start, but this non-builtin implementation looks ok for all arguments actually passed as variadic in EDK2.

--------------------------------------------
On Sat, 12/9/17, Marvin Häuser <Marvin.Haeuser@outlook.com> wrote:

...
It's your choice of course.
...

 Regards,
 Marvin.