From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Pranav Madhu <pranav.madhu@arm.com>,devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 2/3] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform
Date: Mon, 01 Mar 2021 06:30:29 -0800 [thread overview]
Message-ID: <619.1614609029302908832@groups.io> (raw)
In-Reply-To: <20210215104507.3773-3-pranav.madhu@arm.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
Hi Pranav,
Can you add a link to the RD-V1-MC platform documentation in a specification reference section in the file header, please?
See https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/52_spacing#5-2-3-1-every-new-file-shall-begin-with-a-file-header-comment-block
Also can you submit another patch in this series that adds a Readme.md file that describes the following, please?
- Where to find the documentation for the platform.
- RD-V1-MC model binary download location.
- Toolchain to be used and location to download the same.
- Firmware build instructions and supported build hosts.
- Any other dependencies required to boot to the UEFI shell.
The Readme.md file could be added as a new patch in the v2 series.
Regards,
Sami Mujawar
[-- Attachment #2: Type: text/html, Size: 37362 bytes --]
next prev parent reply other threads:[~2021-03-01 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 10:45 [edk2-platforms][PATCH V1 0/3] ACPI cleanup for RD-V1 Pranav Madhu
2021-02-15 10:45 ` [edk2-platforms][PATCH V1 1/3] Platform/Sgi: include SSDT table for RD-V1 platform Pranav Madhu
2021-03-01 14:10 ` [edk2-devel] " Sami Mujawar
2021-02-15 10:45 ` [edk2-platforms][PATCH V1 2/3] Platform/Sgi: fix the list of CPU devices on RD-V1-MC platform Pranav Madhu
2021-03-01 14:30 ` Sami Mujawar [this message]
2021-02-15 10:45 ` [edk2-platforms][PATCH V1 3/3] Platform/Sgi: fix CPU acpi-id for " Pranav Madhu
2021-03-01 14:32 ` [edk2-devel] " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=619.1614609029302908832@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox