From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Rohit Mathew <rohit.mathew@arm.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Thomas Abraham <thomas.abraham@arm.com>,
nd@arm.com
Subject: Re: [PATCH 1/2] Platform/Sgi: Update ACPI tables to use console UART
Date: Thu, 21 Jul 2022 13:40:41 +0100 [thread overview]
Message-ID: <619430d7-994f-9cf2-215c-8fd1d82bf550@arm.com> (raw)
In-Reply-To: <20220704165909.17895-2-rohit.mathew@arm.com>
Hi Rohit,
These changes are fine, just too repetitive.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 04/07/2022 05:59 pm, Rohit Mathew wrote:
> Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of
> consoles") assigns different address for the console UART and the debug
> UART. Correspondingly, update the SPCR and SSDT ACPI tables to use the
> address of the console UART port instead of the debug UART port.
>
> Signed-off-by: Rohit Mathew <rohit.mathew@arm.com>
> ---
> Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 2 ++
> Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 2 +-
> Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl | 2 +-
> 10 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
> index 8c34c2fa73e4..d2935f1e73e1 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -69,4 +70,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
> index ce89aa93ea7b..73f47ece7718 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -70,4 +71,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> index c96d0e40d2cd..da14120bde69 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf
> @@ -34,6 +34,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -80,4 +81,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> index 25be2e276e85..90976250445e 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -71,4 +72,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> index 4b36c3e5ceb2..95fb446c105d 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -72,4 +73,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf
> index 97a87462932b..3540575dd641 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -71,4 +72,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf
> index 61a2f3a2452b..c6bd69b4a538 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf
> @@ -34,6 +34,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -81,4 +82,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
> index a1bd71fde761..cb3f3fcdb9b6 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
> +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf
> @@ -32,6 +32,7 @@ [Packages]
> ArmPkg/ArmPkg.dec
> ArmPlatformPkg/ArmPlatformPkg.dec
> EmbeddedPkg/EmbeddedPkg.dec
> + MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> Platform/ARM/SgiPkg/SgiPlatform.dec
>
> @@ -70,4 +71,5 @@ [FixedPcd]
> gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv
> gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv
>
> + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase
> gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc b/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc
> index 6467fcdf4fd0..6307777bd148 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc
> +++ b/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc
> @@ -34,7 +34,7 @@ STATIC EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr = {
> EFI_ACPI_RESERVED_BYTE
> },
> // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE BaseAddress;
> - ARM_GAS32 (FixedPcdGet64 (PcdSerialDbgRegisterBase)),
> + ARM_GAS32 (FixedPcdGet64 (PcdSerialRegisterBase)),
> // UINT8 InterruptType;
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_GIC,
> // UINT8 Irq;
> diff --git a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl b/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl
> index 6b36da23cf0b..fd20c67e1225 100644
> --- a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl
> +++ b/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl
> @@ -22,7 +22,7 @@ DefinitionBlock ("SsdtRosTable.aml", "SSDT", 2, "ARMLTD", "ARMSGI",
> Name (_CRS, ResourceTemplate () {
> Memory32Fixed (
> ReadWrite,
> - FixedPcdGet64 (PcdSerialDbgRegisterBase),
> + FixedPcdGet64 (PcdSerialRegisterBase),
> 0x1000
> )
> Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { FixedPcdGet32 (PL011UartInterrupt) }
next prev parent reply other threads:[~2022-07-21 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 16:59 [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage Rohit Mathew
2022-07-04 16:59 ` [PATCH 1/2] Platform/Sgi: Update ACPI tables to use console UART Rohit Mathew
2022-07-21 12:40 ` Sami Mujawar [this message]
2022-07-04 16:59 ` [PATCH 2/2] Platform/Sgi: Add serial debug controller to SSDT Rohit Mathew
2022-07-21 12:41 ` Sami Mujawar
2022-07-22 12:46 ` [edk2-devel] " Rohit Mathew
2022-07-25 10:41 ` Sami Mujawar
2022-07-25 11:36 ` Thanu Rangarajan
2022-07-25 14:55 ` Rohit Mathew
2022-08-02 13:50 ` Rohit Mathew
2022-08-17 9:19 ` Rohit Mathew
2022-08-17 9:45 ` Sami Mujawar
2022-08-17 10:31 ` Rohit Mathew
2022-07-04 21:38 ` [edk2-platforms][PATCH 0/2] Platform/Sgi: Update serial port usage Thomas Abraham
2022-07-18 18:00 ` [edk2-devel] " Rohit Mathew
2022-09-15 17:13 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=619430d7-994f-9cf2-215c-8fd1d82bf550@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox