From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (EUR03-DBA-obe.outbound.protection.outlook.com [40.107.104.78]) by mx.groups.io with SMTP id smtpd.web10.5862.1658407256391135977 for ; Thu, 21 Jul 2022 05:40:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Afw3C201; spf=pass (domain: arm.com, ip: 40.107.104.78, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Q7lltYSC4o+EXG3Uv+OgpUg78rQkXYLfxe2OJdKTGGsyX0wGYTcfhmo5qCmb87MKIfYlk9l1BTeZiq6w43/a5vZ3FIHSGt8BT4ujV6xOiHr4ohWEO4BCDU1Vv2LT3oz9qOR9+OJ+px4zzqHd50IQmI8xmbHJEneuAWirPkkYof215hQja2FbdJjlq+PRmvdvmRaToGgmWGfhi6i/IVEjYPRvJFfjLsHAhcUFEVURGb3e/J38+eW3Qwq9FXw+73r6+8wlxXd84kO5t2XUisW1OZUEUburc1WmkMTviNHD0ZZV51lqIj3dFoKSLIvaIA4eRetznwMz+7TOkSmL0bRmOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kudcbC8VYMhNCOB9y6Rg4sMxn7qfGHx4WHy4ok+L3FI=; b=LfgMJzeYOnWtbmrnb4QBvvlval5i2ect3sUBKfoM+speje9881y/eSMDc8gOGSCs8USX590hQQEEzjSOepNBxKFijwPh4dFahB0UHNVFQRo3gHacD8vqDYN7fYwlhZbc5oypwlLQzmhWwCKGA2r+qcZUvzWu8Sqg3pUNFTB2SCEKPvoLT+GsIcHZnnq/1aPzVfLCkH8UF1O5aeSu+cDZSImNgoYX0WxeyzSvWZOH5+1Lkf4uJdqZhFQBff4EV48UVClJMygBjdOMzrWzld2t1CDREoF4XjnsVA/P4DJ2j+lbIG9F3m0xbU1cIM+hAP8wBT3/I/uNrtALB43iqAEK0w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kudcbC8VYMhNCOB9y6Rg4sMxn7qfGHx4WHy4ok+L3FI=; b=Afw3C201DjHy8zH50VMs6EbjnSwoMMhu4el7DE5vlOHwZBnQ4wLSr7voR+642prjjpy1bOfPiusjMHZOU+jxphUXM2Si3TdKRP6/YRybZxi201VymLfF73tF3+TI5BNyRIwHy+RdQ78hnzRKYfP7Aa0Q7QunAfEXpqUYK7kr+pw= Received: from AS8PR04CA0067.eurprd04.prod.outlook.com (2603:10a6:20b:313::12) by VI1PR08MB3984.eurprd08.prod.outlook.com (2603:10a6:803:e9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 12:40:52 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::bc) by AS8PR04CA0067.outlook.office365.com (2603:10a6:20b:313::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 12:40:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 12:40:51 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 21 Jul 2022 12:40:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c52a9205934d3a1 X-CR-MTA-TID: 64aa7808 Received: from 17f53931b612.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE159E9B-10E6-4EF7-BC8B-1BDB36125298.1; Thu, 21 Jul 2022 12:40:45 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17f53931b612.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 12:40:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eLjSZHog4+s2JHJBctkifTWw3/GaHNEMCJeA8aJKssfMIW5b4kAUdjIOTzvuxKyv5ndk+SnGVADdUxXiw4VTx0YY8dbxZyVuxNTRF4qIodklsoNP1DdUF84uSfS+N7wYPo9OqJaK+KC62HmtsQi8qvtTPrnzaFzdWMeyeHi4mPEkeK/BxDSd62qq4NpHqA5XC2vqArcaJrdpUJl3vmOQXFNistWWWVXjd+5Q1ceEFmHRu8bvq+9Jo3KPzQGTBApLWARbRLfiup/eICdyTC5vUHNBOeod2enAVnOAzTSr9/4Z+IaRsMh8+X+8Ugu0iharojMpT4gXbpwCz1WMS/lDuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kudcbC8VYMhNCOB9y6Rg4sMxn7qfGHx4WHy4ok+L3FI=; b=Hd7fFXioYEs53ZUsapTr5hmWOykRXpW0hDAfdu4v8yyrBHtWgcfKybLqQRa9KMqvlLpQR13NQEX+aE467J5rdDM4x1c8Ijkxr+YppjQTz3cau7sT3qs16sPlHLugJNVt8RisJ2xl4xDpRAUO4yFKOlS63PrTfZkZNELbYHJs4Q4NMSC/gqqVi2UWNVbsd5aQ9XlYNhI043BVl7j1CP+WVeRuL8Otc2Fz7gspoIsZfjipX8fNB6tMaSjrcaO4CJgGZP34IJFWeWlggwQWV7DO4xAoX97IOYRq8u7pKSPkGjcd591vc0zj0mkNno+FrdFJPjmI7I8jfTTEd+XJXrsUQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kudcbC8VYMhNCOB9y6Rg4sMxn7qfGHx4WHy4ok+L3FI=; b=Afw3C201DjHy8zH50VMs6EbjnSwoMMhu4el7DE5vlOHwZBnQ4wLSr7voR+642prjjpy1bOfPiusjMHZOU+jxphUXM2Si3TdKRP6/YRybZxi201VymLfF73tF3+TI5BNyRIwHy+RdQ78hnzRKYfP7Aa0Q7QunAfEXpqUYK7kr+pw= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM0PR08MB5185.eurprd08.prod.outlook.com (2603:10a6:208:157::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Thu, 21 Jul 2022 12:40:43 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%4]) with mapi id 15.20.5458.018; Thu, 21 Jul 2022 12:40:43 +0000 Message-ID: <619430d7-994f-9cf2-215c-8fd1d82bf550@arm.com> Date: Thu, 21 Jul 2022 13:40:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] Platform/Sgi: Update ACPI tables to use console UART To: Rohit Mathew , devel@edk2.groups.io Cc: Ard Biesheuvel , Thomas Abraham , nd@arm.com References: <20220704165909.17895-1-rohit.mathew@arm.com> <20220704165909.17895-2-rohit.mathew@arm.com> From: "Sami Mujawar" In-Reply-To: <20220704165909.17895-2-rohit.mathew@arm.com> X-ClientProxiedBy: LO3P265CA0013.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::18) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 952d453e-74b0-4f19-6c40-08da6b163f11 X-MS-TrafficTypeDiagnostic: AM0PR08MB5185:EE_|AM5EUR03FT027:EE_|VI1PR08MB3984:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vljwtEyetqXtg/6VOvKI151nCbnauoG+FbeozP9fibaXY41PJaCTcIVRVsXeJEPcPy4HA+FBrnnl5ra+32tIVdFc1fGbV2uf+hIoAcsnadpPe5aqOkczNkJkLLCHwkG8tOvtNkdLF+nFd8BYgcAmwpRznGSNvLY31TTtY96M5RYHYGsF3MzNi4IR/sK52VWFkbsqfqjwcWLuHBrHfv9Wlx6aP/j1Ygf4DM6Vx1lcmZqXm5+8of90geqDMxbKclMsmtRcbQSEgvjXRRFsu4fdYfpt7FSXLBcAkCp+43sXi364DR96/n0VxA/xSdmwtAnSpKqk6JtNLPjkS4fszTJZjr5VtnNzXj3YLY8Rav8Wj5AGNpw11ULxNfuUjP+GeHVbiv6ZzF7XdqJe9X6s6gSXq98kBmXxeAA5HCRvXt0INSYasqtCAVjK6oYuBMccL6iioUnK8N/SToC4iE086D+QiLkuEE9++53xb0Xl0uk0IGB8YG1MUjTZ3o5VtRkpwAp0pDKk/qmcnwP2WH3o72bb7jkejGJBmsdeUCshf2q1k2USj7jnrFMJ691VpSbZmb5mB99q2d3cmUtVgiHbLNdY+UW9a6phy1BjniMmUxh4U72LVYC5YzwdcoYexZS6MtX1ApwidPcoourM+8Y5gQnXWDxV3ylj25frghdjCl1pLndk8tTl7oX/CXKyfCMvlW1Qxo/pV+tLnnkx4AO/yW9nKB6w5l1m9Xb6PPAZsyKC33B6kdVV9o1bpeXIy6A+2yCLoxXv7XYFTTRCkMnNB5lJ7KiXHi/thaGND7qUzxFdikBEdJgTN5g77Ina/zsl1TuJuYeKDxLqRs2pw45yw6ZzjA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(346002)(376002)(39860400002)(19627235002)(44832011)(5660300002)(2616005)(478600001)(54906003)(86362001)(2906002)(15650500001)(31696002)(316002)(36756003)(66476007)(4326008)(26005)(8676002)(66946007)(53546011)(186003)(31686004)(38100700002)(6512007)(6506007)(6486002)(8936002)(41300700001)(66556008)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5185 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c429476f-f9c4-4e47-7e49-08da6b163979 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xbYlyGHolbcS3lLdF8UsCwZ+APBuqf1t4fkGdrBT25Pv0fGb862Qg8k2sXuwm2GTy9ZyDCEjztNcNYID5O+GW7ThLD9Yv7jb/PsKJLhULyHLxRcxwpVdqxX8qJKRXo6jmKEFPqO4k+KUYWHi2na9uhw0T6NDtmQ8MPHHR1TvZxhWsf/JPTRvjmnELGyUUX3vBufa8Zs1r0DghizYNY/9DxLPR6Sm8rI/LeS/kS4x2Riwf4lxT+lYQOZQStk83IxQCnAl59nIB47RodaFkGOnVxMqfvpsLCvlDpB+g4b+tvtfwFdBKh29dwy/kV5k4/27HVc/vxnZ23ZphHjcwkiIJnhQA+grjy8IKLoD+VQR4G4kTS8TU6Eb3ztASZb/yScY+hPla4blt0b0P+3eGikQG62ILwZ3Auhvg3Pdfk8XTbD6sUdmxzVHnHwv1hOcFLBn1R5oAOgQALZ7Up48v4n8TSfdmt8uSR0mTJhqpbFKi5+ks0guLBNYns2+X046STriC/a8qlUywEG1ntTXN82yqfBoTV/dY7a6FB3KrB/87pwE3VCi3ANsifmd/ap5nC/sc94O/JPiwH4lkG4G48dUcdJimG+LP0hdcJPGlvZFHGIXGujz09W+A7VZNeYx8//LIvd31ftCCWJql0TnUOIokIGa3yKiyim6mUk0cBCoEImA6Dt3mYdRRbPt2D/mf3r0TyiJDtGqFxw27FjitxBNIDxBF3H3g2YpyzdLsHYJKVa7CYFBS2Dz7f8+Pxb2FT7l4ueclYaxqXaC33ccwNhka2RaWMepLo5Ekmp3BsFVEmQ/esU45awjYKPTZGgw+PcUWHpdWiYqUCgJb5RS2xWYtA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(376002)(39860400002)(40470700004)(36840700001)(46966006)(40480700001)(70586007)(19627235002)(81166007)(86362001)(356005)(31686004)(82740400003)(70206006)(8676002)(4326008)(44832011)(316002)(54906003)(186003)(2906002)(5660300002)(336012)(47076005)(53546011)(6506007)(31696002)(2616005)(82310400005)(478600001)(26005)(6512007)(40460700003)(6486002)(8936002)(83380400001)(36860700001)(41300700001)(15650500001)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 12:40:51.6997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 952d453e-74b0-4f19-6c40-08da6b163f11 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3984 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rohit, These changes are fine, just too repetitive. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/07/2022 05:59 pm, Rohit Mathew wrote: > Patch 433b5b1b0f7f ("Platform/Sgi: Route logs to different sets of > consoles") assigns different address for the console UART and the debug > UART. Correspondingly, update the SPCR and SSDT ACPI tables to use the > address of the console UART port instead of the debug UART port. > > Signed-off-by: Rohit Mathew > --- > Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf | 2 ++ > Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc | 2 +- > Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl | 2 +- > 10 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > index 8c34c2fa73e4..d2935f1e73e1 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdE1EdgeAcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -69,4 +70,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > index ce89aa93ea7b..73f47ece7718 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeAcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -70,4 +71,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > index c96d0e40d2cd..da14120bde69 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2AcpiTables.inf > @@ -34,6 +34,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -80,4 +81,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > index 25be2e276e85..90976250445e 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -71,4 +72,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > index 4b36c3e5ceb2..95fb446c105d 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1AcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -72,4 +73,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > index 97a87462932b..3540575dd641 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1AcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -71,4 +72,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > index 61a2f3a2452b..c6bd69b4a538 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1McAcpiTables.inf > @@ -34,6 +34,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -81,4 +82,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf b/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > index a1bd71fde761..cb3f3fcdb9b6 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575AcpiTables.inf > @@ -32,6 +32,7 @@ [Packages] > ArmPkg/ArmPkg.dec > ArmPlatformPkg/ArmPlatformPkg.dec > EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > Platform/ARM/SgiPkg/SgiPlatform.dec > > @@ -70,4 +71,5 @@ [FixedPcd] > gArmSgiTokenSpaceGuid.PcdWdogWS0Gsiv > gArmSgiTokenSpaceGuid.PcdWdogWS1Gsiv > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterBase > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress > diff --git a/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc b/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc > index 6467fcdf4fd0..6307777bd148 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc > +++ b/Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc > @@ -34,7 +34,7 @@ STATIC EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE Spcr = { > EFI_ACPI_RESERVED_BYTE > }, > // EFI_ACPI_6_4_GENERIC_ADDRESS_STRUCTURE BaseAddress; > - ARM_GAS32 (FixedPcdGet64 (PcdSerialDbgRegisterBase)), > + ARM_GAS32 (FixedPcdGet64 (PcdSerialRegisterBase)), > // UINT8 InterruptType; > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERRUPT_TYPE_GIC, > // UINT8 Irq; > diff --git a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl b/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl > index 6b36da23cf0b..fd20c67e1225 100644 > --- a/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl > +++ b/Platform/ARM/SgiPkg/AcpiTables/SsdtRos.asl > @@ -22,7 +22,7 @@ DefinitionBlock ("SsdtRosTable.aml", "SSDT", 2, "ARMLTD", "ARMSGI", > Name (_CRS, ResourceTemplate () { > Memory32Fixed ( > ReadWrite, > - FixedPcdGet64 (PcdSerialDbgRegisterBase), > + FixedPcdGet64 (PcdSerialRegisterBase), > 0x1000 > ) > Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { FixedPcdGet32 (PL011UartInterrupt) }