Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu

[rebecca@bsdio.com]

I tested with QEMU 1.6.2 and it works.
I’ll update the patch to make it read-write.

— 
Rebecca Cran
> On Jul 23, 2019, at 8:54 PM, Jordan Justen <jordan.l.justen@intel.com> wrote:
> 
>> On 2019-07-23 18:51:00,  wrote:
>> Specify the firmware to use via the newer '-drive if=pflash' syntax
>> which allows specifying the raw format and readonly parameters. This
>> avoids warnings with newer version of QEMU.
>> 
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index a2c4eff2a5..e2890ff762 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" == "yes" ]]; then
>>   fi
>>   ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>>   if [[ "$ENABLE_FLASH" == "yes" ]]; then
>> -    QEMU_COMMAND="$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
>> +    QEMU_COMMAND="$QEMU_COMMAND -drive if=pflash,format=raw,readonly,file=$QEMU_FIRMWARE_DIR/bios.bin"
> 
> It looks like we set ENABLE_FLASH for qemu 1.6 and newer. Does this
> work on 1.6?
> 
> Also, I don't think we want readonly. Read-write should allow
> non-volatile variables to persist across multiple boot.
> 
> -Jordan
> 
> 
>