From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: bsdio.com, ip: 65.103.231.193, mailfrom: rebecca@bsdio.com)
Received: from muon.bsdio.com (muon.bsdio.com [65.103.231.193])
 by groups.io with SMTP; Tue, 23 Jul 2019 20:08:26 -0700
Received: from muon.bsdio.com (localhost [127.0.0.1])
	by muon.bsdio.com (Postfix) with ESMTP id 7D99789914;
	Tue, 23 Jul 2019 21:08:47 -0600 (MDT)
Received: from muon.bsdio.com ([127.0.0.1])
	by muon.bsdio.com (muon.bsdio.com [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id 1mQcTfvmRiga; Tue, 23 Jul 2019 21:08:46 -0600 (MDT)
Received: from [10.0.10.197] (unknown [10.0.10.197])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by muon.bsdio.com (Postfix) with ESMTPSA;
	Tue, 23 Jul 2019 21:08:46 -0600 (MDT)
Mime-Version: 1.0 (1.0)
Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg/build.sh: use newer '-drive if=pflash' syntax when running qemu
From: rebecca@bsdio.com
X-Mailer: iPhone Mail (16F203)
In-Reply-To: <156393689849.9039.6940197421609488727@jljusten-skl>
Date: Tue, 23 Jul 2019 21:08:24 -0600
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Laszlo Ersek <lersek@redhat.com>, rebecca@bsdio.com
Message-Id: <61B9A57D-60CF-47F5-87FE-E64B2E33D5D1@bsdio.com>
References: <20190724015101.13044-1-rebecca@bsdio.com> <156393689849.9039.6940197421609488727@jljusten-skl>
To: devel@edk2.groups.io, jordan.l.justen@intel.com
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable


I tested with QEMU 1.6.2 and it works.
I=E2=80=99ll update the patch to make it read-write.

=E2=80=94=20
Rebecca Cran
> On Jul 23, 2019, at 8:54 PM, Jordan Justen <jordan.l.justen@intel.com> w=
rote:
>=20
>> On 2019-07-23 18:51:00,  wrote:
>> Specify the firmware to use via the newer '-drive if=3Dpflash' syntax
>> which allows specifying the raw format and readonly parameters. This
>> avoids warnings with newer version of QEMU.
>>=20
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> OvmfPkg/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index a2c4eff2a5..e2890ff762 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -268,7 +268,7 @@ if [[ "$RUN_QEMU" =3D=3D "yes" ]]; then
>>   fi
>>   ln -sf $FV_DIR/OVMF.fd $QEMU_FIRMWARE_DIR/bios.bin
>>   if [[ "$ENABLE_FLASH" =3D=3D "yes" ]]; then
>> -    QEMU_COMMAND=3D"$QEMU_COMMAND -pflash $QEMU_FIRMWARE_DIR/bios.bin"
>> +    QEMU_COMMAND=3D"$QEMU_COMMAND -drive if=3Dpflash,format=3Draw,read=
only,file=3D$QEMU_FIRMWARE_DIR/bios.bin"
>=20
> It looks like we set ENABLE_FLASH for qemu 1.6 and newer. Does this
> work on 1.6?
>=20
> Also, I don't think we want readonly. Read-write should allow
> non-volatile variables to persist across multiple boot.
>=20
> -Jordan
>=20
>=20
>=20