public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* Re: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
@ 2023-11-21 11:56 Sami Mujawar
  2023-11-21 14:14 ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2023-11-21 11:56 UTC (permalink / raw)
  To: gaoliming, 'Laszlo Ersek', 'Michael Kinney',
	devel@edk2.groups.io, ashishsingha@nvidia.com,
	quic_llindhol@quicinc.com, ardb+tianocore@kernel.org,
	Jeff Brasen (jbrasen@nvidia.com)
  Cc: nd

Hi Liming,

On 21/11/2023, 01:05, "gaoliming" <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>> wrote:


Sami:
I am OK to merge this patch for this stable bug. I will add push label for https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061> 
[SAMI] Thank you for picking this patch for the stable tag. Apparently, the patch does not seem to have merged. 
I am not sure if you have already applied the push label. Please let me know if there are any issues that I can help with.

Regards,

Sami Mujawar

Thanks
Liming
> -----邮件原件-----
> 发件人: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> 发送时间: 2023年11月21日 0:07
> 收件人: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>; Liming Gao (Byosoft address)
> <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn>>; Michael Kinney <michael.d.kinney@intel.com <mailto:michael.d.kinney@intel.com>>;
> devel@edk2.groups.io <mailto:devel@edk2.groups.io>; ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>; quic_llindhol@quicinc.com <mailto:quic_llindhol@quicinc.com>;
> ardb+tianocore@kernel.org <mailto:ardb+tianocore@kernel.org>; jbrasen@nvidia.com <mailto:jbrasen@nvidia.com>
> 抄送: nd@arm.com <mailto:nd@arm.com>
> 主题: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix
> ETE _UID Creation
> 
> Hi Laszlo, Liming, Mike,
> 
> Please see my response inline marked [SAMI].
> 
> Regards,
> 
> Sami Mujawar
> 
> On 17/11/2023 09:20 am, Laszlo Ersek wrote:
> > On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
> >> Just like CPU _UID, ETE UID also needs to be unique so
> >> use AcpiProcessorUid instead of CpuName
> >>
> >> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com <mailto:ashishsingha@nvidia.com>>
> >> ---
> >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5
> ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> > Is this a fixup for the recent feature
> >
> > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
> > https://edk2.groups.io/g/devel/message/108996 <https://edk2.groups.io/g/devel/message/108996>
> >
> > ?
> >
> > If so, then I *think* this qualifies to be merged during the hard
> > feature freeze (+Liming +Mike), but:
> 
> [SAMI] I raised a bugzilla for this issue at
> https://bugzilla.tianocore.org/show_bug.cgi?id=4600 <https://bugzilla.tianocore.org/show_bug.cgi?id=4600>
> 
> and have also created a pull request at
> https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061>.
> 
> This patch has also passed the CI checks when I did a draft pull request.
> 
> I am not sure if I can apply the push label as we are in the code freeze
> stage.
> 
> Can you advise on how to proceed, please?
> 
> [/SAMI]
> 
> > - I think we should have a "Fixes:" tag in the commit message (for
> > pointing out the commit that should have contained the code being
> > added/updated now)
> >
> > - I think we should have a BZ too (also linked into the commit message).
> >
> > Laszlo
> >









-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111543): https://edk2.groups.io/g/devel/message/111543
Mute This Topic: https://groups.io/mt/102720225/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 3+ messages in thread
* [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation
@ 2023-11-15  3:19 Ashish Singhal via groups.io
  2023-11-17  9:20 ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Ashish Singhal via groups.io @ 2023-11-15  3:19 UTC (permalink / raw)
  To: devel, quic_llindhol, ardb+tianocore, sami.mujawar, jbrasen
  Cc: Ashish Singhal

Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName

Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
---
 .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
index 8228c7845a..724f33c660 100644
--- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
+++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c
@@ -359,6 +359,7 @@ CreateAmlCpcNode (
 
   @param [in]  Generator    The SSDT Cpu Topology generator.
   @param [in]  ParentNode   Parent node to attach the Cpu node to.
+  @param [in]  GicCInfo     CM_ARM_GICC_INFO object used to create the node.
   @param [in]  CpuName      Value used to generate the node name.
   @param [out] EtNodePtr   If not NULL, return the created Cpu node.
 
@@ -372,6 +373,7 @@ EFIAPI
 CreateAmlEtd (
   IN   ACPI_CPU_TOPOLOGY_GENERATOR  *Generator,
   IN   AML_NODE_HANDLE              ParentNode,
+  IN   CM_ARM_GICC_INFO             *GicCInfo,
   IN   UINT32                       CpuName,
   OUT  AML_OBJECT_NODE_HANDLE       *EtNodePtr OPTIONAL
   )
@@ -397,7 +399,7 @@ CreateAmlEtd (
 
   Status = AmlCodeGenNameInteger (
              "_UID",
-             CpuName,
+             GicCInfo->AcpiProcessorUid,
              EtNode,
              NULL
              );
@@ -474,6 +476,7 @@ CreateAmlEtNode (
   Status = CreateAmlEtd (
              Generator,
              Node,
+             GicCInfo,
              CpuName,
              NULL
              );
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111231): https://edk2.groups.io/g/devel/message/111231
Mute This Topic: https://groups.io/mt/102598848/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-21 14:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-21 11:56 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix ETE _UID Creation Sami Mujawar
2023-11-21 14:14 ` 回复: " gaoliming via groups.io
  -- strict thread matches above, loose matches on Subject: below --
2023-11-15  3:19 Ashish Singhal via groups.io
2023-11-17  9:20 ` Laszlo Ersek
2023-11-20 16:07   ` edk2-stable202311: " Sami Mujawar
2023-11-21  1:04     ` 回复: " gaoliming via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox