From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.79]) by mx.groups.io with SMTP id smtpd.web12.7542.1663772587134182009 for ; Wed, 21 Sep 2022 08:03:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=kJ+0Zc1n; spf=pass (domain: arm.com, ip: 40.107.14.79, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=J1/A7dyuyq1CZnBSlBr3ceef4V6vX4GOr9U8KHt3yJ6L5cIsTjBG4mAFozK1uthkMjsZAx0DZS3VpX1oPfa2zDK5PXTj29g6ypfyhn0WEEw5QbYb4mzmu5AN6UtNbn0U4JKBPw+QyOM6bCCBo/ZX0f+CpDCsvo1QjwMHRo3sVVr7WjP0cbU4xNAtrUAhmXLRfAxQ43OmIPSHOhDa3nCI/10mTQvm5vy1MfWjS3PfGF7A5hqklIANn3Yi1hbjbeIQydc01XrOuKlY19bUx+H/V3ci4OfqStn74D8pK86pzw/apZohSnW+P8OPZadQGLF2rZx9tyMpH0kJIZG/4KeOgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/N2FICUAAKn1thUAlS5WWsrOgiyRKoNLWZN2o2Fvhx0=; b=Efa3Jzr0IxF0gTsTPA+5TjmCqtkq0pgrchxXbEBQ6w23xBVRVcBNL+m6/GNshCyPw3WpVGfs3+WDy+e43P82HOzT4uO4qF3m6Zz9HBl/2AHz5sqLCvG67oIGjL0NtQsHvtw88Q3nfZB1RzB4cHE/7qd1kuuGO2WiboURQoD+wOjIu0I/oEx3eJjmVoIvz4G5t8QE3Qk3mtKXcEkH7NY/BxJnog7w30W3n2ygcAgq1bNjAlMGYFqfw1hQYB32PpsHUjTAvObERXgV92Np4PZOCLRgs0uzRTFUkJ2tPzF0Uii5htYBl7Pk4qeZtmTlyEb0FOdRSFPCP4CcWpJb66Z0Tg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/N2FICUAAKn1thUAlS5WWsrOgiyRKoNLWZN2o2Fvhx0=; b=kJ+0Zc1nMDl6x0PKv7HHhIywKir90CeGKsbzVzIlf/TgnQVsRnn5MmGX1gj8EF5L16chFRydI6sgKBTTbVC6fyc5PwN8lRZMWCU0Vs4MZyMyanEA2rWHA9Pm4yPtj8kwPmYq6HNZ7CPtZnltBnufvBDi2z0KusChocglrWNUBTs= Received: from AM6PR04CA0044.eurprd04.prod.outlook.com (2603:10a6:20b:f0::21) by AS8PR08MB9720.eurprd08.prod.outlook.com (2603:10a6:20b:614::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.16; Wed, 21 Sep 2022 15:03:02 +0000 Received: from AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::23) by AM6PR04CA0044.outlook.office365.com (2603:10a6:20b:f0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.15 via Frontend Transport; Wed, 21 Sep 2022 15:03:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT059.mail.protection.outlook.com (100.127.140.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Wed, 21 Sep 2022 15:03:02 +0000 Received: ("Tessian outbound 8ec96648b960:v124"); Wed, 21 Sep 2022 15:03:02 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e6b3088f36ea5565 X-CR-MTA-TID: 64aa7808 Received: from b0e4fb189e6c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BBDE8893-F52B-4559-99A9-5E508DD3C180.1; Wed, 21 Sep 2022 15:02:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0e4fb189e6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 21 Sep 2022 15:02:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jo7VlSRjeZdmTUTG+ElSSz7Nipi28o713fAzl52Pgi2MWq6P5oVOBBuxfzK57T/u8IQso+AFlmKgmQdGWNbTR54LaHYJ3Mh5wWuNe9ZvV/66QMw0olgEwKcixmaZNKaewIj6rVLHJCuaPKQL4X2qcqhI7XCx4Ne7rLV+SRLP4UrYEc6+Ru/abdrE5ohrSRucDkWqt6Pn6pV4pyTtwfSxbdsVD6p8yKXVcc9ANRFNyOYP6ozZuolcPHX57QDUgYfMWygN8uxweROLqnysaxz3M6N36SjejN37cJ7RqwZEjCSQ+TbgkwAzfGK+NfMNFBRtAa7S/nYaDlHNWsK82hu6+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/N2FICUAAKn1thUAlS5WWsrOgiyRKoNLWZN2o2Fvhx0=; b=b7Ct2hE6pogh9H89eWHtci9v9xOEcMR6/xiV4dGvM1FP/5om4UAbx3ZAEVDBU+N9lc6JfMiegire319puEEo4EsK3yI5F2tfbpu9m+PwFztyHLHvoEqzPPYKFrvgbnzvz+gMnan6lfMkfacRzhSVikNwa5iaBUZKpLaFMjkYKX6k0qocnCQuUw3NlJmHBekiQERmK0riwk/qU5McUHScz2cM3J7B8d+mq9z8JKe/XgrJc7a1KOJLeduog0w/2bHhuXnHjc4VDHDZBzrGojKxcuQMn26ENJVoLLNOrMGh+iU9BBVTzzYxXayX86kk2Fbh8l4JF2KdtYZJRBMXuC7TtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/N2FICUAAKn1thUAlS5WWsrOgiyRKoNLWZN2o2Fvhx0=; b=kJ+0Zc1nMDl6x0PKv7HHhIywKir90CeGKsbzVzIlf/TgnQVsRnn5MmGX1gj8EF5L16chFRydI6sgKBTTbVC6fyc5PwN8lRZMWCU0Vs4MZyMyanEA2rWHA9Pm4yPtj8kwPmYq6HNZ7CPtZnltBnufvBDi2z0KusChocglrWNUBTs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB8955.eurprd08.prod.outlook.com (2603:10a6:10:466::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5632.19; Wed, 21 Sep 2022 15:02:50 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%7]) with mapi id 15.20.5654.016; Wed, 21 Sep 2022 15:02:50 +0000 Message-ID: <61abb7d2-043a-9e5f-145f-34df365e05a3@arm.com> Date: Wed, 21 Sep 2022 16:02:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [edk2-platforms][PATCH v2 1/2] SbsaQemu/OemMiscLib: Update for new OemMiscLib APIs To: Nhi Pham , devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, "nd@arm.com" References: <20220919021904.2110188-1-nhi@os.amperecomputing.com> <20220919021904.2110188-2-nhi@os.amperecomputing.com> From: "Sami Mujawar" In-Reply-To: <20220919021904.2110188-2-nhi@os.amperecomputing.com> X-ClientProxiedBy: LO4P123CA0326.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18c::7) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB8955:EE_|AM7EUR03FT059:EE_|AS8PR08MB9720:EE_ X-MS-Office365-Filtering-Correlation-Id: a96f8f6f-cde5-4384-78dc-08da9be26159 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3WWRA+vDlDqu49yo4xjvPfIUNtB1YouoK7SsXQ8E7ylrs98U3RpcHIXaOwK8+3x+CUOawT3wWU1/dqhYOTz38tQzw2N0XKJ49+0/3wyv54Ok3I8p7xotD2vuqR8PQU/YEq/VWI9SeV2oy6JPDs3eBnC10gba1FBUZNjSQKoogyeYZonzh3qxxooajSn/gMkZL55ydkqOLmTcPeGnlxWcr06W//blACb9mpwAHF5Q7ArBFldMi+2g4RIR6/67gsJAYBDYrze7yw1Y21J8Kk19Rdc2cDHu0z1lwcnVH+uDTB1ojpM2FpzCnszGQ4FUlxao1+R4ffTdg3T3hFFi/3AN7aDwDc+GGCnegKdRbl9wZvkHl3LOfAT6zFsqewM2W0FvokcpnsRr7dE0yWatW5W3cJGlnxUCccaxdTWZoM8RYXcjQa8RLqpSStL0u43zGY8ki4L5PB2UfjkIMxcoRmaj1C8d4V8Y6vsjpsD/D1lqVaqYyRyM6Jy7d4YvQD/IBxZak1D/IL3k9Ik1Hm+7/SzgomEa3Zy/ImYOqC93AWQwbd3p7bcXMd+t7qJ+mXOWNQHjJ8WTGDY72eE54JWJIOE4nnURZqefX0qIQDcqSTMHF05OEi4pENiMYO3wTznUy/TJWJkVySVELzpNEl+D5gekMR7L3+07jQlJrMUUfveAs2WmlKyTXcZ3G1rMM6SAAIt6c2AN6Q9CRwfFeACNG+cO371R5uPVw7NOYheC7yd7YwCv/oR632YgKOwdFN64HwayXS1oh0wMWIk7LtT3cp6wOg9UAAXNop9L9GIuHfJhv9g= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(451199015)(38100700002)(4326008)(66476007)(36756003)(2906002)(6506007)(26005)(53546011)(86362001)(66946007)(6486002)(6512007)(8936002)(66556008)(6666004)(41300700001)(8676002)(478600001)(31696002)(2616005)(186003)(5660300002)(31686004)(316002)(44832011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8955 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22cf1d0c-4232-456f-7749-08da9be25a31 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SRqNBN4zRu55Oz4eQ+C3lNA6Jvf5cFrrpK5gQX4hfcKTFHSCGFfq60iD9deeCFUihW3u4b7XPy6NbmglRxBW982DiT1oO/s0XtaUyBqnYcvZG60yV668u+jNWJoX+BhjuZ1w55lGeI6phFSXhSCEPnegClZ0M6dB3iydNsNK2jfMAg3xnEm2OSU2UCdr/d3SA0aDndSRukTlA9tGcu8O955YaENDbSqPnF/oweDzRdp7qo4VW630k3dFu+Tv3emc1dmo7VkA8JnhlpX5woripenJsOwM+qgO4kNPY00zrjZWGMsshHlVRG25x7cfGzge5NJc16wfnzxspwLFYyQAjITP4pq5d+PT5tm88Ixmju3qXeJ/KeOYG9PuleWwIWD5maT40RHAeDy14NgHCvsS9xE/YvyBjBHMEFTPqm4jSwRE3/XOIaxrukMpf9PckFzTJgjNitqa1wGMtMr9rRi8r3oHBlFwAch4N460fhW8JGop+5FOrTWbcuRdAKhsotKeJAhGE15gvKeR1ngQfYWtaEqf+jA6tOXFAh97xeTM42BFfcKrZ0mQzZmGQEPotruqGFtXI2DYNQjuBo1lkcNI0yHXp65wL9wGZ+BhMjNiqLP7MjcibyojJ65dh5eqIuC/P16RDSvjsOIuNlx1KxV//saqTeklcuVKqH69bxUCv/Ym8L/19EqfChlEBely2usFqHzqo1XLypSiISdu3+J7+WPUkMuI6wN8V77H2MTpDSt3/iORJmUEUg/rfLOU5JkdITwy+yI4S1Q7AxjKy6qDbGdWDF2mTH3W/z3VjqxgXCk= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(136003)(376002)(346002)(396003)(451199015)(46966006)(36840700001)(40470700004)(186003)(44832011)(5660300002)(8936002)(36756003)(70206006)(70586007)(31696002)(86362001)(316002)(40460700003)(8676002)(47076005)(4326008)(2616005)(336012)(36860700001)(81166007)(478600001)(6486002)(40480700001)(6506007)(356005)(82310400005)(6512007)(26005)(31686004)(41300700001)(82740400003)(6666004)(2906002)(53546011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2022 15:03:02.4045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a96f8f6f-cde5-4384-78dc-08da9be26159 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9720 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/09/2022 03:19 am, Nhi Pham wrote: > This is to reflect the new APIs added to edk2/OemMiscLib library. > > Signed-off-by: Nhi Pham > --- > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf | 5 +++ > Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c | 42 ++++++++++++++++++++ > 2 files changed, 47 insertions(+) > > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > index 04a07a55cee9..a34f54d431d4 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.inf > @@ -34,7 +34,12 @@ [LibraryClasses] > IoLib > PcdLib > > +[Guids] > + gZeroGuid > + > [Pcd] > + gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease > + gArmTokenSpaceGuid.PcdSystemBiosRelease > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdDeviceTreeBaseAddress > > gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemManufacturer > diff --git a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > index 326bb56bcfa3..3ccf22bf282d 100644 > --- a/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > +++ b/Platform/Qemu/SbsaQemu/OemMiscLib/OemMiscLib.c > @@ -9,6 +9,7 @@ > **/ > > #include > +#include > #include > #include > #include > @@ -330,3 +331,44 @@ OemGetChassisNumPowerCords ( > { > return 1; > } > + > +/** > + Fetches the system UUID. > + > + @param[out] SystemUuid The pointer to the buffer to store the System UUID. > + > +**/ > +VOID > +EFIAPI > +OemGetSystemUuid ( > + OUT GUID *SystemUuid > + ) > +{ > + CopyGuid (SystemUuid, &gZeroGuid); > +} > + > +/** Fetches the BIOS release. > + > + @return The BIOS release. > +**/ > +UINT16 > +EFIAPI > +OemGetBiosRelease ( > + VOID > + ) > +{ > + return PcdGet16 (PcdSystemBiosRelease); > +} > + > +/** Fetches the embedded controller firmware release. > + > + @return The embedded controller firmware release. > +**/ > +UINT16 > +EFIAPI > +OemGetEmbeddedControllerFirmwareRelease ( > + VOID > + ) > +{ > + return PcdGet16 (PcdEmbeddedControllerFirmwareRelease); > +}