From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.84]) by mx.groups.io with SMTP id smtpd.web10.5175.1688034551703537985 for ; Thu, 29 Jun 2023 03:29:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=HmmiGy0R; spf=pass (domain: arm.com, ip: 40.107.7.84, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Hkixunx3MQC8iM6f5lrtkJo/kjGKEkHcIVqyJO/HDY=; b=HmmiGy0RmE1haYkKJpUDlWREoGR1O2nCK+hnm7C+w8GW7AX7vjgHedlrSHhjtOjVLg97Rf5X6gk435SBMqcAj73KQfKt90tZR+El4nZrMt4ldbR5/PXR0HfJL+E5xy2fDDvMdNv88gBniZE0os4FN75m8MJSlIATm6fVk86orxo= Received: from AM6PR10CA0010.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::23) by AS8PR08MB6134.eurprd08.prod.outlook.com (2603:10a6:20b:291::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Thu, 29 Jun 2023 10:29:04 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::1c) by AM6PR10CA0010.outlook.office365.com (2603:10a6:209:89::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.21 via Frontend Transport; Thu, 29 Jun 2023 10:29:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 10:29:04 +0000 Received: ("Tessian outbound b11b8bb4dfe8:v142"); Thu, 29 Jun 2023 10:29:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 52d5d13c3a4814ec X-CR-MTA-TID: 64aa7808 Received: from 34c9dc27f15e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FF8B3E4B-A6D3-44FB-93FB-14766BBDA447.1; Thu, 29 Jun 2023 10:28:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34c9dc27f15e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Jun 2023 10:28:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gIYFK6Ytb8vheYOwyApuPwnNpel7/gq/wGmpQQ9X8D7b2/KZ1ZuDXJ9e31JhB4h/q/grQSByWuaxXZTNUdJFo6EDQ8uZfJHHlX5NenfsqVzrAVwktpxCxFPf6YVpiX8/GqySJqbwg7Z24ejDjP6KW5mvh7pvfV64Nj7833tNwu5sLRdmT7IXYQtiHGSJoT6Sh4CmfWoqCwCuQA20bdh7kNGqjekj5+mAcW5iro/bTVz9AkVDC8T8A+vAkHiynxOa63ti4BnqEMu+57tFhRbTBXuk6+QEOUwhbtoXHg6fe6eGEbNg8SP5dh5A1JMW8vR0k0cwhrlo7a3ZUzykbZDuww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Hkixunx3MQC8iM6f5lrtkJo/kjGKEkHcIVqyJO/HDY=; b=J2o/XUCnKTBJhIQqYkMHx129ZKv5tvPvXPxTYqyTjM2S0BK5emQ1YXwgwBjcf9ppT2hsNBQ580ySAgHkUELBZ+AVTw36F7SOk1uu875FZKoDcvdWM7eBhLAQKEt+OhLNM51SIWRMwlwEmz8LzdJHKEgSZiA6vyFn5WKj1lEOy9R0eeQqXmyxkxd7/2AekT1qstmNTfFsVLHVvu/XsL/3FmilvoemIK/Rr6ChPXn6szBmx/myI1TRuZxwb+ekovq46pcpn3UEslURSIG4PqqYxqQMt6BLHLpCuybDurXo6zarWNPI/YIb4DroaBhuNjSMVRn/4A/IGpKiiQXwbognuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Hkixunx3MQC8iM6f5lrtkJo/kjGKEkHcIVqyJO/HDY=; b=HmmiGy0RmE1haYkKJpUDlWREoGR1O2nCK+hnm7C+w8GW7AX7vjgHedlrSHhjtOjVLg97Rf5X6gk435SBMqcAj73KQfKt90tZR+El4nZrMt4ldbR5/PXR0HfJL+E5xy2fDDvMdNv88gBniZE0os4FN75m8MJSlIATm6fVk86orxo= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by DU0PR08MB9050.eurprd08.prod.outlook.com (2603:10a6:10:47a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.26; Thu, 29 Jun 2023 10:28:56 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850%4]) with mapi id 15.20.6544.019; Thu, 29 Jun 2023 10:28:56 +0000 Message-ID: <61d8aa49-f0f7-a1b9-432d-ec9041b5b961@arm.com> Date: Thu, 29 Jun 2023 11:28:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 8/8] SecurityPkg/RngDxe: Simplify Rng algorithm selection for Arm To: pierre.gondois@arm.com, devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Ard Biesheuvel , Jose Marinho , Samer El-Haj-Mahmoud , "nd@arm.com" References: <20230509074042.1523428-1-pierre.gondois@arm.com> <20230509074042.1523428-9-pierre.gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20230509074042.1523428-9-pierre.gondois@arm.com> X-ClientProxiedBy: LO2P265CA0488.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13a::13) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|DU0PR08MB9050:EE_|AM7EUR03FT027:EE_|AS8PR08MB6134:EE_ X-MS-Office365-Filtering-Correlation-Id: b1b971a3-f2cc-4792-88ab-08db788ba987 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x1SD8L9wPrpDLOp4MXVaVSgNAz0l4PMZLiGlJzBFJKybLokiIHlZEFwtHQvBPn2Dub6xjHoajT11ehK9m/3lMZ7UCCPY0NjTmtzvQS4E9XB2vWbJkTAbuI90TptRhIiMpnbF9RKB8erN/xu6oMqfD4fg/jkZjJZUK7tQgvGIVM/WD67/6tdpyQHarlsDrUSsSVZRoHwSX1HLDtCgjgOi7wlXPJhQ/dHEdkMS9i0sFeS6Klj87FGwHXb3k/jfL6KJbBp4WR3r1DgpArVs880lyO9ScQlXOG4R8HzAuMNuGreafn7ACSIihH8o++opi1NfZyw81cVgAizbyOxlH496jSU1GHWe3+Tbr81/9zSXnd9wO7K12vVJFBxyY6pEdTPNG4RRyP5XQQxEWf7hKjmqWxEmSf+JVFDRP4Nc01bXv7zqkx6uvxL43TK1LuDqxn1f/o4Movpr5+7O1VhvcQU08mP8meh6v55Unj4Aviw55L5IDNIlsG5pT9yPA5Zrwgk2cu0SwE68PfFJG55nuAhKwv4nOoNFgVqWCV9QdDw1cDlLkjGlZl7uSyrsAy6R3ARAHer+rn4HyB7xjRMnN9PJNDiZJI4SGW95kMLUCp/fi8JtxQljIiVXYvF5+PfvrYn1dG2IGj1Cn6l1efYWRVQ0Zg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(26005)(54906003)(2906002)(6486002)(186003)(2616005)(38100700002)(83380400001)(53546011)(6506007)(86362001)(31696002)(41300700001)(478600001)(66556008)(66476007)(316002)(4326008)(36756003)(8936002)(66946007)(6512007)(31686004)(44832011)(5660300002)(8676002)(15650500001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9050 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1829148b-4bf5-40a5-ea47-08db788ba4a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wrwheRzxI/7wYay6Qrbh8/PSOFgdVFweTzG0BedATq2mK7dkjm3zEeOiG/AtyUbCjlO77umz5V8bIpFrNha3UwOslhzZv1kHZhvy9mg0UEoKYRZKkEHIL4sixPQlB0XsKs9wlz12olfT87xQUGzncLfBjnlCCJU/pzhjZffV/1Ikc+FrHgCiUnrFQ5RA5G2kbLinalysexpIi9Wg8j/tn+c2EcCbhx1hgW+rAUrELa0HGvLi2OHc/xett1nnRqSErqssExikao37k4MFQxC0LDxbm8GBWc9WbjsRyvv5/U0YLU/r26ACypjkdD6uN02j+MHnFXzU7W3xOeuu3UN428AI6ByOol2r8a351AZi3VslET7Yl/QcKli+z98U8eXYHr4mbkQRqy+OFkptUNi8u+sV69yy2HAariiB0Ud+XM2UFboCZ9rD19SXDqvZSv6ONzGaLnFj0X2ANUej6wGCIjFrkubvWtmOG4gcYyI6ESw/dIyxTGdqV7+IlzoABFEVeQwINWtRikcO15yDtfH22nhYMMfZrHq8FklPKHT/RtnzIrj9/pvqmPy6QxNyO+Pl4t1wiNs/6cfr+N2UL/cRlgCaPvLgIrgqvOyUt/VaYwNRM0IKkpjXMHjTFZSY8spu79ZRuJLySIy+oapSkk3kYyhk3HkppBMXoGa8f9wPS/mhWi9Q4gJCubkAPurFYCjgc7cz14ct2lSC85V7nvrQptGD08mMWVxFJtFDIlT9qC+9VSq9ekDOEJf+KmUKz5+ADQkUix7Kgp27AIl0NmfZFw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(39860400002)(136003)(451199021)(46966006)(40470700004)(36840700001)(316002)(40460700003)(6512007)(41300700001)(83380400001)(82310400005)(86362001)(336012)(31696002)(36860700001)(53546011)(186003)(44832011)(6506007)(26005)(2616005)(2906002)(15650500001)(82740400003)(356005)(81166007)(40480700001)(47076005)(5660300002)(36756003)(8676002)(8936002)(54906003)(31686004)(4326008)(6486002)(478600001)(70586007)(70206006)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 10:29:04.2451 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1b971a3-f2cc-4792-88ab-08db788ba987 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6134 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/05/2023 08:40 am, pierre.gondois@arm.com wrote: > From: Pierre Gondois > > The first element of mAvailableAlgoArray is defined as the default > Rng algorithm to use. Don't go through the array at each RngGetRNG() > call and just return the first element of the array. > > Signed-off-by: Pierre Gondois > --- > .../RandomNumberGenerator/RngDxe/ArmRngDxe.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/ArmRngDxe.c b/SecurityPkg/RandomNumberGenerator/RngDxe/ArmRngDxe.c > index 78a18c5e1177..7a42e3cbe3d2 100644 > --- a/SecurityPkg/RandomNumberGenerator/RngDxe/ArmRngDxe.c > +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/ArmRngDxe.c > @@ -77,7 +77,6 @@ RngGetRNG ( > ) > { > EFI_STATUS Status; > - UINTN Index; > GUID RngGuid; > > if ((This == NULL) || (RNGValueLength == 0) || (RNGValue == NULL)) { > @@ -88,21 +87,13 @@ RngGetRNG ( > // > // Use the default RNG algorithm if RNGAlgorithm is NULL. > // > - for (Index = 0; Index < mAvailableAlgoArrayCount; Index++) { > - if (!IsZeroGuid (&mAvailableAlgoArray[Index])) { > - RNGAlgorithm = &mAvailableAlgoArray[Index]; > - goto FoundAlgo; > - } > - } > - > - if (Index == mAvailableAlgoArrayCount) { > - // No algorithm available. > - ASSERT (Index != mAvailableAlgoArrayCount); > - return EFI_DEVICE_ERROR; > + if (mAvailableAlgoArrayCount != 0) { > + RNGAlgorithm = &mAvailableAlgoArray[0]; > + } else { > + return EFI_UNSUPPORTED; > } > } > > -FoundAlgo: > Status = GetRngGuid (&RngGuid); > if (!EFI_ERROR (Status) && > CompareGuid (RNGAlgorithm, &RngGuid))