Re: [edk2-devel] [PATCH v2 5/7] DynamicTablesPkg.ci.yaml: Add debug macro exception

["Michael Kubacki" <mikuback@linux.microsoft.com>]

Thanks Sami, that's correct.

On 9/14/2023 5:22 AM, Sami Mujawar wrote:
> Hi Michael,
> 
> Apologies, I initially misunderstood what this patch was trying to do.
> As I understand this is an exception for one of the special cases to be handled differently by the plugin.
> 
> Acked-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> Regards,
> 
> Sami Mujawar
> 
> On 14/09/2023, 09:42, "devel@edk2.groups.io <mailto:devel@edk2.groups.io> on behalf of Sami Mujawar via groups.io" <devel@edk2.groups.io <mailto:devel@edk2.groups.io> on behalf of sami.mujawar=arm.com@groups.io <mailto:arm.com@groups.io>> wrote:
> 
> 
> Hi Michael,
> 
> 
> I would prefer to have the debug macro checks enabled in DynamicTablesPkg to catch any issues.
> 
> 
> Please do not disable this feature for this package.
> 
> 
> Regards,
> 
> 
> Sami Mujawar
> 
> 
> On 13/09/2023, 18:08, "mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com> <mailto:mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>>" <mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com> <mailto:mikuback@linux.microsoft.com <mailto:mikuback@linux.microsoft.com>>> wrote:
> 
> 
> 
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com> <mailto:michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>>
> 
> 
> 
> 
> Adds a CI YAML entry to acknowledge a case where custom strings
> contain print specifiers for a single debug macro.
> 
> 
> 
> 
> Cc: Sami Mujawar <Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com> <mailto:Sami.Mujawar@arm.com <mailto:Sami.Mujawar@arm.com>>>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com> <mailto:Alexei.Fedorov@arm.com <mailto:Alexei.Fedorov@arm.com>>>
> Cc: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com> <mailto:pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com> <mailto:michael.kubacki@microsoft.com <mailto:michael.kubacki@microsoft.com>>>
> ---
> DynamicTablesPkg/DynamicTablesPkg.ci.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
> 
> 
> 
> 
> diff --git a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> index 5addf8626841..1d41d44bbf33 100644
> --- a/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> +++ b/DynamicTablesPkg/DynamicTablesPkg.ci.yaml
> @@ -130,5 +130,13 @@
> # should be ignore
> "AdditionalIncludePaths": [] # Additional paths to spell check
> # (wildcards supported)
> + },
> +
> + "DebugMacroCheck": {
> + "StringSubstitutions": {
> + # DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> + # Reason: Debug format strings are dynamically set.
> + "Parser[Index].Format": "%d"
> + }
> }
> }


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108805): https://edk2.groups.io/g/devel/message/108805
Mute This Topic: https://groups.io/mt/101341656/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-