From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2AFACD8118F for ; Fri, 5 Apr 2024 13:33:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=OGGeKmFY6ufZ/yR3eGu9y+duQueQcqAj0lb3u+K83bI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:Cc:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712323999; v=1; b=dubpqt+yWba9CnNdLioGlE5ngVOL8qZcy/vC6hGQeA552BnaR/b492Uu7nH91vJJgKUpLP6r 4Gj7mBDb3i/fqtHI3HOB9bcbBW2qGwOu0DdRWOEOHvgw9ulgsXEDT84c4q6xN1DRJOB8Es9OTWR EBSPcdUxpkoe2rDJXln21JuzRBoNkoOOdrKMpSgzR32sW5zGcfGToNT2/uEsT97nm48nHrj1P1j vpcxhlVrSeKZ54gnQea5zExCXeXHD5zDFVrlMHR/z+GUY02GUUdAo7B1jiLj6d623nxa6kJ4EYj NpLZjdhDizj29bz4w/DHq4D86EyM32+IsSt/Nk1L0fQ8g== X-Received: by 127.0.0.2 with SMTP id 6X7ZYY7687511xRvyUwpATjS; Fri, 05 Apr 2024 06:33:19 -0700 X-Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by mx.groups.io with SMTP id smtpd.web11.11841.1712323998301101191 for ; Fri, 05 Apr 2024 06:33:18 -0700 X-Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 4D12B3F20D for ; Fri, 5 Apr 2024 13:33:16 +0000 (UTC) X-Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2d81d7b2f00so18887601fa.2 for ; Fri, 05 Apr 2024 06:33:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCV8fWQko+C1UTDFmRqFyclG7YtstNoRHp5d+Kb5wzGv9ULhbJ8PqFjc8dohEc+OrmnKJUVihKAjDFJXVZnZUAeG0bpNWw== X-Gm-Message-State: Z5MmGdug20KrJGC04x5V5QZdx7686176AA= X-Received: by 2002:a2e:9092:0:b0:2d8:3fc0:db5c with SMTP id l18-20020a2e9092000000b002d83fc0db5cmr1374413ljg.20.1712323995650; Fri, 05 Apr 2024 06:33:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIPT44j+81qWYuGtPp/Dih5QBt8L33RfTwz4unFZ7Yeb3FkZYtZd3KmJgoIW9DSUZbyYCBxQ== X-Received: by 2002:a2e:9092:0:b0:2d8:3fc0:db5c with SMTP id l18-20020a2e9092000000b002d83fc0db5cmr1374381ljg.20.1712323995019; Fri, 05 Apr 2024 06:33:15 -0700 (PDT) X-Received: from [192.168.123.126] (ip-062-143-245-032.um16.pools.vodafone-ip.de. [62.143.245.32]) by smtp.gmail.com with ESMTPSA id fl22-20020a05600c0b9600b004162bf2f149sm4841436wmb.48.2024.04.05.06.33.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 06:33:14 -0700 (PDT) Message-ID: <61f84bd4-e72f-4e3f-9b51-866cdd18885d@canonical.com> Date: Fri, 5 Apr 2024 15:33:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses To: phillip@axleos.com References: <20240405125855.48427-1-phillip@axleos.com> Cc: Ard Biesheuvel , devel@edk2.groups.io, Jiewen Yao , Gerd Hoffmann From: "Heinrich Schuchardt" In-Reply-To: <20240405125855.48427-1-phillip@axleos.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 05 Apr 2024 06:33:19 -0700 Resent-From: heinrich.schuchardt@canonical.com Reply-To: devel@edk2.groups.io,heinrich.schuchardt@canonical.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=dubpqt+y; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=canonical.com (policy=none) On 05.04.24 14:58, phillip@axleos.com wrote: > From: Phillip Tennen >=20 > UsbMouseDxe was missing from the OVMF build description, so > the Simple Pointer Protocol wasn't usable from within QEMU. >=20 > Here's an example of somone getting tripped up by this: > https://forum.osdev.org/viewtopic.php?f=3D1&t=3D31572. >=20 > I worked around this by including the below patch in my local > builds, and was encouraged by Heinrich Schuchardt to submit a patch. >=20 > I have not contributed to this project before, so please accept > my apologies if I've formatted anything incorrect. All the best. >=20 > Signed-off-by: Phillip Tennen >=20 > --- > OvmfPkg/OvmfPkgX64.dsc | 1 + > OvmfPkg/OvmfPkgX64.fdf | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 56c920168d..d76a263859 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -953,6 +953,7 @@ > MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > + MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf Thank you Phillip for contributing. https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions has some information on the contribution process. Currently applying the patch in this mail fails: git am --keep-cr '[PATCH] OvmfPkg: OVMF supports USB mouses -=20 phillip@axleos.com - 2024-04-05 1458.eml' warning: quoted CRLF detected Applying: OvmfPkg: OVMF supports USB mouses .git/rebase-apply/patch:14: trailing whitespace. MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf .git/rebase-apply/patch:26: trailing whitespace. INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf error: patch failed: OvmfPkg/OvmfPkgX64.dsc:953 error: OvmfPkg/OvmfPkgX64.dsc: patch does not apply error: patch failed: OvmfPkg/OvmfPkgX64.fdf:342 error: OvmfPkg/OvmfPkgX64.fdf: patch does not apply Patch failed at 0001 OvmfPkg: OVMF supports USB mouses I guess it is just a problem with the line endings. Please, run 'python3 BaseTools/Scripts/SetupGit.py' once. This will set=20 up your git repository with the Tianocore defaults for submitting patches. It would be preferable to match the existing indentation. Maybe make both insertions at the same place under UsbKbDxe.inf. Otherwise looks good to me and works fine: The USB mouse is usable in=20 your IRC application. The file 'Maintainers' has a list of the persons that should be CCed for=20 OvmfPkg patches. Best regards Heinrich > =20 > !include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc > =20 > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index eb3fb90cb8..bfe201a352 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -342,6 +342,7 @@ INF MdeModulePkg/Bus/Pci/EhciDxe/EhciDxe.inf > INF MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf > INF MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf > INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > +INF MdeModulePkg/Bus/Usb/UsbMouseDxe/UsbMouseDxe.inf > INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > =20 > INF OvmfPkg/QemuVideoDxe/QemuVideoDxe.inf -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117457): https://edk2.groups.io/g/devel/message/117457 Mute This Topic: https://groups.io/mt/105348119/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-