From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.8573.1601544145198261117 for ; Thu, 01 Oct 2020 02:22:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Sz++Er3/; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601544144; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0GZedkE9KYyhPeyy+HbWKuMQtyroF3fcv1C8SXXMm8=; b=Sz++Er3/+GnIW0VOuHAXwtoQKF5jn9yvrAVo93maPsZxDRiLvIDOlwVQU/JAqxoMCA+9Z0 Ri5GDH7lsibJDGEJBCZQhWD/Z0BsRK1w91zbep4pP/6P766asc41UhiiuMUNJ9YivskH5b vsOlT+NxZ39sahwzsd+hakX7giKp7Sk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-uklC0QctNBawKyyM4Vam9w-1; Thu, 01 Oct 2020 05:22:21 -0400 X-MC-Unique: uklC0QctNBawKyyM4Vam9w-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 00CBC801AAC; Thu, 1 Oct 2020 09:22:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-110.ams2.redhat.com [10.36.113.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 958E17367B; Thu, 1 Oct 2020 09:22:18 +0000 (UTC) Subject: Re: [RedfishPkg PATCH v2 1/4] RedfishPkg: Initial commit of RedfishPkg. To: changab , devel@edk2.groups.io Cc: Nickle Wang , Andrew Fish , Leif Lindholm , Michael D Kinney References: <20200930015611.18375-1-abner.chang@hpe.com> <20200930015611.18375-2-abner.chang@hpe.com> From: "Laszlo Ersek" Message-ID: <6255f75f-d088-e1be-74c8-1da0f65c149f@redhat.com> Date: Thu, 1 Oct 2020 11:22:17 +0200 MIME-Version: 1.0 In-Reply-To: <20200930015611.18375-2-abner.chang@hpe.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/30/20 03:56, changab wrote: > Initial version of RedfishPkg. > > Signed-off-by: Wu Jiaxin > Signed-off-by: Fu Siyuan > Signed-off-by: Wang Fan > Signed-off-by: Chang Abner > Cc: Nickle Wang > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > --- > RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++ > RedfishPkg/RedfishPkg.dec | 18 ++++++++++ > RedfishPkg/RedfishPkg.dsc | 40 +++++++++++++++++++++ > 3 files changed, 125 insertions(+) > create mode 100644 RedfishPkg/RedfishPkg.ci.yaml > create mode 100644 RedfishPkg/RedfishPkg.dec > create mode 100644 RedfishPkg/RedfishPkg.dsc based on the diffstat: Acked-by: Laszlo Ersek However, I suggest resending this series (more precisely, sending a v3). Here's why: The patch seems to have been posted "From: changab ". This will be recorded in the git history, by git-am. (The mergify bot overwrites the Committer meta-field, but the Author meta-field remains in place, from git-am -- and that works from "From:".) I think "Abner Chang " looks a whole lot better than "changab ", in the Author field. So please rebase this series locally, picking the "edit" action for each patch, and then re-commit each patch with: git commit --amend --author="Abner Chang " git rebase --continue Additionally, please update the "user.name" knob in your git config. Sorry for obsessing about this -- I'd really like the git history to look *nice*. Thanks Laszlo