From: Santhapur Naveen <naveens@amiindia.co.in>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Repeated condition check
Date: Wed, 20 Sep 2017 06:35:11 +0000 [thread overview]
Message-ID: <625A2455CC232F40B0F38F05ACED6D97012CA98291@VENUS1.in.megatrends.com> (raw)
Hi all,
There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()
VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
IN VOID *Context
)
{
...
if (Type != ICMP_V6_DEST_UNREACHABLE &&
Type != ICMP_V6_PACKET_TOO_BIG &&
-Type != ICMP_V6_PACKET_TOO_BIG &&
+Type != ICMP_V6_TIME_EXCEEDED &&
Type != ICMP_V6_PARAMETER_PROBLEM) {
//
// The type of the receveid packet should be an ICMP6 error message.
//
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
}
...
}
Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.
Thank you
Naveen
next reply other threads:[~2017-09-20 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 6:35 Santhapur Naveen [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-22 8:40 Repeated condition check Santhapur Naveen
2017-09-25 5:02 ` Wu, Jiaxin
2017-09-25 5:05 ` Santhapur Naveen
2017-09-25 5:10 ` Wu, Jiaxin
2017-09-25 5:12 ` Santhapur Naveen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=625A2455CC232F40B0F38F05ACED6D97012CA98291@VENUS1.in.megatrends.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox