* Repeated condition check
@ 2017-09-20 6:35 Santhapur Naveen
0 siblings, 0 replies; 6+ messages in thread
From: Santhapur Naveen @ 2017-09-20 6:35 UTC (permalink / raw)
To: edk2-devel@lists.01.org
Hi all,
There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()
VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
IN VOID *Context
)
{
...
if (Type != ICMP_V6_DEST_UNREACHABLE &&
Type != ICMP_V6_PACKET_TOO_BIG &&
-Type != ICMP_V6_PACKET_TOO_BIG &&
+Type != ICMP_V6_TIME_EXCEEDED &&
Type != ICMP_V6_PARAMETER_PROBLEM) {
//
// The type of the receveid packet should be an ICMP6 error message.
//
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
}
...
}
Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.
Thank you
Naveen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Repeated condition check
@ 2017-09-22 8:40 Santhapur Naveen
2017-09-25 5:02 ` Wu, Jiaxin
0 siblings, 1 reply; 6+ messages in thread
From: Santhapur Naveen @ 2017-09-22 8:40 UTC (permalink / raw)
To: edk2-devel@lists.01.org
Hello guys,
Any update?
Thank you
Naveen
-----Original Message-----
From: Santhapur Naveen
Sent: Wednesday, September 20, 2017 12:05 PM
To: edk2-devel@lists.01.org
Subject: Repeated condition check
Hi all,
There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()
VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
IN VOID *Context
)
{
...
if (Type != ICMP_V6_DEST_UNREACHABLE &&
Type != ICMP_V6_PACKET_TOO_BIG &&
-Type != ICMP_V6_PACKET_TOO_BIG &&
+Type != ICMP_V6_TIME_EXCEEDED &&
Type != ICMP_V6_PARAMETER_PROBLEM) {
//
// The type of the receveid packet should be an ICMP6 error message.
//
gBS->SignalEvent (RxData->RecycleSignal);
goto ON_EXIT;
}
...
}
Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.
Thank you
Naveen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Repeated condition check
2017-09-22 8:40 Santhapur Naveen
@ 2017-09-25 5:02 ` Wu, Jiaxin
2017-09-25 5:05 ` Santhapur Naveen
0 siblings, 1 reply; 6+ messages in thread
From: Wu, Jiaxin @ 2017-09-25 5:02 UTC (permalink / raw)
To: Santhapur Naveen, edk2-devel@lists.01.org; +Cc: Ye, Ting, Fu, Siyuan
Hi Naveen,
We may ignore your email if you don't attach any specific receiver (TO OR CC list):(.
For the issue, I agree the fix. So, can you help to report the issue on Bugzilla? We will create the formal patch to fix it.
Thanks,
Jiaxin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Santhapur Naveen
> Sent: Friday, September 22, 2017 4:40 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] Repeated condition check
>
> Hello guys,
>
> Any update?
>
> Thank you
> Naveen
>
> -----Original Message-----
> From: Santhapur Naveen
> Sent: Wednesday, September 20, 2017 12:05 PM
> To: edk2-devel@lists.01.org
> Subject: Repeated condition check
>
> Hi all,
>
> There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()
>
> VOID
> EFIAPI
> PxeBcIcmp6ErrorDpcHandle (
> IN VOID *Context
> )
> {
> ...
>
> if (Type != ICMP_V6_DEST_UNREACHABLE &&
> Type != ICMP_V6_PACKET_TOO_BIG &&
> -Type != ICMP_V6_PACKET_TOO_BIG &&
> +Type != ICMP_V6_TIME_EXCEEDED &&
> Type != ICMP_V6_PARAMETER_PROBLEM) {
> //
> // The type of the receveid packet should be an ICMP6 error message.
> //
> gBS->SignalEvent (RxData->RecycleSignal);
> goto ON_EXIT;
> }
> ...
> }
>
> Unfortunately, some error checking tools were not able to capture this.
> Please confirm and take the necessary action.
>
> Thank you
> Naveen
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Repeated condition check
2017-09-25 5:02 ` Wu, Jiaxin
@ 2017-09-25 5:05 ` Santhapur Naveen
2017-09-25 5:10 ` Wu, Jiaxin
0 siblings, 1 reply; 6+ messages in thread
From: Santhapur Naveen @ 2017-09-25 5:05 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Fu, Siyuan
Hi Jiaxin,
Duly noted.
Will mention one of you in the TO/CC list from here onwards.
Thank you
Naveen
-----Original Message-----
From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
Sent: Monday, September 25, 2017 10:33 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan
Subject: RE: Repeated condition check
Hi Naveen,
We may ignore your email if you don't attach any specific receiver (TO OR CC list):(.
For the issue, I agree the fix. So, can you help to report the issue on Bugzilla? We will create the formal patch to fix it.
Thanks,
Jiaxin
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Santhapur Naveen
> Sent: Friday, September 22, 2017 4:40 PM
> To: edk2-devel@lists.01.org
> Subject: Re: [edk2] Repeated condition check
>
> Hello guys,
>
> Any update?
>
> Thank you
> Naveen
>
> -----Original Message-----
> From: Santhapur Naveen
> Sent: Wednesday, September 20, 2017 12:05 PM
> To: edk2-devel@lists.01.org
> Subject: Repeated condition check
>
> Hi all,
>
> There is a redundant condition check in the API
> PxeBcIcmp6ErrorDpcHandle()
>
> VOID
> EFIAPI
> PxeBcIcmp6ErrorDpcHandle (
> IN VOID *Context
> )
> {
> ...
>
> if (Type != ICMP_V6_DEST_UNREACHABLE &&
> Type != ICMP_V6_PACKET_TOO_BIG &&
> -Type != ICMP_V6_PACKET_TOO_BIG &&
> +Type != ICMP_V6_TIME_EXCEEDED &&
> Type != ICMP_V6_PARAMETER_PROBLEM) {
> //
> // The type of the receveid packet should be an ICMP6 error message.
> //
> gBS->SignalEvent (RxData->RecycleSignal);
> goto ON_EXIT;
> }
> ...
> }
>
> Unfortunately, some error checking tools were not able to capture this.
> Please confirm and take the necessary action.
>
> Thank you
> Naveen
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Repeated condition check
2017-09-25 5:05 ` Santhapur Naveen
@ 2017-09-25 5:10 ` Wu, Jiaxin
2017-09-25 5:12 ` Santhapur Naveen
0 siblings, 1 reply; 6+ messages in thread
From: Wu, Jiaxin @ 2017-09-25 5:10 UTC (permalink / raw)
To: Santhapur Naveen, edk2-devel@lists.01.org; +Cc: Ye, Ting, Fu, Siyuan
Thanks Naveen, we appreciate your report:).
> -----Original Message-----
> From: Santhapur Naveen [mailto:naveens@amiindia.co.in]
> Sent: Monday, September 25, 2017 1:05 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: RE: Repeated condition check
>
> Hi Jiaxin,
>
> Duly noted.
> Will mention one of you in the TO/CC list from here onwards.
>
> Thank you
> Naveen
>
> -----Original Message-----
> From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
> Sent: Monday, September 25, 2017 10:33 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan
> Subject: RE: Repeated condition check
>
> Hi Naveen,
>
> We may ignore your email if you don't attach any specific receiver (TO OR CC
> list):(.
>
> For the issue, I agree the fix. So, can you help to report the issue on Bugzilla?
> We will create the formal patch to fix it.
>
> Thanks,
> Jiaxin
>
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Santhapur Naveen
> > Sent: Friday, September 22, 2017 4:40 PM
> > To: edk2-devel@lists.01.org
> > Subject: Re: [edk2] Repeated condition check
> >
> > Hello guys,
> >
> > Any update?
> >
> > Thank you
> > Naveen
> >
> > -----Original Message-----
> > From: Santhapur Naveen
> > Sent: Wednesday, September 20, 2017 12:05 PM
> > To: edk2-devel@lists.01.org
> > Subject: Repeated condition check
> >
> > Hi all,
> >
> > There is a redundant condition check in the API
> > PxeBcIcmp6ErrorDpcHandle()
> >
> > VOID
> > EFIAPI
> > PxeBcIcmp6ErrorDpcHandle (
> > IN VOID *Context
> > )
> > {
> > ...
> >
> > if (Type != ICMP_V6_DEST_UNREACHABLE &&
> > Type != ICMP_V6_PACKET_TOO_BIG &&
> > -Type != ICMP_V6_PACKET_TOO_BIG &&
> > +Type != ICMP_V6_TIME_EXCEEDED &&
> > Type != ICMP_V6_PARAMETER_PROBLEM) {
> > //
> > // The type of the receveid packet should be an ICMP6 error message.
> > //
> > gBS->SignalEvent (RxData->RecycleSignal);
> > goto ON_EXIT;
> > }
> > ...
> > }
> >
> > Unfortunately, some error checking tools were not able to capture this.
> > Please confirm and take the necessary action.
> >
> > Thank you
> > Naveen
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Repeated condition check
2017-09-25 5:10 ` Wu, Jiaxin
@ 2017-09-25 5:12 ` Santhapur Naveen
0 siblings, 0 replies; 6+ messages in thread
From: Santhapur Naveen @ 2017-09-25 5:12 UTC (permalink / raw)
To: Wu, Jiaxin, edk2-devel@lists.01.org; +Cc: Ye, Ting, Fu, Siyuan
Hi Jiaxin,
Created a bug in the Bugzilla site.
Here's the bug link https://bugzilla.tianocore.org/show_bug.cgi?id=718
Thank you
Naveen
-----Original Message-----
From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
Sent: Monday, September 25, 2017 10:40 AM
To: Santhapur Naveen; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan
Subject: RE: Repeated condition check
Thanks Naveen, we appreciate your report:).
> -----Original Message-----
> From: Santhapur Naveen [mailto:naveens@amiindia.co.in]
> Sent: Monday, September 25, 2017 1:05 PM
> To: Wu, Jiaxin <jiaxin.wu@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: RE: Repeated condition check
>
> Hi Jiaxin,
>
> Duly noted.
> Will mention one of you in the TO/CC list from here onwards.
>
> Thank you
> Naveen
>
> -----Original Message-----
> From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]
> Sent: Monday, September 25, 2017 10:33 AM
> To: Santhapur Naveen; edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan
> Subject: RE: Repeated condition check
>
> Hi Naveen,
>
> We may ignore your email if you don't attach any specific receiver
> (TO OR CC list):(.
>
> For the issue, I agree the fix. So, can you help to report the issue on Bugzilla?
> We will create the formal patch to fix it.
>
> Thanks,
> Jiaxin
>
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > Of Santhapur Naveen
> > Sent: Friday, September 22, 2017 4:40 PM
> > To: edk2-devel@lists.01.org
> > Subject: Re: [edk2] Repeated condition check
> >
> > Hello guys,
> >
> > Any update?
> >
> > Thank you
> > Naveen
> >
> > -----Original Message-----
> > From: Santhapur Naveen
> > Sent: Wednesday, September 20, 2017 12:05 PM
> > To: edk2-devel@lists.01.org
> > Subject: Repeated condition check
> >
> > Hi all,
> >
> > There is a redundant condition check in the API
> > PxeBcIcmp6ErrorDpcHandle()
> >
> > VOID
> > EFIAPI
> > PxeBcIcmp6ErrorDpcHandle (
> > IN VOID *Context
> > )
> > {
> > ...
> >
> > if (Type != ICMP_V6_DEST_UNREACHABLE &&
> > Type != ICMP_V6_PACKET_TOO_BIG &&
> > -Type != ICMP_V6_PACKET_TOO_BIG &&
> > +Type != ICMP_V6_TIME_EXCEEDED &&
> > Type != ICMP_V6_PARAMETER_PROBLEM) {
> > //
> > // The type of the receveid packet should be an ICMP6 error message.
> > //
> > gBS->SignalEvent (RxData->RecycleSignal);
> > goto ON_EXIT;
> > }
> > ...
> > }
> >
> > Unfortunately, some error checking tools were not able to capture this.
> > Please confirm and take the necessary action.
> >
> > Thank you
> > Naveen
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-25 5:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 6:35 Repeated condition check Santhapur Naveen
-- strict thread matches above, loose matches on Subject: below --
2017-09-22 8:40 Santhapur Naveen
2017-09-25 5:02 ` Wu, Jiaxin
2017-09-25 5:05 ` Santhapur Naveen
2017-09-25 5:10 ` Wu, Jiaxin
2017-09-25 5:12 ` Santhapur Naveen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox