From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <naveens@amiindia.co.in>
Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in
 [203.199.198.232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id C9FE421ECCB03
 for <edk2-devel@lists.01.org>; Tue, 19 Sep 2017 23:32:10 -0700 (PDT)
Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 9258A82047
 for <edk2-devel@lists.01.org>; Wed, 20 Sep 2017 12:07:56 +0530 (IST)
Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1])
 by IMSVA (Postfix) with ESMTP id 8681482046
 for <edk2-devel@lists.01.org>; Wed, 20 Sep 2017 12:07:56 +0530 (IST)
Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7])
 by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS
 for <edk2-devel@lists.01.org>; Wed, 20 Sep 2017 12:07:56 +0530 (IST)
Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by
 Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id
 14.03.0248.002; Wed, 20 Sep 2017 12:05:12 +0530
From: Santhapur Naveen <naveens@amiindia.co.in>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Thread-Topic: Repeated condition check
Thread-Index: AdMx2S+NdBBnOF5gSMOFWy5SEenozA==
Date: Wed, 20 Sep 2017 06:35:11 +0000
Message-ID: <625A2455CC232F40B0F38F05ACED6D97012CA98291@VENUS1.in.megatrends.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.0.84.77]
MIME-Version: 1.0
X-TM-AS-GCONF: 00
X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-23340.005
X-TM-AS-Result: No--8.971-5.0-31-10
X-imss-scan-details: No--8.971-5.0-31-10
X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-23340.005
X-TMASE-Result: 10--8.970800-10.000000
X-TMASE-MatchedRID: aTnHahpOdVR23uxauR3Kkrrbxxduc6FPTJDl9FKHbrmHwGEm+CpYGTfy
 D4B1B1Xw5NE8iKAUoozBWkpbxXCFKmMNX/9K+Qfe7nFyCFh/r3PA8jzXpPXv2psoi2XrUn/Jzht
 qOA7SSC8UGm4zriL0oQtuKBGekqUpI/NGWt0UYPAaS+IPQrplS1BjiK6KI+4yaVOtdG9SNS3K0y
 f0StG9AGyGp8lPx7Oz
X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0
Subject: Repeated condition check
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Sep 2017 06:32:11 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Hi all,

There is a redundant condition check in the API PxeBcIcmp6ErrorDpcHandle()

VOID
EFIAPI
PxeBcIcmp6ErrorDpcHandle (
  IN VOID                 *Context
  )
{
 ...

  if (Type !=3D ICMP_V6_DEST_UNREACHABLE &&
      Type !=3D ICMP_V6_PACKET_TOO_BIG &&
    -Type !=3D ICMP_V6_PACKET_TOO_BIG &&
    +Type !=3D ICMP_V6_TIME_EXCEEDED &&
      Type !=3D ICMP_V6_PARAMETER_PROBLEM) {
    //
    // The type of the receveid packet should be an ICMP6 error message.
    //
    gBS->SignalEvent (RxData->RecycleSignal);
    goto ON_EXIT;
  }
  ...
}

Unfortunately, some error checking tools were not able to capture this.
Please confirm and take the necessary action.

Thank you
Naveen