From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=203.199.198.232; helo=imsva.in.megatrends.com; envelope-from=naveens@amiindia.co.in; receiver=edk2-devel@lists.01.org Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B4C02095E505 for ; Sun, 24 Sep 2017 22:02:23 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3615882047; Mon, 25 Sep 2017 10:38:16 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 295F882046; Mon, 25 Sep 2017 10:38:16 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Mon, 25 Sep 2017 10:38:16 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Mon, 25 Sep 2017 10:35:30 +0530 From: Santhapur Naveen To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" Thread-Topic: Repeated condition check Thread-Index: AdMx2S+NdBBnOF5gSMOFWy5SEenozABpO22AAI8gkzAAAD14QA== Date: Mon, 25 Sep 2017 05:05:29 +0000 Message-ID: <625A2455CC232F40B0F38F05ACED6D97012CA9A348@VENUS1.in.megatrends.com> References: <625A2455CC232F40B0F38F05ACED6D97012CA99E6A@VENUS1.in.megatrends.com> <895558F6EA4E3B41AC93A00D163B7274163374E0@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <895558F6EA4E3B41AC93A00D163B7274163374E0@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.77] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-23350.004 X-TM-AS-Result: No--22.910-5.0-31-10 X-imss-scan-details: No--22.910-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-23350.004 X-TMASE-Result: 10--22.909700-10.000000 X-TMASE-MatchedRID: L8tZF6zWW2rxlOJuQNHlfRMMmcrjEONdUd7Bjfo+5jRm60OoujMOyIo5 BSI6pnHYsI1EA8gPt6ql4lMrRxkMnCA1dgOjatGGl1zsjZ1/6aw2O5Eh+45TR83J+h/wWLV9KPn doQHmoMusgKv7m4IPMIYUzH+jBgDtHVikQ9YmLLPY5KPiokD1BoB84MMvKleaHXD1Vcq2nK2pVK sOpbZ9p7o3taS5f7rWXTjdrCMapXUs4bLNAJQYqp1U1lojafr/dZPoD9V2prSbKItl61J/yc894 3oc3p3sfPD5cPWJ9NcLbigRnpKlKT4yqD4LKu3A X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 Subject: Re: Repeated condition check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 05:02:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Jiaxin, Duly noted. Will mention one of you in the TO/CC list from here onwards. Thank you Naveen -----Original Message----- From: Wu, Jiaxin [mailto:jiaxin.wu@intel.com]=20 Sent: Monday, September 25, 2017 10:33 AM To: Santhapur Naveen; edk2-devel@lists.01.org Cc: Ye, Ting; Fu, Siyuan Subject: RE: Repeated condition check Hi Naveen,=20 We may ignore your email if you don't attach any specific receiver (TO OR = CC list):(. For the issue, I agree the fix. So, can you help to report the issue on Bug= zilla? We will create the formal patch to fix it. Thanks, Jiaxin > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of=20 > Santhapur Naveen > Sent: Friday, September 22, 2017 4:40 PM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] Repeated condition check >=20 > Hello guys, >=20 > Any update? >=20 > Thank you > Naveen >=20 > -----Original Message----- > From: Santhapur Naveen > Sent: Wednesday, September 20, 2017 12:05 PM > To: edk2-devel@lists.01.org > Subject: Repeated condition check >=20 > Hi all, >=20 > There is a redundant condition check in the API=20 > PxeBcIcmp6ErrorDpcHandle() >=20 > VOID > EFIAPI > PxeBcIcmp6ErrorDpcHandle ( > IN VOID *Context > ) > { > ... >=20 > if (Type !=3D ICMP_V6_DEST_UNREACHABLE && > Type !=3D ICMP_V6_PACKET_TOO_BIG && > -Type !=3D ICMP_V6_PACKET_TOO_BIG && > +Type !=3D ICMP_V6_TIME_EXCEEDED && > Type !=3D ICMP_V6_PARAMETER_PROBLEM) { > // > // The type of the receveid packet should be an ICMP6 error message. > // > gBS->SignalEvent (RxData->RecycleSignal); > goto ON_EXIT; > } > ... > } >=20 > Unfortunately, some error checking tools were not able to capture this. > Please confirm and take the necessary action. >=20 > Thank you > Naveen > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel