From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from IMSVA.IN.MEGATRENDS.COM (venus.amiindia.co.in [111.93.197.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0118C1A1DF7 for ; Wed, 17 Aug 2016 20:15:11 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4568782047; Thu, 18 Aug 2016 08:45:11 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2A51B82046; Thu, 18 Aug 2016 08:45:10 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS; Thu, 18 Aug 2016 08:45:10 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Thu, 18 Aug 2016 08:45:07 +0530 From: Santhapur Naveen To: "Ye, Ting" , "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: Sivaraman Nainar , "Madhan B. Santharam" Thread-Topic: Classless IP support for IPv4 PXE boot Thread-Index: AdH4e2JhpVdKe1quTBqkAuTkO1R+hAAfzWUwAAAzKZAAADar8A== Date: Thu, 18 Aug 2016 03:15:06 +0000 Message-ID: <625A2455CC232F40B0F38F05ACED6D976C4DAC44@VENUS1.in.megatrends.com> References: <625A2455CC232F40B0F38F05ACED6D976C4DA5CE@VENUS1.in.megatrends.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.0.93.26] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1054-22520.004 X-TM-AS-Result: No--22.578-5.0-31-10 X-imss-scan-details: No--22.578-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1054-22520.004 X-TMASE-Result: 10--22.577700-10.000000 X-TMASE-MatchedRID: 0lhM5bBmjEMtn0ItQiUx0rxygpRxo469LdLfmiFS7fuabNoYojBQdn2M 3piX8C3OjhvtkHstsIAlZ6AN1IBlhcUC0EVMuztdY1bQMCMvmn4Ea8g1x8eqF+Q45nVtPqmxmIX 3Wgl6rhJbHAuWwt+omFxBgG7mg/Dl9R7dwXny/bdQiFNNqFvt1WW7wAkGQ80wEEa3bn/bcwgTTF MqURRB9PTMN6SRj6ZuspRUj8sIYn1g0s9CJc8XvPHkpkyUphL9s+A++/BnIBGlyfbzMrA/whEag Ylxo94P5RlEVaicFdvixmXu3vAjf8uzmsRz4cT/kE7MrqaPYs1Klo6qIxfTgM2mvbig5LjGyU7X gTs6W4LgajzmkafQxwHUfB9OM2DiVjB2sAdY1mWdVNZaI2n6/3WT6A/Vdqa0AvrloGmbcrvv/72 zC4hJFZ3woJ2UeuYF6HMoliKXreijlFSgXWPWuPU1Xpm2N12Sdi/yWILjNHv5N0o2THGRZBij9C Dqu1NFVjc7mmmeO8ZJDZJvlMhH0xLmWbmZAlNBNs3S39zaoXYytf6nW43O0BS11FlOYRohXalr5 okxvJqf189awv9YNKOzLgjJhC8IcBTC9SlEjKp6a7qHolmGuZkShYcLpGH9H06W6rwtvNWHLCgh e1X7/YOIxAfhXrwLoZPJhklVPxw4c5PfPWZTtg6w00GeWBFaJ8Bhckfr+jbTDHqKjGgNq63Jpg+ /4Stf4E9s12Gvf53BFtTPIWTepEY41YX/o/8KBEpgLvLaPxO1hCgXB2xDHyAHAopEd76vdMVCKH Bt8FB88XuuKFJiF33mvL9KTVy10AyR/Q7S6Pupxjqy29yNBw== X-TMASE-SNAP-Result: 1.811037.0001-0-1-12:0,22:0,28:1,33:0,34:0,35:0,39:0-0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: Classless IP support for IPv4 PXE boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2016 03:15:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please find the below details and snapshot. Revision: 21543 Author: Wu.Jiaxin Date: Thursday, June 18, 2015 6:13:15 AM Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA process depe= ndency. Modified: /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin Reviewed-by: Ye Ting Reviewed-by: Fu Siyuan Please check if the below snapshot may help. [cid:image001.jpg@01D1F92C.D1247640] Thanks, Naveen -----Original Message----- From: Ye, Ting [mailto:ting.ye@intel.com] Sent: Thursday, August 18, 2016 8:23 AM To: Fu, Siyuan; Santhapur Naveen; edk2-devel@lists.01.org Cc: Sivaraman Nainar; Madhan B. Santharam Subject: RE: Classless IP support for IPv4 PXE boot I searched the log messages: Revision: 21543 Author: edk2buildsystem Date: Friday, July 01, 2016 5:05:51 AM Message: MdeModulePkg VariableInfo: Fix GCC build failure GCC build failure: 'RealCommSize' may be used uninitialized Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng > Reviewed-by: Giri P Mudusuru > (cherry picked from commit 05b39efb669eaa173a76e58daf8e65bc= e2e0299e) ---- Modified : /trunk/edk2/MdeModulePkg/Application/VariableInfo/VariableInfo.c This looks irrelevant. Could you please confirm the revision? Thanks, Ting -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu, = Siyuan Sent: Thursday, August 18, 2016 10:48 AM To: Santhapur Naveen = >; edk2-devel@lists.01.org Cc: Sivaraman Nainar >; Madhan B. Santharam > Subject: Re: [edk2] Classless IP support for IPv4 PXE boot Hi, Naveen May I know the GIT version of the 21543, or the subject of the commit messa= ge? I can't see the svn revision number on my side. Thanks Siyuan > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Santhapur Naveen > Sent: Wednesday, August 17, 2016 7:41 PM > To: edk2-devel@lists.01.org > Cc: Sivaraman Nainar >; Madhan B. Santharam > > > Subject: [edk2] Classless IP support for IPv4 PXE boot > > Hello, > > We happened to observe that the IPv4 PXE boot was happening > successfully for both classless and classful IPs until the EDKII > revision 21542. It has been found that there are some changes made in > the revision > 21543 and the IPv4 PXE boot is failing for classless IP addresses. The > failure scenario was debugged and is explained here. Let's assume the > subnet range is 192.168.1.0/16. The DHCP server tries to allot an IP > (let's say 192.168.1.0) but based on the first byte of the IP address > to be assigned, the function NetGetIpClass() returns the IP class as > Class-C and its respective subnet mask as 255.255.255.0 that should be > for a classful IP address whereas 255.255.0.0 is the actual subnet in > this scenario. The changes present in function > Dhcp4InstanceConfigUdpIo() seems to be responsible for the failure. > > May we know the reason behind the changes present in the Dhcp4Impl.c > of the revision 21543? Is there any plan to bring the classless IP > support in NetworkPkg? > > > Thanks, > Naveen > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel