Re: 2nd HttpBoot fails even after upgrading to revision 24729

[Santhapur Naveen <naveens@amiindia.co.in>]

Hi Lubo,

	I believe the way we refer the version numbers seem different. I use tortoise SVN to get the details of the edk2. When I checked the revision numbers 22104 and 21740 for HttpBootDxe and HttpDxe drivers respectively, I couldn't find anything. Please refer the attachments. By any means is it possible for you to provide the way you refer the revision details?

	However, I've downloaded the latest source from the URL you have provided and I'm trying to verify the same now. Will update you my result.

Thank you,
Naveen

-----Original Message-----
From: Zhang, Lubo [mailto:lubo.zhang@intel.com] 
Sent: Thursday, August 25, 2016 7:19 AM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
       I update the  SVN and now the revision is 22467.
       The HttpBootDxe revision is 22104,patch is - Fix IPv6 HTTPClient vendor class data
       The HttpDxe revision is 21740, patch is - NetworkPkg: Fix typos in comments.
       But I suggest you to download  the https://github.com/tianocore/edk2, it is latest edk2 code.

Best Regards
Lubo

-----Original Message-----
From: Santhapur Naveen [mailto:naveens@amiindia.co.in] 
Sent: Wednesday, August 24, 2016 7:10 PM
To: Zhang, Lubo <lubo.zhang@intel.com>
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

	Can you please provide me any reference revision number to download and check the same?

Thank you,
Naveen

-----Original Message-----
From: Zhang, Lubo [mailto:lubo.zhang@intel.com] 
Sent: Wednesday, August 24, 2016 4:23 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
      I have checked the issue you mentioned. On my side, I updated the code to latest and do some test on NT32 and Denlow platform, both the first http boot and 2nd are successful. 
      Until now , we have fixed few bugs which may lead the 2nd http boot fail. As for the patch you mentioned is one case to fix the bug, So I suggest you to update the code firstly and at least make sure the HttpDxe , HttpBootDxe and DxeHttpLib are latest. 
   
     If any result, Pls let me know.

Best Regards
Lubo 
     

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Santhapur Naveen
Sent: Wednesday, August 24, 2016 4:53 PM
To: Zhang, Lubo <lubo.zhang@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Lubo,

	Please find the following details that may help.

NetworkPkg:Fix a bug the 2nd httpboot fail issue.

Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg pointer should point a correct location.Now after the first  successful httpboot for ipv4 or ipv6,the HttpInstance->NextMsgpoint the character after the last byte, it may be a bad buffer if we don't receive another HttpHeader, so if call a 2nd httpboot, the wrong NextMsg pointer will cause the httpboot fail, so we need to check this case in HttpBodyParserCallback function in the first http boot process.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Zhang Lubo <lubo.zhang@intel.com>
Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
Reviewed-by: Ye Ting <ting.ye@intel.com>
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>

git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@19423 6f19259b-4bc3-4df7-8a09-765794883524


Thanks,
Naveen

-----Original Message-----
From: Zhang, Lubo [mailto:lubo.zhang@intel.com] 
Sent: Wednesday, August 24, 2016 2:13 PM
To: Santhapur Naveen
Cc: edk2-devel@lists.01.org
Subject: RE: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hi Naveen
     Could you list the patch name or Git SHA value which fixed the 2nd HttpBootfail issue. On my side, the SVN version 24729 is not exist.

Thanks 
Lubo 

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Santhapur Naveen
Sent: Wednesday, August 24, 2016 3:40 PM
To: edk2-devel@lists.01.org
Subject: Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

Hello,

          Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the revsision 24729 and still the 2nd  HttpBoot fails. Please let me know if I have missed any.

P.S: The first http boot happens successfully though. (downloading a Shell.efi)

Thanks,
Naveen
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel