public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Santhapur Naveen <naveens@amiindia.co.in>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Unnecessary parameter validation in ISCSI or Full parameter check would be better !!
Date: Mon, 3 Apr 2017 09:28:15 +0000	[thread overview]
Message-ID: <625A2455CC232F40B0F38F05ACED6D97B69B74EE@VENUS1.in.megatrends.com> (raw)

Hi,

          In iSCSI, there's a comment which says "Only do full parameter validation if iSCSI is enabled on this device." In such case, why iSCSI validates only a few of the parameters like Target Name, CHAP Secret and Reverse CHAP Secret.

          I believe the validation is unnecessary as the Attempt will not be considered for connection. Or Since we anyway save it to NVRAM, is it better to validate all the attempt details even though the mode is disabled?

Regards,
Naveen


                 reply	other threads:[~2017-04-03  9:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=625A2455CC232F40B0F38F05ACED6D97B69B74EE@VENUS1.in.megatrends.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox