From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from IMSVA.IN.MEGATRENDS.COM (Webmail.amiindia.co.in [203.199.198.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56644219392E3 for ; Mon, 3 Apr 2017 02:28:04 -0700 (PDT) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4936882066 for ; Mon, 3 Apr 2017 14:59:37 +0530 (IST) Received: from IMSVA.IN.MEGATRENDS.COM (IMSVA.IN.MEGATRENDS.COM [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3CDE58205B for ; Mon, 3 Apr 2017 14:59:37 +0530 (IST) Received: from webmail.amiindia.co.in (venus2.in.megatrends.com [10.0.0.7]) by IMSVA.IN.MEGATRENDS.COM (Postfix) with ESMTPS for ; Mon, 3 Apr 2017 14:59:37 +0530 (IST) Received: from VENUS1.in.megatrends.com ([fe80::951:7975:6ecf:eae5]) by Venus2.in.megatrends.com ([fe80::2002:4a07:4f17:c09b%14]) with mapi id 14.03.0248.002; Mon, 3 Apr 2017 14:59:37 +0530 From: Santhapur Naveen To: "edk2-devel@lists.01.org" Thread-Topic: Unnecessary parameter validation in ISCSI or Full parameter check would be better !! Thread-Index: AdKsXKdBSEKQsygLTuukntSlBoegPQ== Date: Mon, 3 Apr 2017 09:28:15 +0000 Message-ID: <625A2455CC232F40B0F38F05ACED6D97B69B74EE@VENUS1.in.megatrends.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.0.84.77] MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSVA-9.1.0.1600-8.1.0.1062-22982.006 X-TM-AS-Result: No--13.526-5.0-31-10 X-imss-scan-details: No--13.526-5.0-31-10 X-TMASE-Version: IMSVA-9.1.0.1600-8.1.1062-22982.006 X-TMASE-Result: 10--13.525500-10.000000 X-TMASE-MatchedRID: hDt2nT7GHlOTu4o902k1Swz4VsCc1YW+Ct59Uh3p/NVtw+n+iKWyyAbV vwYV4imfqPJG3FQpEA/z6VsuwXeYyD+y45h2fMFq7spMO3HwKCBvAd/85EsfAXQ8D+SLaQjsHEk RfST+Ts4uI29Z9XjQN+eJm6LClLmHwisXXd5ilGuKC6Im4I1RF/hs+N+bSEhB4pinC0b7AdXwWE aNOnlY9/L8w9/9GZdKhW2BDI+9Fsw0nIDKoCZxv3uTVkeYosXtuacNrbMY+LS17wx8kgvnlE8RO UaX64h0kIR5jQkue1Tl22c7vF4Nm32wZ99SrtsMy7TSWcbz49YxmlBLt0TR1oJy/meScoY1hQH+ YspUfFp2+AZuxakJy1x59CtgmyHsWcbhowRxPdMOsNNBnlgRWn0tCKdnhB58r10pknZXGJp/KME kOe61SCq2rl3dzGQ1xviq56ZjooBi4BkzOKSL/pomFtqZ81wsVT9h71493ntZ90wGJaHS0ue70Y nm9WkXMD3fHue8K0JKmyvrp/G111MnEE45ETdP/hqLcjh7MDd+3BndfXUhXQ== X-TMASE-SNAP-Result: 1.821001.0001-0-1-12:0,22:0,33:0,34:0,39:0-0 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 Subject: Unnecessary parameter validation in ISCSI or Full parameter check would be better !! X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2017 09:28:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, In iSCSI, there's a comment which says "Only do full parameter va= lidation if iSCSI is enabled on this device." In such case, why iSCSI valid= ates only a few of the parameters like Target Name, CHAP Secret and Reverse= CHAP Secret. I believe the validation is unnecessary as the Attempt will not b= e considered for connection. Or Since we anyway save it to NVRAM, is it bet= ter to validate all the attempt details even though the mode is disabled? Regards, Naveen