From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web10.29519.1669853124984323362
 for <devel@edk2.groups.io>;
 Wed, 30 Nov 2022 16:05:25 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=Ct1T2f5k;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.8.94])
	by linux.microsoft.com (Postfix) with ESMTPSA id 6BB3120B83C2;
	Wed, 30 Nov 2022 16:05:22 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6BB3120B83C2
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1669853124;
	bh=sIKbbf6I6IZV8SGFrmFv4vDqU3hYQeoC6uq8wY+BWeQ=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=Ct1T2f5k1Mdynm7OfJITf3wf2z560XYFuEKEP07ypZdRMM0zBbSJucHx45g4lljHi
	 SFPqqi915VPif15qibo/Q4s88/FsKlYSl83JQGxBKRF+6TSgzZpOvCMwH90JWNt9kG
	 0n3VNseV7AYtH2AB5UBvLJZDQSlKA86exjnMz/JE=
Message-ID: <62a1c905-2269-5ed2-e6e5-dbeecb7882e6@linux.microsoft.com>
Date: Wed, 30 Nov 2022 19:05:21 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [edk2-devel] [PATCH v9 04/12] CI: add ~/.local/bin to PATH (Linux only)
To: devel@edk2.groups.io, osteffen@redhat.com
Cc: Andrew Fish <afish@apple.com>, Ard Biesheuvel
 <ardb+tianocore@kernel.org>, Bob Feng <bob.c.feng@intel.com>,
 Daniel Schaefer <git@danielschaefer.me>, Gerd Hoffmann <kraxel@redhat.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Leif Lindholm <quic_llindhol@quicinc.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Michael D Kinney <michael.d.kinney@intel.com>, Ray Ni <ray.ni@intel.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Sean Brogan
 <sean.brogan@microsoft.com>, Sunil V L <sunilvl@ventanamicro.com>,
 Yuwei Chen <yuwei.chen@intel.com>, Zhiguang Liu <zhiguang.liu@intel.com>,
 Pawel Polawski <ppolawsk@redhat.com>, Chris Fernald <chfernal@microsoft.com>
References: <20221130220125.1112760-1-osteffen@redhat.com>
 <CA+bRGFqoVCimF44OyArRt8imxzuZy74QAei+Oc4=0_x+=2Uppw@mail.gmail.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <CA+bRGFqoVCimF44OyArRt8imxzuZy74QAei+Oc4=0_x+=2Uppw@mail.gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Oliver,

I think the commit message is too vague. Can you please add a bit more 
context?

With that:

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 11/30/2022 5:01 PM, Oliver Steffen wrote:
> Fix pip install under certain conditions.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>   .azurepipelines/templates/platform-build-run-steps.yml | 6 ++++++
>   .azurepipelines/templates/pr-gate-steps.yml            | 6 ++++++
>   2 files changed, 12 insertions(+)
> 
> diff --git a/.azurepipelines/templates/platform-build-run-steps.yml
> b/.azurepipelines/templates/platform-build-run-steps.yml
> index 8803d80cf51c..087f460d7fec 100644
> --- a/.azurepipelines/templates/platform-build-run-steps.yml
> +++ b/.azurepipelines/templates/platform-build-run-steps.yml
> @@ -39,6 +39,12 @@ parameters:
>     default: ''
> 
>   steps:
> +- bash: |
> +    echo "##vso[task.prependpath]${HOME}/.local/bin"
> +    echo "new PATH=${PATH}"
> +  displayName: Set PATH
> +  condition: eq('${{ parameters.tool_chain_tag }}', 'GCC5')
> +
>   - checkout: self
>     clean: true
>     fetchDepth: 1
> diff --git a/.azurepipelines/templates/pr-gate-steps.yml
> b/.azurepipelines/templates/pr-gate-steps.yml
> index 27a44c06011c..99d52cfa0605 100644
> --- a/.azurepipelines/templates/pr-gate-steps.yml
> +++ b/.azurepipelines/templates/pr-gate-steps.yml
> @@ -15,6 +15,12 @@ parameters:
>     usePythonVersion: ''
> 
>   steps:
> +- bash: |
> +    echo "##vso[task.prependpath]${HOME}/.local/bin"
> +    echo "new PATH=${PATH}"
> +  displayName: Set PATH
> +  condition: eq('${{ parameters.tool_chain_tag }}', 'GCC5')
> +
>   - checkout: self
>     clean: true
>     fetchDepth: 1