Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

[Kun Qin]

Hi DynamicTablePkg maintainers,

Do you have any further feedback on this patch series? Any input is 
appreciated.

Thanks,
Kun

On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>
> This patch series is a follow-up of previous submission:
> https://edk2.groups.io/g/devel/message/91926
>
> The main changes between v2 and v3 patches are:
>    - Added reviewed-by collected from previous iteration
>    - Added descriptions for newly introduced structures
>    - Updated functions names
>
> Current DynamicTablesPkg provide great support for creating dynamic ACPI
> tables during boot time.
>
> However, there are some modules needs minor tweaks to expand support and
> compatibility for OS requirements and platform needs.
>
> This patch series proposes a few fixes to resolve minor issues discovered
> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>
> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Cc: Pierre Gondois <pierre.gondois@arm.com>
>
> Kun Qin (6):
>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to inf
>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>      tables
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>      space
>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>      config
>
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c   | 214 ++++++++++++--------
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c   | 176 ++++++++++++++++
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c    |  80 +++++++-
>   DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf |   4 +
>   DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf  |   1 +
>   5 files changed, 391 insertions(+), 84 deletions(-)
>

Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

[Kun Qin]

Hi DynamicTablePkg maintainers,

Just a gentle ping on this patch series. If there is no further 
feedback, can we merge
them into the mainline? Otherwise, any feedback is appreciated.

Regards,
Kun

On 8/3/2022 9:57 AM, Kun Qin wrote:
> Hi DynamicTablePkg maintainers,
>
> Do you have any further feedback on this patch series? Any input is 
> appreciated.
>
> Thanks,
> Kun
>
> On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>>
>> This patch series is a follow-up of previous submission:
>> https://edk2.groups.io/g/devel/message/91926
>>
>> The main changes between v2 and v3 patches are:
>>    - Added reviewed-by collected from previous iteration
>>    - Added descriptions for newly introduced structures
>>    - Updated functions names
>>
>> Current DynamicTablesPkg provide great support for creating dynamic ACPI
>> tables during boot time.
>>
>> However, there are some modules needs minor tweaks to expand support and
>> compatibility for OS requirements and platform needs.
>>
>> This patch series proposes a few fixes to resolve minor issues 
>> discovered
>> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>>
>> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3
>>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>> Cc: Pierre Gondois <pierre.gondois@arm.com>
>>
>> Kun Qin (6):
>>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to 
>> inf
>>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>>      tables
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>>      space
>>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>>      config
>>
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c 
>> | 214 ++++++++++++--------
>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c 
>> | 176 ++++++++++++++++
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c 
>> |  80 +++++++-
>> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf 
>> |   4 +
>> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf 
>> |   1 +
>>   5 files changed, 391 insertions(+), 84 deletions(-)
>>

Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

[Sami Mujawar]

Hi Kun,

I have just replied to your patch series. I think patches 4 & 5 may need some adjustment.

Can you look into those, please?

Regards,

Sami Mujawar

On 08/08/2022, 16:34, "Kun Qin" <kuqin12@gmail.com> wrote:

    Hi DynamicTablePkg maintainers,

    Just a gentle ping on this patch series. If there is no further
    feedback, can we merge
    them into the mainline? Otherwise, any feedback is appreciated.

    Regards,
    Kun

    On 8/3/2022 9:57 AM, Kun Qin wrote:
    > Hi DynamicTablePkg maintainers,
    >
    > Do you have any further feedback on this patch series? Any input is
    > appreciated.
    >
    > Thanks,
    > Kun
    >
    > On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote:
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
    >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
    >>
    >> This patch series is a follow-up of previous submission:
    >> https://edk2.groups.io/g/devel/message/91926
    >>
    >> The main changes between v2 and v3 patches are:
    >>    - Added reviewed-by collected from previous iteration
    >>    - Added descriptions for newly introduced structures
    >>    - Updated functions names
    >>
    >> Current DynamicTablesPkg provide great support for creating dynamic ACPI
    >> tables during boot time.
    >>
    >> However, there are some modules needs minor tweaks to expand support and
    >> compatibility for OS requirements and platform needs.
    >>
    >> This patch series proposes a few fixes to resolve minor issues
    >> discovered
    >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
    >>
    >> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3
    >>
    >> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
    >> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
    >> Cc: Pierre Gondois <pierre.gondois@arm.com>
    >>
    >> Kun Qin (6):
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to
    >> inf
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
    >>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
    >>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
    >>      tables
    >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
    >>      space
    >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
    >>      config
    >>
    >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c
    >> | 214 ++++++++++++--------
    >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
    >> | 176 ++++++++++++++++
    >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
    >> |  80 +++++++-
    >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
    >> |   4 +
    >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf
    >> |   1 +
    >>   5 files changed, 391 insertions(+), 84 deletions(-)
    >>

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

[Kun Qin]

Hi Sami,

Thanks for the deep dive on those patches. I will work on the patches 
and reply on those threads.

Regards,
Kun

On 8/8/2022 8:44 AM, Sami Mujawar wrote:
> Hi Kun,
>
> I have just replied to your patch series. I think patches 4 & 5 may need some adjustment.
>
> Can you look into those, please?
>
> Regards,
>
> Sami Mujawar
>
> On 08/08/2022, 16:34, "Kun Qin" <kuqin12@gmail.com> wrote:
>
>      Hi DynamicTablePkg maintainers,
>
>      Just a gentle ping on this patch series. If there is no further
>      feedback, can we merge
>      them into the mainline? Otherwise, any feedback is appreciated.
>
>      Regards,
>      Kun
>
>      On 8/3/2022 9:57 AM, Kun Qin wrote:
>      > Hi DynamicTablePkg maintainers,
>      >
>      > Do you have any further feedback on this patch series? Any input is
>      > appreciated.
>      >
>      > Thanks,
>      > Kun
>      >
>      > On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote:
>      >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996
>      >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997
>      >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3998
>      >>
>      >> This patch series is a follow-up of previous submission:
>      >> https://edk2.groups.io/g/devel/message/91926
>      >>
>      >> The main changes between v2 and v3 patches are:
>      >>    - Added reviewed-by collected from previous iteration
>      >>    - Added descriptions for newly introduced structures
>      >>    - Updated functions names
>      >>
>      >> Current DynamicTablesPkg provide great support for creating dynamic ACPI
>      >> tables during boot time.
>      >>
>      >> However, there are some modules needs minor tweaks to expand support and
>      >> compatibility for OS requirements and platform needs.
>      >>
>      >> This patch series proposes a few fixes to resolve minor issues
>      >> discovered
>      >> in DynamicPlatRepoLib, AcpiSsdtPcieLibArm and DynamicTableManagerDxe.
>      >>
>      >> Patch v3 branch: https://github.com/kuqin12/edk2/tree/dynamic_update_v3
>      >>
>      >> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>      >> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>      >> Cc: Pierre Gondois <pierre.gondois@arm.com>
>      >>
>      >> Kun Qin (6):
>      >>    DynamicTablesPkg: DynamicPlatRepoLib: Added MemoryAllocationLib to
>      >> inf
>      >>    DynamicTablesPkg: DynamicPlatRepoLib: Fix incorrect dereferencing
>      >>    DynamicTablesPkg: DynamicPlatRepoLib: Adding more token fixers
>      >>    DynamicTablesPkg: DynamicTableManagerDxe: Added check for installed
>      >>      tables
>      >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added function to reserve ECAM
>      >>      space
>      >>    DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI
>      >>      config
>      >>
>      >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c
>      >> | 214 ++++++++++++--------
>      >> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator.c
>      >> | 176 ++++++++++++++++
>      >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/CmObjectTokenFixer.c
>      >> |  80 +++++++-
>      >> DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf
>      >> |   4 +
>      >> DynamicTablesPkg/Library/Common/DynamicPlatRepoLib/DynamicPlatRepoLib.inf
>      >> |   1 +
>      >>   5 files changed, 391 insertions(+), 84 deletions(-)
>      >>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.