From: "Rebecca Cran" <rebecca@bsdio.com>
To: Ard Biesheuvel <ardb@kernel.org>,
devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Andrew Fish <afish@apple.com>, Leif Lindholm <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details
Date: Fri, 8 Sep 2023 10:31:22 -0600 [thread overview]
Message-ID: <62d7dc6e-6a1e-2522-ba5b-a2c5397853e4@bsdio.com> (raw)
In-Reply-To: <CAMj1kXGm_8TfFgRKWyHdg1uzM7PgeG+iTVUJ7KT+2-e=-0qmJg@mail.gmail.com>
On 9/8/23 10:21, Ard Biesheuvel wrote:
> On Fri, 8 Sept 2023 at 17:54, Michael D Kinney
> <michael.d.kinney@intel.com> wrote:
>> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
>>
> Thanks
>
> I can merge this but note that we'll need to convert it to CR-LF
> first. (My VIM editor with editorconfig integration seems perfectly
> happy with that)
Good point - I'll fix the line endings and merge it.
Thinking of line endings, I was wondering if we might want to make the following additions to BaseTools/Conf/gitattributes, along with setting "core.autocrlf=false" and "core.eol=crlf"?
* text=auto
*.png -text
*.pyd -text
*.sh eol=lf
.gitmodules eol=lf
BaseTools/BinWrappers/PosixLike/* eol=lf
BaseTools/BinPipWrappers/PosixLike/* eol=lf
BaseTools/BuildEnv eol=lf
BaseTools/Conf/diff.order eol=lf
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108454): https://edk2.groups.io/g/devel/message/108454
Mute This Topic: https://groups.io/mt/97321658/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-08 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:19 [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details Rebecca Cran
2023-03-01 22:11 ` Ard Biesheuvel
2023-09-08 15:14 ` [edk2-devel] " Ard Biesheuvel
2023-09-08 15:54 ` Michael D Kinney
2023-09-08 16:21 ` Ard Biesheuvel
2023-09-08 16:31 ` Rebecca Cran [this message]
2023-09-08 16:31 ` Michael D Kinney
2023-09-08 17:07 ` Rebecca Cran
2023-09-08 19:19 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62d7dc6e-6a1e-2522-ba5b-a2c5397853e4@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox