From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9D209740049 for ; Fri, 8 Sep 2023 16:31:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xMAJyxgwAEHjl5sEWfhjD/TC+IU1hdMo5CD3nyosLeI=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694190696; v=1; b=p9IY0OkNo0qrH2Z81qzVbu1j82z3qeFEA+4iyMCW36ktSLwhMsaOY/LdLGx5oqDUsLxzq/uV gq02SzXXyxEPBV+1nLG2/MmA4Pk4rLVo93Rh0Hp8XqhFvWhilPB5ZcfSBDwE1pldbXnzIHALuZU NlawpF+zc3HY61qOwwis0W4w= X-Received: by 127.0.0.2 with SMTP id RsRiYY7687511xCNLPa0DuNw; Fri, 08 Sep 2023 09:31:36 -0700 X-Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web10.1326.1694190695349807561 for ; Fri, 08 Sep 2023 09:31:35 -0700 X-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9F0E75C012A; Fri, 8 Sep 2023 12:31:34 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 08 Sep 2023 12:31:34 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudehjedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepgeefgeevudehjefgudfffefhheelheeigffhtedvjedvlefhueekhffh vdegheevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Sep 2023 12:31:33 -0400 (EDT) Message-ID: <62d7dc6e-6a1e-2522-ba5b-a2c5397853e4@bsdio.com> Date: Fri, 8 Sep 2023 10:31:22 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [edk2-devel] [PATCH v2 1/1] Add a .editorconfig file to tell editors basic formatting details To: Ard Biesheuvel , devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Andrew Fish , Leif Lindholm References: <20230301181950.46543-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Lap2YKj0x9JifaNO78J9kVJ4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=p9IY0OkN; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 9/8/23 10:21, Ard Biesheuvel wrote: > On Fri, 8 Sept 2023 at 17:54, Michael D Kinney > wrote: >> Acked-by: Michael D Kinney >> > Thanks > > I can merge this but note that we'll need to convert it to CR-LF > first. (My VIM editor with editorconfig integration seems perfectly > happy with that) Good point - I'll fix the line endings and merge it. Thinking of line endings, I was wondering if we might want to make the following additions to BaseTools/Conf/gitattributes, along with setting "core.autocrlf=false" and "core.eol=crlf"? * text=auto *.png -text *.pyd -text *.sh                                 eol=lf .gitmodules                          eol=lf BaseTools/BinWrappers/PosixLike/*    eol=lf BaseTools/BinPipWrappers/PosixLike/* eol=lf BaseTools/BuildEnv                   eol=lf BaseTools/Conf/diff.order            eol=lf -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108454): https://edk2.groups.io/g/devel/message/108454 Mute This Topic: https://groups.io/mt/97321658/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-