From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A75F721B02822 for ; Wed, 15 Aug 2018 06:14:59 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E904877154; Wed, 15 Aug 2018 13:14:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-100.rdu2.redhat.com [10.10.120.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21C372156712; Wed, 15 Aug 2018 13:14:58 +0000 (UTC) To: Eric Dong , edk2-devel@lists.01.org Cc: Marvin H user , Fan Jeff , Ruiyu Ni References: <20180815021435.13748-1-eric.dong@intel.com> From: Laszlo Ersek Message-ID: <62e220a5-7521-0992-86f7-7fe35cc55aa1@redhat.com> Date: Wed, 15 Aug 2018 15:14:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180815021435.13748-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 15 Aug 2018 13:14:59 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 15 Aug 2018 13:14:59 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [Patch v4 0/5] Change CpuS3Data memory type and address limitation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 13:14:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/15/18 04:14, Eric Dong wrote: > Because CpuS3Data memory will be copy to smram at SmmReadToLock point by PiSmmCpuDxeSmm driver, the memory type no need to be ACPI NVS type, also the address not limit to below 4G. > > This change remove the limit of ACPI NVS memory type and below 4G. > > Cc: Marvin H user > Cc: Fan Jeff > Cc: Laszlo Ersek > Cc: Ruiyu Ni > > Eric Dong (5): > UefiCpuPkg/PiSmmCpuDxeSmm: Use GDT/IDT saved in Smram. > UefiCpuPkg/AcpiCpuData.h: Remove AcpiNVS and Below 4G limitation. > UefiCpuPkg/CpuS3DataDxe: Change Memory Type and address limitation. > UefiCpuPkg/CpuS3DataDxe: Remove below 4G limitation. > UefiCpuPkg/RegisterCpuFeaturesLib: Combine implementation. > > UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c | 51 +++++--- > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf | 1 + > UefiCpuPkg/Include/AcpiCpuData.h | 34 ++---- > .../DxeRegisterCpuFeaturesLib.c | 67 ----------- > .../PeiRegisterCpuFeaturesLib.c | 131 --------------------- > .../RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 20 ---- > .../RegisterCpuFeaturesLib.c | 92 +++++++++++++++ > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 31 +++-- > 8 files changed, 155 insertions(+), 272 deletions(-) > Looks like this series is now fully reviewed. I will now do some regression-testing. Thanks! Laszlo