* [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400
@ 2020-02-07 21:32 Jeff Brasen
2020-02-08 11:56 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Brasen @ 2020-02-07 21:32 UTC (permalink / raw)
To: devel; +Cc: leif, ard.biesheuvel, Jeff Brasen
Increase length of path that can be read from system from 200 to 400 to
allow for longer build paths.
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
index 9c06835776..c6d1ca830a 100644
--- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
+++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
@@ -81,7 +81,7 @@ class EfiSectionTE:
filename = self.base_te + debug_rva + 0xc
else:
filename = self.base_te + debug_rva + 0x10
- filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
+ filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
return filename[0:string.find(filename,'\0')]
def get_debug_elfbase(self):
@@ -119,7 +119,7 @@ class EfiSectionPE32:
filename = self.base_pe32 + debug_rva + 0xc
else:
filename = self.base_pe32 + debug_rva + 0x10
- filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
+ filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
return filename[0:string.find(filename,'\0')]
def get_debug_elfbase(self):
@@ -154,7 +154,7 @@ class EfiSectionPE64:
filename = self.base_pe64 + debug_rva + 0xc
else:
filename = self.base_pe64 + debug_rva + 0x10
- filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
+ filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
return filename[0:string.find(filename,'\0')]
def get_debug_elfbase(self):
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400
2020-02-07 21:32 [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400 Jeff Brasen
@ 2020-02-08 11:56 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-02-08 11:56 UTC (permalink / raw)
To: Jeff Brasen; +Cc: edk2-devel-groups-io, Leif Lindholm
On Fri, 7 Feb 2020 at 21:32, Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> Increase length of path that can be read from system from 200 to 400 to
> allow for longer build paths.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
Thanks Jeff
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed to EDK2 master
> ---
> ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> index 9c06835776..c6d1ca830a 100644
> --- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> +++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> @@ -81,7 +81,7 @@ class EfiSectionTE:
> filename = self.base_te + debug_rva + 0xc
> else:
> filename = self.base_te + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> @@ -119,7 +119,7 @@ class EfiSectionPE32:
> filename = self.base_pe32 + debug_rva + 0xc
> else:
> filename = self.base_pe32 + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> @@ -154,7 +154,7 @@ class EfiSectionPE64:
> filename = self.base_pe64 + debug_rva + 0xc
> else:
> filename = self.base_pe64 + debug_rva + 0x10
> - filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> + filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
> return filename[0:string.find(filename,'\0')]
>
> def get_debug_elfbase(self):
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-08 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-07 21:32 [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400 Jeff Brasen
2020-02-08 11:56 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox