From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BB87A78003C for ; Wed, 28 Feb 2024 03:56:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1gMwvxkdbz4lmhezptzRRg6y5hFO4U8BLi/BS2HGgPY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1709092591; v=1; b=UtpEiSO0KVh/L0kqMDFziVAGXgtJYwdSVFJaNJ8EIm+LYIxuG4Tph9/juxkGrvQkfEZkzI2+ PEkFs0CXYzhMzZdRUu1p9YcoFzkKYwYXwpaZzkYZlZZKKzBPPFalzfey7NIIZjNNiEBc0lO0MHK J2cvh6ZqOrdcCaOoAHJvAwdU= X-Received: by 127.0.0.2 with SMTP id 7sZkYY7687511xjZtqFa8Nxy; Tue, 27 Feb 2024 19:56:31 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.5767.1709092590712121402 for ; Tue, 27 Feb 2024 19:56:30 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-156-7iFulvnQPmurVZFXYFS-3A-1; Tue, 27 Feb 2024 22:56:28 -0500 X-MC-Unique: 7iFulvnQPmurVZFXYFS-3A-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AF80F29AB406; Wed, 28 Feb 2024 03:56:27 +0000 (UTC) X-Received: from [10.39.192.46] (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4B8C2022AAA; Wed, 28 Feb 2024 03:56:25 +0000 (UTC) Message-ID: <62ebc31d-6490-13f3-2c10-0c16273bb58b@redhat.com> Date: Wed, 28 Feb 2024 04:56:25 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: add struct MP_HAND_OFF_CONFIG To: Gerd Hoffmann , devel@edk2.groups.io Cc: Oliver Steffen , Ray Ni , Rahul Kumar References: <20240227114122.1140614-1-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240227114122.1140614-1-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vxgoUvOaVZzHMkf4odgGw5QRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UtpEiSO0; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/27/24 12:41, Gerd Hoffmann wrote: > Move the WaitLoopExecutionMode and StartupSignalValue fields to a > separate HOB with the new struct. >=20 > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 13 ++++++-- > UefiCpuPkg/Library/MpInitLib/MpLib.h | 3 +- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 38 ++++++++++++++++++++---- > UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 34 +++++++++++++-------- > 4 files changed, 66 insertions(+), 22 deletions(-) Ah, please also append a few sentences to the commit message -- we should explain *why* this change is good: WaitLoopExecutionMode and StartupSignalValue are independent of processor index ranges; they are global to MpInitLib (i.e., the entire system). Therefore they shouldn't be repeated in every MpHandOff GUID HOB. Thanks! Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116079): https://edk2.groups.io/g/devel/message/116079 Mute This Topic: https://groups.io/mt/104600810/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-