From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"afish@apple.com" <afish@apple.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [PATCH v3 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort
Date: Fri, 23 Feb 2018 09:55:40 +0100 [thread overview]
Message-ID: <63051566-5ab4-b58a-9393-5b59b3a88304@redhat.com> (raw)
In-Reply-To: <CAKv+Gu-oFSm7kzXcAyAa9o8BP_=QHo_SvrfwcQDbEZt0QfOYsw@mail.gmail.com>
On 02/22/18 20:57, Ard Biesheuvel wrote:
> On 22 February 2018 at 19:40, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
>>
>> Ard,
>>
>> In DebugAssert(), if you have deadloop or BP enabled for
>> the ASSERT(), then it would be good to have the message
>> available in the local variable Buffer.
>>
>> Perhaps only the call to SerialPortWrite() should be
>> filtered.
>>
>
> Good point!
I agree!
Laszlo
next prev parent reply other threads:[~2018-02-23 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 18:15 [PATCH v3 0/2] Create UART DebugLib implementation for runtime drivers Ard Biesheuvel
2018-02-22 18:15 ` [PATCH v3 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort Ard Biesheuvel
2018-02-22 18:32 ` Laszlo Ersek
2018-02-22 19:40 ` Kinney, Michael D
2018-02-22 19:57 ` Ard Biesheuvel
2018-02-23 8:55 ` Laszlo Ersek [this message]
2018-02-22 18:15 ` [PATCH v3 2/2] ArmVirtPkg: switch to DXE runtime version of DebugLib where appropriate Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63051566-5ab4-b58a-9393-5b59b3a88304@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox