From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 4FD462243694C
 for <edk2-devel@lists.01.org>; Fri, 23 Feb 2018 00:49:41 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 6BCFF40753A2;
 Fri, 23 Feb 2018 08:55:42 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-112.rdu2.redhat.com
 [10.10.120.112])
 by smtp.corp.redhat.com (Postfix) with ESMTP id EF325B3007;
 Fri, 23 Feb 2018 08:55:40 +0000 (UTC)
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
 "Gao, Liming" <liming.gao@intel.com>, "afish@apple.com" <afish@apple.com>,
 "Zeng, Star" <star.zeng@intel.com>, "Ni, Ruiyu" <ruiyu.ni@intel.com>
References: <20180222181505.28192-1-ard.biesheuvel@linaro.org>
 <20180222181505.28192-2-ard.biesheuvel@linaro.org>
 <E92EE9817A31E24EB0585FDF735412F5B896ADC8@ORSMSX113.amr.corp.intel.com>
 <CAKv+Gu-oFSm7kzXcAyAa9o8BP_=QHo_SvrfwcQDbEZt0QfOYsw@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <63051566-5ab4-b58a-9393-5b59b3a88304@redhat.com>
Date: Fri, 23 Feb 2018 09:55:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAKv+Gu-oFSm7kzXcAyAa9o8BP_=QHo_SvrfwcQDbEZt0QfOYsw@mail.gmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Fri, 23 Feb 2018 08:55:42 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Fri, 23 Feb 2018 08:55:42 +0000 (UTC) for IP:'10.11.54.5'
 DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [PATCH v3 1/2] MdePkg: introduce DxeRuntimeDebugLibSerialPort
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2018 08:49:42 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/22/18 20:57, Ard Biesheuvel wrote:
> On 22 February 2018 at 19:40, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
>>
>> Ard,
>>
>> In DebugAssert(), if you have deadloop or BP enabled for
>> the ASSERT(), then it would be good to have the message
>> available in the local variable Buffer.
>>
>> Perhaps only the call to SerialPortWrite() should be
>> filtered.
>>
> 
> Good point!

I agree!

Laszlo