From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.31.1571663828756309812 for ; Mon, 21 Oct 2019 06:17:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=V9YFRQ/E; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571663827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7P8DqohVj8YtJUtmSEIjJbEb2vkh1P9xae+lKdhxrPQ=; b=V9YFRQ/EZhVmyCnIAkT8gxak1Y1GoyYamBXpDE8LFYx/SqhfU3arcFZjeP3TtvgbVORUOv pOOJKINthklNg5Lqg/j5PnkXa9xh8ScXzG3AGvcEd1Bc6/bK0CIKdxKG58GUJAMRE6Iu/W lnYiQ6FSUOhNq2yB1F3SRj45qpsup/M= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-330-TIxmPYj7Nh6YpSFe7IEmQQ-1; Mon, 21 Oct 2019 09:17:03 -0400 Received: by mail-wm1-f70.google.com with SMTP id a81so2352195wma.4 for ; Mon, 21 Oct 2019 06:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vDZiHpA1f/X6Um3mflUqNVlSXwAbPxmj+hpSu0nuPcs=; b=pdy7LsrEL7fCMM/yiOr0tEUgTuiSC6qM4IsayMVhmzEorl3MFrCqgoAW4UknPq5259 bx9cFMbWhByLoPsMIzljuD2l48FDbEwLzhU2jfVYvNID8pmmzPyaItH7kFNFZI0gbRM1 izzGUz3jNo8bkNyFSutsbwgju9tOpWt6o6lzso9lIOBjhpqXsDt9bmV19ZbckSIBQP2+ 7fVIVEOxXe8pb1T7jkhXi+lRYKLihyoqvjf5IWuNPXXJVpRx9coX2su48XZ5UWpbSSzF 3Idexw/saq9P7k+y7gLQe8rbuSkiu+d0GEM2a9yOm6ujxnvVUFMujIYM185+ksRgcdWU GOjA== X-Gm-Message-State: APjAAAWSE5woOvrTez1nrbyFzQsU2Rg3gY4h1/0nZpPR+4enz73cPzYm mFoowlK93Br9w6fwJsP5WQk2bTXtlLIcpzlb+fXkaOVTXGrlUMc23lWxSiN3mgLgbdp8WzwkftH MVYjuhw11d3gruA== X-Received: by 2002:adf:f58b:: with SMTP id f11mr16209524wro.85.1571663821634; Mon, 21 Oct 2019 06:17:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfDWpX9mKeKm+HiMuDKijYfTbkjKFrCE2hXai6golWYEsb3pPiW7Vx+B/33zVFtEY9XVpIVA== X-Received: by 2002:adf:f58b:: with SMTP id f11mr16209481wro.85.1571663821064; Mon, 21 Oct 2019 06:17:01 -0700 (PDT) Return-Path: Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id y13sm22413457wrg.8.2019.10.21.06.16.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2019 06:17:00 -0700 (PDT) Subject: Re: [edk2-devel] [Patch] FatPkg: Fix spelling errors To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: Sean Brogan , Ray Ni References: <20191018191513.4500-1-michael.d.kinney@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <630b57b6-2155-562b-5b1d-6f2308be3534@redhat.com> Date: Mon, 21 Oct 2019 15:16:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191018191513.4500-1-michael.d.kinney@intel.com> X-MC-Unique: TIxmPYj7Nh6YpSFe7IEmQQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Michael, On 10/18/19 9:15 PM, Michael D Kinney wrote: > From: Sean Brogan Is a different patch than https://edk2.groups.io/g/devel/topic/32250614=20 or simply the patch author got messed up? It should be: Antoine C=C5=93ur >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2264 >=20 > Cc: Ray Ni > Signed-off-by: Michael D Kinney > --- > FatPkg/EnhancedFatDxe/DirectoryManage.c | 8 ++++---- > FatPkg/EnhancedFatDxe/DiskCache.c | 2 +- > FatPkg/EnhancedFatDxe/Fat.h | 20 ++++++++++---------- > FatPkg/EnhancedFatDxe/FileName.c | 2 +- > FatPkg/EnhancedFatDxe/FileSpace.c | 6 +++--- > FatPkg/EnhancedFatDxe/Info.c | 2 +- > FatPkg/EnhancedFatDxe/Init.c | 2 +- > FatPkg/EnhancedFatDxe/Misc.c | 6 +++--- > FatPkg/EnhancedFatDxe/Open.c | 2 +- > FatPkg/FatPei/FatLiteApi.c | 6 +++--- > FatPkg/FatPei/FatLitePeim.h | 4 ++-- > FatPkg/FatPei/Gpt.c | 2 +- > FatPkg/FatPei/Mbr.c | 2 +- > 13 files changed, 32 insertions(+), 32 deletions(-) >=20 > diff --git a/FatPkg/EnhancedFatDxe/DirectoryManage.c b/FatPkg/EnhancedFat= Dxe/DirectoryManage.c > index 21656883bd..93772dba09 100644 > --- a/FatPkg/EnhancedFatDxe/DirectoryManage.c > +++ b/FatPkg/EnhancedFatDxe/DirectoryManage.c > @@ -17,7 +17,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @param EntryPos - The position of the directory entry t= o be accessed. > @param Entry - The directory entry read or written. > =20 > - @retval EFI_SUCCESS - Access the directory entry sucessfully= . > + @retval EFI_SUCCESS - Access the directory entry successfull= y. > @return other - An error occurred when reading the di= rectory entry. > =20 > **/ > @@ -896,7 +896,7 @@ FatNewEntryPos ( > @param Volume - FAT file system volume. > @param Name - The file name of the volume. > =20 > - @retval EFI_SUCCESS - Update the volume with the directory e= ntry sucessfully. > + @retval EFI_SUCCESS - Update the volume with the directory e= ntry successfully. > @return others - An error occurred when getting volume= label. > =20 > **/ > @@ -927,7 +927,7 @@ FatGetVolumeEntry ( > @param Volume - FAT file system volume. > @param Name - The new file name of the volume. > =20 > - @retval EFI_SUCCESS - Update the Volume sucessfully. > + @retval EFI_SUCCESS - Update the Volume successfully. > @retval EFI_UNSUPPORTED - The input label is not a valid volume l= abel. > @return other - An error occurred when setting volume l= abel. > =20 > @@ -1246,7 +1246,7 @@ FatCloseDirEnt ( > not be created either). > @retval EFI_INVALID_PARAMETER - The parameter is not valid. > @retval EFI_SUCCESS - Open the file successfully. > - @return other - An error occured when locating the OFi= le. > + @return other - An error occurred when locating the OF= ile. > =20 > **/ > EFI_STATUS > diff --git a/FatPkg/EnhancedFatDxe/DiskCache.c b/FatPkg/EnhancedFatDxe/Di= skCache.c > index 2df0aa09f1..df587810fb 100644 > --- a/FatPkg/EnhancedFatDxe/DiskCache.c > +++ b/FatPkg/EnhancedFatDxe/DiskCache.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > are older than the contents in disk, so they are invalid; just mark t= hem invalid. > =20 > When this function is called by read command, if any entry in this ra= nge > - is dirty, it means that the relative info directly readed from media i= s older than > + is dirty, it means that the relative info directly read from media is = older than > than the info in the cache; So need to update the relative info in th= e Buffer. > =20 > @param Volume - FAT file system volume. > diff --git a/FatPkg/EnhancedFatDxe/Fat.h b/FatPkg/EnhancedFatDxe/Fat.h > index 98ead5a0fb..46c185c3a9 100644 > --- a/FatPkg/EnhancedFatDxe/Fat.h > +++ b/FatPkg/EnhancedFatDxe/Fat.h > @@ -865,7 +865,7 @@ FatCleanupVolume ( > =20 > @param OFile - The open file. > =20 > - @retval EFI_SUCCESS - Shrinked sucessfully. > + @retval EFI_SUCCESS - Shrinked successfully. > @retval EFI_VOLUME_CORRUPTED - There are errors in the file's cluste= rs. > =20 > **/ > @@ -881,7 +881,7 @@ FatShrinkEof ( > @param OFile - The open file. > @param NewSizeInBytes - The new size in bytes of the open fil= e. > =20 > - @retval EFI_SUCCESS - The file is grown sucessfully. > + @retval EFI_SUCCESS - The file is grown successfully. > @retval EFI_UNSUPPORTED - The file size is larger than 4GB. > @retval EFI_VOLUME_CORRUPTED - There are errors in the files' cluste= rs. > @retval EFI_VOLUME_FULL - The volume is full and can not grow t= he file. > @@ -969,7 +969,7 @@ FatComputeFreeInfo ( > @param Handle - The handle of parent device. > @param DiskIo - The DiskIo of parent device. > @param DiskIo2 - The DiskIo2 of parent device. > - @param BlockIo - The BlockIo of parent devicel > + @param BlockIo - The BlockIo of parent device. > =20 > @retval EFI_SUCCESS - Allocate a new volume successfully. > @retval EFI_OUT_OF_RESOURCES - Can not allocate the memory. > @@ -1079,7 +1079,7 @@ FatDestroySubtask ( > @param IFile - The instance of the open file. > @param Task - The task to be executed. > =20 > - @retval EFI_SUCCESS - The task was executed sucessfully. > + @retval EFI_SUCCESS - The task was executed successfully. > @return other - An error occurred when executing the = task. > =20 > **/ > @@ -1097,7 +1097,7 @@ FatQueueTask ( > @param IoMode - The access mode. > @param DirtyValue - Set the volume as dirty or not. > =20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @return other - An error occurred when operation the = FAT entries. > =20 > **/ > @@ -1120,7 +1120,7 @@ FatAccessVolumeDirty ( > @param Task point to task instance. > =20 > @retval EFI_SUCCESS - The operation is performed successful= ly. > - @retval EFI_VOLUME_CORRUPTED - The accesss is > + @retval EFI_VOLUME_CORRUPTED - The access is > @return Others - The status of read/write the disk > =20 > **/ > @@ -1361,7 +1361,7 @@ FatStriCmp ( > @retval EFI_SUCCESS - Open the file successfully. > @retval EFI_INVALID_PARAMETER - The open mode is conflict with the at= tributes > or the file name is not valid. > - @retval EFI_NOT_FOUND - Conficts between dir intention and att= ribute. > + @retval EFI_NOT_FOUND - Conflicts between dir intention and at= tribute. > @retval EFI_WRITE_PROTECTED - Can't open for write if the volume is= read only. > @retval EFI_ACCESS_DENIED - If the file's attribute is read only,= and the > open is for read-write fail it. > @@ -1710,7 +1710,7 @@ FatCloseDirEnt ( > not be created either). > @retval EFI_INVALID_PARAMETER - The parameter is not valid. > @retval EFI_SUCCESS - Open the file successfully. > - @return other - An error occured when locating the OFi= le. > + @return other - An error occurred when locating the OF= ile. > =20 > **/ > EFI_STATUS > @@ -1728,7 +1728,7 @@ FatLocateOFile ( > @param Volume - FAT file system volume. > @param Name - The file name of the volume. > =20 > - @retval EFI_SUCCESS - Update the volume with the directory e= ntry sucessfully. > + @retval EFI_SUCCESS - Update the volume with the directory e= ntry successfully. > @return others - An error occurred when getting volume= label. > =20 > **/ > @@ -1745,7 +1745,7 @@ FatGetVolumeEntry ( > @param Volume - FAT file system volume. > @param Name - The new file name of the volume. > =20 > - @retval EFI_SUCCESS - Update the Volume sucessfully. > + @retval EFI_SUCCESS - Update the Volume successfully. > @retval EFI_UNSUPPORTED - The input label is not a valid volume l= abel. > @return other - An error occurred when setting volume l= abel. > =20 > diff --git a/FatPkg/EnhancedFatDxe/FileName.c b/FatPkg/EnhancedFatDxe/Fil= eName.c > index bab709d964..256db30954 100644 > --- a/FatPkg/EnhancedFatDxe/FileName.c > +++ b/FatPkg/EnhancedFatDxe/FileName.c > @@ -100,7 +100,7 @@ FatCheckIs8Dot3Name ( > =20 > Trim the trailing blanks of fat name. > =20 > - @param Name - The Char8 string needs to be trimed. > + @param Name - The Char8 string needs to be trimmed. > @param Len - The length of the fat name. > =20 > The real length of the fat name after the trailing blanks are trimmed= . > diff --git a/FatPkg/EnhancedFatDxe/FileSpace.c b/FatPkg/EnhancedFatDxe/Fi= leSpace.c > index 6659036039..0dd66e0c53 100644 > --- a/FatPkg/EnhancedFatDxe/FileSpace.c > +++ b/FatPkg/EnhancedFatDxe/FileSpace.c > @@ -129,7 +129,7 @@ FatGetFatEntry ( > @param Index - The index of the FAT entry of the vol= ume. > @param Value - The new value of the FAT entry. > =20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @retval EFI_VOLUME_CORRUPTED - The FAT type of the volume is error. > @return other - An error occurred when operation the = FAT entries. > =20 > @@ -343,7 +343,7 @@ FatSizeToClusters ( > =20 > @param OFile - The open file. > =20 > - @retval EFI_SUCCESS - Shrinked sucessfully. > + @retval EFI_SUCCESS - Shrinked successfully. > @retval EFI_VOLUME_CORRUPTED - There are errors in the file's cluste= rs. > =20 > **/ > @@ -416,7 +416,7 @@ FatShrinkEof ( > @param OFile - The open file. > @param NewSizeInBytes - The new size in bytes of the open fil= e. > =20 > - @retval EFI_SUCCESS - The file is grown sucessfully. > + @retval EFI_SUCCESS - The file is grown successfully. > @retval EFI_UNSUPPORTED - The file size is larger than 4GB. > @retval EFI_VOLUME_CORRUPTED - There are errors in the files' cluste= rs. > @retval EFI_VOLUME_FULL - The volume is full and can not grow t= he file. > diff --git a/FatPkg/EnhancedFatDxe/Info.c b/FatPkg/EnhancedFatDxe/Info.c > index 1c9811cad0..fd4c0278f9 100644 > --- a/FatPkg/EnhancedFatDxe/Info.c > +++ b/FatPkg/EnhancedFatDxe/Info.c > @@ -407,7 +407,7 @@ FatSetFileInfo ( > // > if (OFile->ODir !=3D NULL) { > // > - // Syncronize its dot entry > + // Synchronize its dot entry > // > FatResetODirCursor (OFile); > ASSERT (OFile->Parent !=3D NULL); > diff --git a/FatPkg/EnhancedFatDxe/Init.c b/FatPkg/EnhancedFatDxe/Init.c > index 530154bd25..4e6bd9d0fd 100644 > --- a/FatPkg/EnhancedFatDxe/Init.c > +++ b/FatPkg/EnhancedFatDxe/Init.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > @param Handle - The handle of parent device. > @param DiskIo - The DiskIo of parent device. > @param DiskIo2 - The DiskIo2 of parent device. > - @param BlockIo - The BlockIo of parent devicel > + @param BlockIo - The BlockIo of parent device. > =20 > @retval EFI_SUCCESS - Allocate a new volume successfully. > @retval EFI_OUT_OF_RESOURCES - Can not allocate the memory. > diff --git a/FatPkg/EnhancedFatDxe/Misc.c b/FatPkg/EnhancedFatDxe/Misc.c > index bc19695fc9..a005036d46 100644 > --- a/FatPkg/EnhancedFatDxe/Misc.c > +++ b/FatPkg/EnhancedFatDxe/Misc.c > @@ -114,7 +114,7 @@ FatDestroySubtask ( > @param IFile - The instance of the open file. > @param Task - The task to be executed. > =20 > - @retval EFI_SUCCESS - The task was executed sucessfully. > + @retval EFI_SUCCESS - The task was executed successfully. > @return other - An error occurred when executing the = task. > =20 > **/ > @@ -219,7 +219,7 @@ FatQueueTask ( > @param IoMode - The access mode. > @param DirtyValue - Set the volume as dirty or not. > =20 > - @retval EFI_SUCCESS - Set the new FAT entry value sucessfull= y. > + @retval EFI_SUCCESS - Set the new FAT entry value successful= ly. > @return other - An error occurred when operation the = FAT entries. > =20 > **/ > @@ -304,7 +304,7 @@ FatOnAccessComplete ( > @param Task point to task instance. > =20 > @retval EFI_SUCCESS - The operation is performed successful= ly. > - @retval EFI_VOLUME_CORRUPTED - The accesss is > + @retval EFI_VOLUME_CORRUPTED - The access is > @return Others - The status of read/write the disk > =20 > **/ > diff --git a/FatPkg/EnhancedFatDxe/Open.c b/FatPkg/EnhancedFatDxe/Open.c > index cfd99baf7d..1b716e0cdf 100644 > --- a/FatPkg/EnhancedFatDxe/Open.c > +++ b/FatPkg/EnhancedFatDxe/Open.c > @@ -74,7 +74,7 @@ FatAllocateIFile ( > @retval EFI_SUCCESS - Open the file successfully. > @retval EFI_INVALID_PARAMETER - The open mode is conflict with the at= tributes > or the file name is not valid. > - @retval EFI_NOT_FOUND - Conficts between dir intention and att= ribute. > + @retval EFI_NOT_FOUND - Conflicts between dir intention and at= tribute. > @retval EFI_WRITE_PROTECTED - Can't open for write if the volume is= read only. > @retval EFI_ACCESS_DENIED - If the file's attribute is read only,= and the > open is for read-write fail it. > diff --git a/FatPkg/FatPei/FatLiteApi.c b/FatPkg/FatPei/FatLiteApi.c > index b9f883b9e0..8c7c6e5258 100644 > --- a/FatPkg/FatPei/FatLiteApi.c > +++ b/FatPkg/FatPei/FatLiteApi.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > PEI_FAT_PRIVATE_DATA *mPrivateData =3D NULL; > =20 > /** > - BlockIo installation nofication function. Find out all the current Blo= ckIO > + BlockIo installation notification function. Find out all the current B= lockIO > PPIs in the system and add them into private data. Assume there is > =20 > @param PeiServices General purpose services available to= every > @@ -256,7 +256,7 @@ FatPeimEntry ( > =20 > Status =3D PeiServicesAllocatePages ( > EfiBootServicesCode, > - (sizeof (PEI_FAT_PRIVATE_DATA) - 1) / PEI_FAT_MEMMORY_PAGE_S= IZE + 1, > + (sizeof (PEI_FAT_PRIVATE_DATA) - 1) / PEI_FAT_MEMORY_PAGE_SI= ZE + 1, > &Address > ); > if (EFI_ERROR (Status)) { > @@ -600,7 +600,7 @@ LoadRecoveryCapsule ( > @param FileName The recovery file name to find. > @param Handle The output file handle. > =20 > - @retval EFI_DEVICE_ERROR Some error occured when operating the = FAT > + @retval EFI_DEVICE_ERROR Some error occurred when operating the= FAT > volume. > @retval EFI_NOT_FOUND The recovery file was not found. > @retval EFI_SUCCESS The recovery file was successfully fo= und on the > diff --git a/FatPkg/FatPei/FatLitePeim.h b/FatPkg/FatPei/FatLitePeim.h > index 18534b9abb..9cacf74ace 100644 > --- a/FatPkg/FatPei/FatLitePeim.h > +++ b/FatPkg/FatPei/FatLitePeim.h > @@ -40,7 +40,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #define PEI_FAT_MAX_BLOCK_IO_PPI 32 > #define PEI_FAT_MAX_VOLUME 64 > =20 > -#define PEI_FAT_MEMMORY_PAGE_SIZE 0x1000 > +#define PEI_FAT_MEMORY_PAGE_SIZE 0x1000 > =20 > // > // Data Structures > @@ -194,7 +194,7 @@ typedef struct { > @param FileName The recovery file name to find. > @param Handle The output file handle. > =20 > - @retval EFI_DEVICE_ERROR Some error occured when operating the = FAT > + @retval EFI_DEVICE_ERROR Some error occurred when operating the= FAT > volume. > @retval EFI_NOT_FOUND The recovery file was not found. > @retval EFI_SUCCESS The recovery file was successfully fo= und on the > diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c > index 233a66b974..4028c535f3 100644 > --- a/FatPkg/FatPei/Gpt.c > +++ b/FatPkg/FatPei/Gpt.c > @@ -48,7 +48,7 @@ PartitionCheckGptHeaderCRC ( > GptHdrCrc =3D PartHeader->Header.CRC32; > =20 > // > - // Set CRC field to zero when doing calcuation > + // Set CRC field to zero when doing calculation > // > PartHeader->Header.CRC32 =3D 0; > =20 > diff --git a/FatPkg/FatPei/Mbr.c b/FatPkg/FatPei/Mbr.c > index 0b6375af6d..5b01604c07 100644 > --- a/FatPkg/FatPei/Mbr.c > +++ b/FatPkg/FatPei/Mbr.c > @@ -52,7 +52,7 @@ PartitionValidMbr ( > if (EndingLBA > LastLba) { > // > // Compatability Errata: > - // Some systems try to hide drive space with thier INT 13h driver > + // Some systems try to hide drive space with their INT 13h driver > // This does not hide space from the OS driver. This means the M= BR > // that gets created from DOS is smaller than the MBR created fr= om > // a real OS (NT & Win98). This leads to BlockIo->LastBlock bein= g >=20