From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 24 Sep 2019 09:05:55 -0700 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EF8C6315C02C; Tue, 24 Sep 2019 16:05:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-118.rdu2.redhat.com [10.10.120.118]) by smtp.corp.redhat.com (Postfix) with ESMTP id 335FD61559; Tue, 24 Sep 2019 16:05:53 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace To: Leif Lindholm Cc: devel@edk2.groups.io References: <20190919180625.29150-1-leif.lindholm@linaro.org> <20190919180625.29150-7-leif.lindholm@linaro.org> <20190920102436.GD28454@bivouac.eciton.net> From: "Laszlo Ersek" Message-ID: <63323bc3-0fe9-9469-ebcb-67d38f4ffa7d@redhat.com> Date: Tue, 24 Sep 2019 18:05:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190920102436.GD28454@bivouac.eciton.net> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 24 Sep 2019 16:05:55 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/20/19 12:24, Leif Lindholm wrote: > > On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote: >> On 09/19/19 20:06, Leif Lindholm wrote: >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Anthony Perard >>> Cc: Julien Grall >>> Cc: David Woodhouse >>> Signed-off-by: Leif Lindholm >>> --- >>> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- >>> OvmfPkg/AcpiPlatformDxe/Xen.c | 8 ++++---- >>> OvmfPkg/AcpiTables/Facs.aslc | 6 +++--- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 +++++++++--------- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +- >>> OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 +++++++++++++++++----------------- >>> OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 ++-- >>> OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +++++----- >>> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +- >>> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 ++++++------ >>> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +- >>> OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +- >>> OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 ++-- >>> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +- >>> OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +- >>> OvmfPkg/PlatformPei/Xen.c | 2 +- >>> OvmfPkg/SataControllerDxe/ComponentName.c | 6 +++--- >>> OvmfPkg/SataControllerDxe/SataController.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------------------------------------------------- >>> OvmfPkg/SataControllerDxe/SataController.h | 208 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------------------- >> >> (did you forget --stat-graph-width=20?) > > Hmm... > *scratches head* > First of all, I saw that before sending out and didn't even reflect on > it. Clearly past git-send-email-o-clock. > > Secondly, I have > [diff] > statGraphWidth = 20 > in .git/config from running SetupGit.py. > > Oh, rubbish. From git-diff manpage: > --- > The width of the graph part can be limited by using > --stat-graph-width= (affects all commands generating a stat > graph) or by setting diff.statGraphWidth= (does not affect git > format-patch). > --- > I had missed that bit. So yeah, that setting in SetupGit.py is > completely meaningless. > (Why would you give those two different code paths?!?) Right, no clue. It's pretty annoying. > > Which given we already can't set --stat ... > Do you think it might be a good idea to set up a few standard aliases? Perhaps. Either way, it is asking people to do something "extra", and then I like that "extra" to be "portable" to other projects. "--stat-graph-width=..." is portable like that, an alias wouldn't be. Not a strong preference in either direction from me, though. Thanks! Laszlo > >>> OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +++--- >>> OvmfPkg/Sec/SecMain.c | 34 +++++++++++++++++----------------- >>> 27 files changed, 301 insertions(+), 301 deletions(-) >> >> I've checked this patch with "git show -b" (--> nothing) and "git show >> --word-diff" (--> output consists purely of context). >> >> Reviewed-by: Laszlo Ersek > > Thanks! > > / > Leif >