Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

["Lendacky, Thomas via groups.io" <thomas.lendacky=amd.com@groups.io>]

On 11/17/23 15:43, Tom Lendacky wrote:
> 
> 
> On 11/7/23 03:55, Gerd Hoffmann wrote:
>> On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote:
>>> This patch series provides fixes around AP startup and sorting:
>>>
>>> - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The
>>>    current SEV-SNP support is attempting to retrieve the this leaf with
>>>    sub-leaf 0, but is calling AsmCpuid(), which does not clear ECX before
>>>    invoking the CPUID instruction. Therefore, because of the calling
>>>    convention, the leaf value becomes the sub-leaf value and ends up
>>>    returning incorrect information. Change the call from AsmCpuid() to
>>>    AsmCpuidEx().
>>>
>>> - When sorting the CPUs by APIC ID, the VMSA associated with the vCPU
>>>    should follow the APIC ID. Update the sorting code to swap the VMSA
>>>    pointer during the sort.
>>
>> Series:
>> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
>>
> 
> Eric/Ray/Rahul,
> 
> Have you had a chance to review this series? These bug fixes would be good 
> to get in for the next/latest release...

Eric/Ray/Rahul,

Any feedback? If not, can you Ack them so they can be merged... they 
already missed the edk2-stable202311 tag.

Thanks,
Tom

> 
> Thanks,
> Tom


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111756): https://edk2.groups.io/g/devel/message/111756
Mute This Topic: https://groups.io/mt/102432041/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-