From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1D44D74003B for ; Mon, 27 Nov 2023 19:00:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FsJJXSJy1oJGpuHpdpyvRDe6dwUsjK2jhATgq+hajg8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:From:To:CC:References:Autocrypt:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701111627; v=1; b=caySOUp5aleSqTJPPOQfFUhSbvgDJIVoIBW7QE6rxdHrIYfq3A0G34+nXlrwKrsvjBtgZM27 PHs0tzF8aew1CXC5PhroS+TIlicv5cVYgAdyL4X9J0BxvO4k5t2LfxMG41FHKrMP0Dfxs2R4qgC QoVwTJC+Ey4Ps/M98tXZzaD4= X-Received: by 127.0.0.2 with SMTP id 4kF1YY7687511xaWjlvqltEs; Mon, 27 Nov 2023 11:00:27 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.70]) by mx.groups.io with SMTP id smtpd.web11.103528.1701111627014288434 for ; Mon, 27 Nov 2023 11:00:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X0Jdt0VaTwMmMzUWh61EWdAZ8+zzCwptmfEpEgK3tNTWmkrlOKM8gW6LlCIWyKtDup5sZR9662pewSrOI6hr4CMU2cEkSkdR/JESha0fjp4SwQYzt+5/HRnUcR8cQti1RgeFvObz8N++NRsFKgSQrK+omTg26vkb3ziS73J3SCMR2buGQg5ygUY6qmBaXxKULcpeKqX8qOqZL2m0Ap2kBPay+H2r1TzKzIUiuo+l7b6oGCngXgnXmlB1c0y/ViuX0ftCgkiaIEsrLhtW4OqejuyvhzBEDQIsdJYneY+eubji2jK3Q4Myu0goIekjVqLcEztd/G4wNawruVx2b16Y/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=os1bUnqJZtNLp39oeCIZhYgF2DDT9SFEQsgiVToej1k=; b=NTqzmpM1lX/qSczAAzC2yWXiNzCCHpDN79+C8r3+QVZrxSDLmX/epgCJi9aXlVh1EGlZEurUYanwhdBlvFE0APx0GFvfI3GUtDo6EBnCpchNUJfwVUCfd9jhDuZuj+hmMwDH/TykbAIFyXKBcjcQKoGemIUjtB4KOyTYeBNNa688y6UdpaVUyrqI6QNaLlRjM1TXG19dpg9ndMubEcCoX7PLH6oWrSJ40MZM9/5XHOkBepNE22xHwrPw8vqjCwYSf3dGDJjIyHTd2KMjLrybGCbiG2fOMK9hfgKfNMh5Bz+ryFTOJ6qw+3m0AYW574+03S3GxDXNIr54HCrDC17mcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) by PH7PR12MB7308.namprd12.prod.outlook.com (2603:10b6:510:20c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Mon, 27 Nov 2023 19:00:24 +0000 X-Received: from BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::1d68:1eb8:d7dc:4b43]) by BL1PR12MB5732.namprd12.prod.outlook.com ([fe80::1d68:1eb8:d7dc:4b43%6]) with mapi id 15.20.7025.022; Mon, 27 Nov 2023 19:00:24 +0000 Message-ID: <63405d32-d16f-49ae-96bd-db84cff8ba6b@amd.com> Date: Mon, 27 Nov 2023 13:00:22 -0600 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes From: "Lendacky, Thomas via groups.io" To: Eric Dong , Ray Ni , Rahul Kumar CC: devel@edk2.groups.io, Ard Biesheuvel , Michael Roth , Gerd Hoffmann References: <7c3e2baa-37c0-da85-bd74-55d08599fdc8@amd.com> Autocrypt: addr=thomas.lendacky@amd.com; keydata= xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAl/aLz0FCQ7wZDQACgkQ 3v+a5E8wTVPgshAA7Zj/5GzvGTU7CLInlWP/jx85hGPxmMODaTCkDqz1c3NOiWn6c2OT/6cM d9bvUKyh9HZHIeRKGELMBIm/9Igi6naMp8LwXaIf5pw466cC+S489zI3g+UZvwzgAR4fUVaI Ao6/Xh/JsRE/r5a36l7mDmxvh7xYXX6Ej/CselZbpONlo2GLPX+WAJItBO/PquAhfwf0b6n5 zC89ats5rdvEc8sGHaUzZpSteWnk39tHKtRGTPBSFWLo8x76IIizTFxyto8rbpD8j8rppaT2 ItXIjRDeCOvYcnOOJKnzh+Khn7l8t3OMaa8+3bHtCV7esaPfpHWNe3cVbFLsijyRUq4ue5yU QnGf/A5KFzDeQxJbFfMkRtHZRKlrNIpDAcNP3UJdel7i593QB7LcLPvGJcUfSVF76opA9aie JXadBwtKMU25J5Q+GhfjNK+czTMKPq12zzdahvp61Y/xsEaIGCvxXw9whkC5SQ2Lq9nFG8mp sAKrtWXsEPDDbuvdK/ZMBaWiaFr92lzdutqph8KdXdO91FFnkAJgmOI8YpqT9MmmOMV4tunW 0XARjz+QqvlaM7q5ABQszmPDkPFewtUN/5dMD8HGEvSMvNpy/nw2Lf0vuG/CgmjFUCv4CTFJ C28NmOcbqqx4l75TDZBZTEnwcEAfaTc7BA/IKpCUd8gSglAQ18fOwU0EVo1liQEQAL7ybY01 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+ LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe /5rkTzBNUwUCYSZsLQUJDvBnJAAKCRDe/5rkTzBNU+brD/43/I+JCxmbYnrhn78J835hKn56 OViy/kWYBzYewz0acMi+wqGqhhvZipDCPECtjadJMiSBmJ5RAnenSr/2isCXPg0Vmq3nzv+r eT9qVYiLfWdRiXiYbUWsKkKUrFYo47TZ2dBrxYEIW+9g98JM28TiqVKjIUymvU6Nmf6k+qS/ Z1JtrbzABtOTsmWWyOqgobQL35jABARqFu3pv2ixu5tvuXqCTd2OCy51FVvnflF3X2xkUZWP ylHhk+xXAaUQTNxeHC/CPlvHWaoFJTcjSvdaPhSbibrjQdwZsS5N+zA3/CF4JwlI+apMBzZn otdWTawrt/IQQSpJisyHzo8FasAUgNno7k1kuc72OD5FZ7uVba9nPobSxlX3iX3rNePxKJdb HPzDZTOPRxaRL4pKVnndF2luKsXw+ly7IInf0DrddVtb2647SJ7dKTvvQpzXN9CmdkL13hC5 ouvZ49PlXeelyims7MU0l2Oi1o718SCSVHzISJG7Ef6OrdvlRC3hTk5BDgphAV/+8g7BuGF+ 6irTe/qtb/1CMFFtcqDorjI3hkc10N0jzPOsjS8bhpwKeUwGsgvXWGEqwlEDs2rswfAU/tGZ 7L30CgQ9itbxnlaOz1LkKOTuuxx4A+MDMCHbUMAAP9Eoh/L1ZU0z71xDyJ53WPBd9Izfr9wJ 1NhFSLKvfA== In-Reply-To: <7c3e2baa-37c0-da85-bd74-55d08599fdc8@amd.com> X-ClientProxiedBy: SN7PR04CA0171.namprd04.prod.outlook.com (2603:10b6:806:125::26) To BL1PR12MB5732.namprd12.prod.outlook.com (2603:10b6:208:387::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL1PR12MB5732:EE_|PH7PR12MB7308:EE_ X-MS-Office365-Filtering-Correlation-Id: 57f106aa-be52-422e-53ae-08dbef7b1c53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: FF4mlSMuYtjBFA5eZ3l7o8VL5I7OgpbbYyMUdSMFNDebKv3Bw3L5zOwfxbxqLXxuKSHO6IE36ER/C/+6mRTcJorsw8hiE18LOgryqwvpr8zNeZ9+ouyLscWWWYeKIj0z0+apTrUK4B4/226FRvtzgEYkR/ZKqNiEnxhX6J2nwgfllt3121ubbbV7iqUsSGWOjmwvwRd/yX+tfbuUr1/+3fZBENdyJCZrOY8U34PfngXi/Fjdfqyj9nrOmbK6KLNIEB8uLcoA+VJpAs36XAE13XlS1N2oPkJSSYnqZj51lFfXWW/EvGxWuM6JoxcIbpv3gkOjOmakMneYvQfJ5LNtTEqgmBj8Vw6YRDNINXTgKnXOOoJTa1e+WDXdXn3ldFWa6fSNle/MloeNgZZOYlyVDLRlqk4ZY7WPcVf/CVyMuzI+oH22gJJ85noyFmGSXoYd7NL/NF862RkO/Mwpuy202DiNuSHPd8kt48iVbnnHok8eVpEHRlRE7EfQX052b2Fj6gjhrMwWoowRzVDFii4IFN+ExU5EiaVKSoGUjhqT7agMxWRLeTbOogwJjmT9Pbb4LJrUY8L+8qPWtRAZnWEGAxSXBlgxer4w1zo63atOff5nvYh/094KdGrksXoStS8EfDY+/dq/jmFiDpj3p79IAg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ARvz4sw2ffnUUrGmBnHi/Qh77z0DcvFpItrICacOpRExUqFQ3HG2npNaElMa?= =?us-ascii?Q?l7irU7qwaEGc8DRkH3ipANXTBLkGENu4f1Vk+Ti3l4sYvpOO7QJiGuErXYig?= =?us-ascii?Q?7DWA8QZdqkYgJWAXRQ96gwyKy/IGQkB+9kKR3CmHkTCAtvLCz/vh+I0D9DkY?= =?us-ascii?Q?tp1g6bnu/m8vGpWst0gucwJSAWU1u+hKQSXK04AB+HiogriNA101Lw1PqieB?= =?us-ascii?Q?zwl7PKGUsZ4NHeS74G0KjfkJbO1J1vhxQgAfTE8aYz9dJ9LNRVgXoHZpNT1r?= =?us-ascii?Q?WlHy7p4GINDVKVGfsZ8v46HxFXZNa6cYkEU+qIXRvpfvQhzOW6Q8vWWLo3n1?= =?us-ascii?Q?EIxaF4bJ4dVdvmvyJdqTWHjSkNRIChn38xX3SILTC/CDH7iAIMMHvvsXCG6Z?= =?us-ascii?Q?gLOCWtk0RxGv4NxUTtB7Npu/AUq64Md1Hnk0B1+wfYyav6L9XqLYpvVG4MRd?= =?us-ascii?Q?C/Vp0Yyt2PzPp8gVeVKDkrblrkSc8bvT/+Ban66ZLsbibpOrTFIm+V7KnYTl?= =?us-ascii?Q?YcfTEz6kskAJn/tGuCGavJ9f90CycLL2+R4WUA8g0paTZh8c7aQNLiFj2Mby?= =?us-ascii?Q?sPThOHqmzCuiGCjGq68PzFTQw5RbcJZ0VYW89wBEbVwQKDogPUz3w1u67G6Z?= =?us-ascii?Q?nTQHB6Jy6cviJDCge90iI7xho7SVXZjhvqrPbqo459KCKmdgxC1oP2PzrUGU?= =?us-ascii?Q?E+1MBiL8mebmU0y79rJf3WLBU3uUBaJJbn4a8E9/5e31ld/WqbSKsAEkZffv?= =?us-ascii?Q?oJ7CNEwMgkYqHy4iskdVcKC5XVBaddtMBFtBJhOv56R28DbFqthScdL9mkel?= =?us-ascii?Q?inpLv+ThI4iswy3F6Gw5WMu6wIKGLZCojCFeibr82L1XlVQULsriv4RC5ICd?= =?us-ascii?Q?OxCQncnE7cbn4vIpLT7vXbOx8DZYichh+GffpZ4lp0Kz+B1Z2XN9SmXQoyie?= =?us-ascii?Q?l4QwMXt8clWyH0FTxV24C9unUhBlu2HoIHtqhJZUqVSnkm7fYKpHlago1wjc?= =?us-ascii?Q?bpiZxeABbJvIv68vhuNxM7Ic6gVw3G6h/WSbSybBG9qp14c3zqDenT+qTdPM?= =?us-ascii?Q?BBjrTwcA/VylJAPVMKwadHMzM9VW+irQA7WMrYSzDZjMR9kg1X5rHdaSUthM?= =?us-ascii?Q?F5LHtnUpQtFaEQDcqMwiZS9PFApi1mMd2BYMxxSY0oVGSGFW6KzBjaGbOgmM?= =?us-ascii?Q?Lpuy9Q9vVv6Ln4ll/AqarcGZsaiwrUqhNn/ZB1oNoSTXKj1rdI8GwtUlHLoT?= =?us-ascii?Q?jCIe8RSw1ueewvGddd60UEgyrUb2kXiniECH9vjWr31mY4Yft8tbVHW+yS5r?= =?us-ascii?Q?WCVL1uXb7l10QKNL5JAp2J4+fw0aMssnAZKROJU5mXXr4Uges4SaVqsMBo4I?= =?us-ascii?Q?kg87iEbLespCdLKREcsQZgx9PYg2lANX+U7TWnef4RNQ/U4i/nyFDff/m6Q1?= =?us-ascii?Q?Kjizv7CAiJoErqe5YhgPTQ34NcdUAG0Pjt33/iTuPHh5fbiyk7Mv49f4ZlYe?= =?us-ascii?Q?oNK8Us/v+RBM/6WTAwTtDYaEZofXCjTdiJwYPhof24P7Rg/NDUS5w3Cxjel+?= =?us-ascii?Q?bso4Op6YQUERJKOEAq2cCG3vTQcaU3GejDUtf2EP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57f106aa-be52-422e-53ae-08dbef7b1c53 X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 19:00:24.0608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4hzgC5nz1i/Ok7oHBwvu0CVnxUXzrqjBxJxyjj3Q8WVsLjSyxW9v2Vn3f4EUUXIHhYoKSuoou0BRQ31z5QXGHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7308 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Af05N3R1dueAnUldT3JvNZKDx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=caySOUp5; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") On 11/17/23 15:43, Tom Lendacky wrote: >=20 >=20 > On 11/7/23 03:55, Gerd Hoffmann wrote: >> On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote: >>> This patch series provides fixes around AP startup and sorting: >>> >>> - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The >>> =C2=A0=C2=A0 current SEV-SNP support is attempting to retrieve the this= leaf with >>> =C2=A0=C2=A0 sub-leaf 0, but is calling AsmCpuid(), which does not clea= r ECX before >>> =C2=A0=C2=A0 invoking the CPUID instruction. Therefore, because of the = calling >>> =C2=A0=C2=A0 convention, the leaf value becomes the sub-leaf value and = ends up >>> =C2=A0=C2=A0 returning incorrect information. Change the call from AsmC= puid() to >>> =C2=A0=C2=A0 AsmCpuidEx(). >>> >>> - When sorting the CPUs by APIC ID, the VMSA associated with the vCPU >>> =C2=A0=C2=A0 should follow the APIC ID. Update the sorting code to swap= the VMSA >>> =C2=A0=C2=A0 pointer during the sort. >> >> Series: >> Acked-by: Gerd Hoffmann >> >=20 > Eric/Ray/Rahul, >=20 > Have you had a chance to review this series? These bug fixes would be goo= d=20 > to get in for the next/latest release... Eric/Ray/Rahul, Any feedback? If not, can you Ack them so they can be merged... they=20 already missed the edk2-stable202311 tag. Thanks, Tom >=20 > Thanks, > Tom -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111756): https://edk2.groups.io/g/devel/message/111756 Mute This Topic: https://groups.io/mt/102432041/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-