Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again.

["Pete Batard" <pete@akeo.ie>]

Hi Philippe,

On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote:
> On 11/19/20 6:14 PM, Pete Batard wrote:
>> For reference, this breakage was introduced with edk2 commit
>> https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a
>> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices).
> 
> It is better if Andrei Cc the developers involved (Cc'ed them now).

Good point.

> 
>>
>> It'll probably be worth adding a reference to it in the commit message
>> during integration.
> 
> This can be added before the S-o-b:
> 
> Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business
> logic to VariableServices")

Just going to nitpick that since we're patching in edk2-platforms and 
referencing an edk2 commit, we'll want:

Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect 
VariablePolicy business logic to VariableServices")

For GitHub to produce a clickable link.

Regards,

/Pete

> 
>>
>> With this:
>>
>> On 2020.11.19 00:01, Andrei Warkentin wrote:
>>> Add VariablePolicyLib and its dependency.
>>>
>>> Testing: Pi 4 boot.
>>>
>>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>>> ---
>>>    Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++
>>>    Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
>>>    2 files changed, 6 insertions(+)
>>>
>>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> index 325d7bdb..9408138d 100644
>>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> @@ -169,6 +169,8 @@
>>>     
>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>
>>>    !endif
>>>      VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>>
>>> +
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>>>
>>>      GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>>>      [LibraryClasses.common.SEC]
>>> @@ -218,6 +220,7 @@
>>>     
>>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>>>      EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
>>>      ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>>>
>>>      !if $(SECURE_BOOT_ENABLE) == TRUE
>>>      BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> index c994f56d..4e5a36ed 100644
>>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> @@ -169,6 +169,8 @@
>>>     
>>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>>>
>>>    !endif
>>>      VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
>>>
>>> +
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
>>>
>>>      GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>>>        #
>>> @@ -226,6 +228,7 @@
>>>     
>>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>>>      EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
>>>      ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>>>
>>>      !if $(SECURE_BOOT_ENABLE) == TRUE
>>>      BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>>>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>