From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mx.groups.io with SMTP id smtpd.web10.12614.1605807201205990648 for ; Thu, 19 Nov 2020 09:33:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=jTyr5UVG; spf=pass (domain: akeo.ie, ip: 209.85.128.68, mailfrom: pete@akeo.ie) Received: by mail-wm1-f68.google.com with SMTP id p22so7973427wmg.3 for ; Thu, 19 Nov 2020 09:33:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7evvB/8tvW7v9tXCEPEZmzcbf98YD+ZvY9QpzOY+oQs=; b=jTyr5UVGmgspFgxC8BKfd3UUlQpu8iQFl33b33sw/idbCtCCc6okT3WFP363nh+Qfm xBjuW2lo8clurv68Jbsr33tbtOBSChixnGYxeEyYImMsz3lpjXOcbXPn9b5nGCmsfyt+ VLyW9MdzFCdGIO4URoL63YoCsJlEpwYgmIwCnILidvAKJTXV7UqN/TEs8+SQ+t8Ui0hL BHwH8qEpHDYfl6x3crpd2mMtfLqZlpFS477pDq8hXYS2tQm2xCZcKCaRVEoosoOKVR8r JUkYz3GV8HfI7LW6giebjIW5bG9ygKkX0F8PRXj2w0w2xziDn6KWSpdFRGbKVDsz42fn FOmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7evvB/8tvW7v9tXCEPEZmzcbf98YD+ZvY9QpzOY+oQs=; b=kgFjWl0Ko/IbkY2+6wUOSKQNUfRT5+9akwg12d7HccbKOXh6CqQRRSIrt5S9/2rWAr WWwO4KDEgmVnly2uoTXAR+cW19mSCDNQgEgc4sLByxfXFoe9IPbRXOOc8W1FyH9DOn1/ cLucDNxTmtLGe9jO6lZmvDVBjSt9E/UnA0RcekZffYIS2uTuAcBE152Z5lHp+H30AjVz EBEGr6UBNtLZ3ZsQ+aOV4r14RYL2ogznx7yLev0eivbXwOljuU/H1ewN9BoeQN6e+TT+ S7I4UN3bLsZUTbzLpAghOHAG6HztY9CDPcuLne5zM3MCleF4wxe1P3yIwExsFQIK8HRN 6tyQ== X-Gm-Message-State: AOAM532cXC7F69Qw3g4ima5lCB96/OenQJWyuCQHA20uJyMZVbVrhojG IHmIpNWC7nWSQ2s/K0thvRJjaA== X-Google-Smtp-Source: ABdhPJwBe7UQ/Xq1qMbL686Q3sEUo+3g8sTEPqVdPaYajEDY2Z6bGN7DR3IkOIREIzPw+BWxQmqcoA== X-Received: by 2002:a1c:35c2:: with SMTP id c185mr5673332wma.74.1605807199711; Thu, 19 Nov 2020 09:33:19 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.82.97]) by smtp.googlemail.com with ESMTPSA id a9sm719213wrp.21.2020.11.19.09.33.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 09:33:19 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Andrei Warkentin , devel@edk2.groups.io, Bret Barkelew , Dandan Bi , Jian J Wang Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, Liming Gao References: <20201119000145.1234-1-andrey.warkentin@gmail.com> <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> <894fb881-eb07-8a91-d7f0-7fe372c87359@redhat.com> From: "Pete Batard" Message-ID: <634feced-94f9-d61d-99f9-13451a1d1507@akeo.ie> Date: Thu, 19 Nov 2020 17:33:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <894fb881-eb07-8a91-d7f0-7fe372c87359@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). > > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. > >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. > > This can be added before the S-o-b: > > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete > >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin >>> --- >>>   Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>>   Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>>   2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>>   !endif >>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>>     [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>>     EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>>     ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>>     !if $(SECURE_BOOT_ENABLE) == TRUE >>>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>>   !endif >>>     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>>     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>>       # >>> @@ -226,6 +228,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>>     EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>>     ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>>     !if $(SECURE_BOOT_ENABLE) == TRUE >>>     BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard >> >