* [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. @ 2020-11-19 0:01 Andrei Warkentin 2020-11-19 17:14 ` Pete Batard 2020-11-20 15:09 ` Ard Biesheuvel 0 siblings, 2 replies; 7+ messages in thread From: Andrei Warkentin @ 2020-11-19 0:01 UTC (permalink / raw) To: devel; +Cc: ard.biesheuvel, leif, pete, philmd Add VariablePolicyLib and its dependency. Testing: Pi 4 boot. Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> --- Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ 2 files changed, 6 insertions(+) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc index 325d7bdb..9408138d 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -169,6 +169,8 @@ AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf !endif VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf [LibraryClasses.common.SEC] @@ -218,6 +220,7 @@ CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf !if $(SECURE_BOOT_ENABLE) == TRUE BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc index c994f56d..4e5a36ed 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -169,6 +169,8 @@ AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf !endif VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf # @@ -226,6 +228,7 @@ CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf !if $(SECURE_BOOT_ENABLE) == TRUE BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf -- 2.20.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 0:01 [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again Andrei Warkentin @ 2020-11-19 17:14 ` Pete Batard 2020-11-19 17:28 ` Philippe Mathieu-Daudé 2020-11-20 15:09 ` Ard Biesheuvel 1 sibling, 1 reply; 7+ messages in thread From: Pete Batard @ 2020-11-19 17:14 UTC (permalink / raw) To: Andrei Warkentin, devel; +Cc: ard.biesheuvel, leif, philmd For reference, this breakage was introduced with edk2 commit https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). It'll probably be worth adding a reference to it in the commit message during integration. With this: On 2020.11.19 00:01, Andrei Warkentin wrote: > Add VariablePolicyLib and its dependency. > > Testing: Pi 4 boot. > > Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 325d7bdb..9408138d 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > [LibraryClasses.common.SEC] > @@ -218,6 +220,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index c994f56d..4e5a36ed 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > # > @@ -226,6 +228,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > Reviewed-by: Pete Batard <pete@akeo.ie> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 17:14 ` Pete Batard @ 2020-11-19 17:28 ` Philippe Mathieu-Daudé 2020-11-19 17:33 ` Pete Batard 0 siblings, 1 reply; 7+ messages in thread From: Philippe Mathieu-Daudé @ 2020-11-19 17:28 UTC (permalink / raw) To: Pete Batard, Andrei Warkentin, devel, Bret Barkelew, Dandan Bi, Jian J Wang Cc: ard.biesheuvel, leif, Liming Gao On 11/19/20 6:14 PM, Pete Batard wrote: > For reference, this breakage was introduced with edk2 commit > https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a > (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). It is better if Andrei Cc the developers involved (Cc'ed them now). > > It'll probably be worth adding a reference to it in the commit message > during integration. This can be added before the S-o-b: Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") > > With this: > > On 2020.11.19 00:01, Andrei Warkentin wrote: >> Add VariablePolicyLib and its dependency. >> >> Testing: Pi 4 boot. >> >> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> >> --- >> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >> b/Platform/RaspberryPi/RPi3/RPi3.dsc >> index 325d7bdb..9408138d 100644 >> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >> @@ -169,6 +169,8 @@ >> >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> >> !endif >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> + >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >> >> + >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >> >> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >> [LibraryClasses.common.SEC] >> @@ -218,6 +220,7 @@ >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >> + >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >> >> !if $(SECURE_BOOT_ENABLE) == TRUE >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >> b/Platform/RaspberryPi/RPi4/RPi4.dsc >> index c994f56d..4e5a36ed 100644 >> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >> @@ -169,6 +169,8 @@ >> >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> >> !endif >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> + >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >> >> + >> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >> >> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >> # >> @@ -226,6 +228,7 @@ >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >> + >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >> >> !if $(SECURE_BOOT_ENABLE) == TRUE >> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >> > > Reviewed-by: Pete Batard <pete@akeo.ie> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 17:28 ` Philippe Mathieu-Daudé @ 2020-11-19 17:33 ` Pete Batard 2020-11-19 19:53 ` [edk2-devel] " Andrei Warkentin 0 siblings, 1 reply; 7+ messages in thread From: Pete Batard @ 2020-11-19 17:33 UTC (permalink / raw) To: Philippe Mathieu-Daudé, Andrei Warkentin, devel, Bret Barkelew, Dandan Bi, Jian J Wang Cc: ard.biesheuvel, leif, Liming Gao Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). > > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. > >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. > > This can be added before the S-o-b: > > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete > >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> >>> --- >>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> # >>> @@ -226,6 +228,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard <pete@akeo.ie> >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 17:33 ` Pete Batard @ 2020-11-19 19:53 ` Andrei Warkentin 2020-11-20 7:20 ` 回复: " gaoliming 0 siblings, 1 reply; 7+ messages in thread From: Andrei Warkentin @ 2020-11-19 19:53 UTC (permalink / raw) To: Philippe Mathieu-Daudé, Andrei Warkentin, devel@edk2.groups.io, Bret Barkelew, Dandan Bi, Jian J Wang, pete@akeo.ie Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, Liming Gao [-- Attachment #1: Type: text/plain, Size: 5053 bytes --] Sorry, folks, is there anything actionable for me here to do? It does appear that all the other edk2-platforms are broken/affected as well. A ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Pete Batard via groups.io <pete=akeo.ie@groups.io> Sent: Thursday, November 19, 2020 11:33 AM To: Philippe Mathieu-Daudé <philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <brbarkel@microsoft.com>; Dandan Bi <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com> Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuviainc.com <leif@nuviainc.com>; Liming Gao <gaoliming@byosoft.com.cn> Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a&data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&reserved=0 >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). > > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. > >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. > > This can be added before the S-o-b: > > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete > >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> >>> --- >>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> # >>> @@ -226,6 +228,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard <pete@akeo.ie> >> > [-- Attachment #2: Type: text/html, Size: 8403 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 19:53 ` [edk2-devel] " Andrei Warkentin @ 2020-11-20 7:20 ` gaoliming 0 siblings, 0 replies; 7+ messages in thread From: gaoliming @ 2020-11-20 7:20 UTC (permalink / raw) To: 'Andrei Warkentin', 'Philippe Mathieu-Daudé', 'Andrei Warkentin', devel, 'Bret Barkelew', 'Dandan Bi', 'Jian J Wang', pete Cc: ard.biesheuvel, leif [-- Attachment #1: Type: text/plain, Size: 7017 bytes --] Andrei: If you know the broken platforms, you can also contribute the patch to fix them. For this patch, it has passed the code review. The comment is to update the commit message with below. Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") Thanks Liming 发件人: Andrei Warkentin <awarkentin@vmware.com> 发送时间: 2020年11月20日 3:53 收件人: Philippe Mathieu-Daudé <philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io; Bret Barkelew <brbarkel@microsoft.com>; Dandan Bi <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>; pete@akeo.ie 抄送: ard.biesheuvel@arm.com; leif@nuviainc.com; Liming Gao <gaoliming@byosoft.com.cn> 主题: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. Sorry, folks, is there anything actionable for me here to do? It does appear that all the other edk2-platforms are broken/affected as well. A _____ From: devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> > on behalf of Pete Batard via groups.io <pete=akeo.ie@groups.io <mailto:pete=akeo.ie@groups.io> > Sent: Thursday, November 19, 2020 11:33 AM To: Philippe Mathieu-Daudé <philmd@redhat.com <mailto:philmd@redhat.com> >; Andrei Warkentin <andrey.warkentin@gmail.com <mailto:andrey.warkentin@gmail. com> >; devel@edk2.groups.io <mailto:devel@edk2.groups.io> <devel@edk2.groups.io <mailto:devel@edk2.groups.io> >; Bret Barkelew <brbarkel@microsoft.com <mailto:brbarkel@microsoft.com> >; Dandan Bi <dandan.bi@intel.com <mailto:dandan.bi@intel.com> >; Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> > Cc: ard.biesheuvel@arm.com <mailto:ard.biesheuvel@arm.com> <ard.biesheuvel@arm.com <mailto:ard.biesheuvel@arm.com> >; leif@nuviainc.com <mailto:leif@nuviainc.com> <leif@nuviainc.com <mailto:leif@nuviainc.com> >; Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daudé wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub. com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.co m%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a& ;data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139b8%7 Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown%7CT WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&rese rved=0> &data=04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb139 b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M n0%3D%7C1000&sdata=K%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D& reserved=0 >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). > > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. > >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. > > This can be added before the S-o-b: > > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete > >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com <mailto:andrey.warkentin@gmail.com> > >>> --- >>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull .inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.i nf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variabl ePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRu ntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull .inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.i nf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variabl ePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> # >>> @@ -226,6 +228,7 @@ >>> >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRu ntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) == TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard <pete@akeo.ie <mailto:pete@akeo.ie> > >> > [-- Attachment #2: Type: text/html, Size: 13372 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. 2020-11-19 0:01 [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again Andrei Warkentin 2020-11-19 17:14 ` Pete Batard @ 2020-11-20 15:09 ` Ard Biesheuvel 1 sibling, 0 replies; 7+ messages in thread From: Ard Biesheuvel @ 2020-11-20 15:09 UTC (permalink / raw) To: Andrei Warkentin, devel; +Cc: leif, pete, philmd On 11/19/20 1:01 AM, Andrei Warkentin wrote: > Add VariablePolicyLib and its dependency. > > Testing: Pi 4 boot. > > Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com> Pushed as 879f483ce455..663c3108f730 Thanks all, > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 325d7bdb..9408138d 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > [LibraryClasses.common.SEC] > @@ -218,6 +220,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index c994f56d..4e5a36ed 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > # > @@ -226,6 +228,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-20 15:09 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-11-19 0:01 [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again Andrei Warkentin 2020-11-19 17:14 ` Pete Batard 2020-11-19 17:28 ` Philippe Mathieu-Daudé 2020-11-19 17:33 ` Pete Batard 2020-11-19 19:53 ` [edk2-devel] " Andrei Warkentin 2020-11-20 7:20 ` 回复: " gaoliming 2020-11-20 15:09 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox