From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ECDE92118B795 for ; Wed, 7 Nov 2018 18:02:37 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2018 18:02:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,478,1534834800"; d="scan'208";a="278032506" Received: from shzintpr01.sh.intel.com (HELO [10.253.24.32]) ([10.239.4.80]) by fmsmga005.fm.intel.com with ESMTP; 07 Nov 2018 18:02:34 -0800 To: Laszlo Ersek , Leif Lindholm Cc: "edk2-devel@lists.01.org" , Stephano Cetola , Brian Richardson , "Gao, Liming" , Michael Kinney , star.zeng@intel.com References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3659AB@SHSMSX104.ccr.corp.intel.com> <20181107153829.juygpydwln2s5jkj@bivouac.eciton.net> <01176b5b-8826-2c82-beef-45250fd88bef@redhat.com> From: "Zeng, Star" Message-ID: <6378d10e-099d-1752-b84a-d50ba42059d7@intel.com> Date: Thu, 8 Nov 2018 10:02:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <01176b5b-8826-2c82-beef-45250fd88bef@redhat.com> Subject: Re: Soft Feature Freeze has started since Nov.1 for dk2-stable201811 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 02:02:38 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Has been the time to announce Hard Feature Freeze? During Hard Feature Freeze, every checkin needs to be approved by stewards, right? Thanks, Star On 2018/11/8 3:13, Laszlo Ersek wrote: > On 11/07/18 16:38, Leif Lindholm wrote: >> Hi Laszlo, >> >> Can I inject an alternative interpretation? (feel free to shoot it down) >> >> On Wed, Nov 07, 2018 at 04:14:01PM +0100, Laszlo Ersek wrote: >>> Hi, >>> >>> On 11/07/18 02:12, Gao, Liming wrote: >>>> Hi, all >>> >>>> https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning >>>> lists edk2-stable201811 tag planning. Now, we enter into Soft Feature >>>> Freeze phase. In this phase, the feature under review will not be >>>> allowed to be pushed. The patch review can continue without break. >>>> Here is edk2-stable201811 tag planning. >>> >>>> 2018-08-15 Beginning of development >>>> 2018-11-01 Soft Feature Freeze >>>> 2018-11-08 Hard Feature Freeze >>>> 2018-11-15 Release >>> >>> I don't think an announcement should be made like this, one week after >>> the fact. (If I missed the exact dates on yesterday's stewards' call, >>> then I apologize.) >>> >>> If we are making the announcement about the Soft Feature Freeze on >>> 2018-Nov-07, then the Soft Feature Freeze should start no earlier than >>> 2018-Nov-08 or so. Certainly not retro-actively. >>> >>> Perhaps we should push the schedule by one week. >> >> Do we need to send an announcement for the soft feature freeze? >> >> I would be quite happy with that one being set in stone(ish) from the >> planning page, and the hard freeze date being the one that needs to be >> announced. >> >>> I understand that will prevent the stable tag from being dropped >>> *exactly* three months after start of development (2018-Aug-15). I think >>> that should be fine. Nobody forces us to work in cycles of *exactly* >>> three months. (Even if we slipped over to December, that shouldn't be a >>> huge problem; we'd just call the tag "edk2-stable201812".) The workflow >>> itself is work-in-progress. >> >> Of course, I'm heavily biased since I'm hoping to make a Linaro >> release this month based on the stable tag... >> >>> I realize that >>> >>> has had the dates available all this time. But, the reason we make the >>> announcements in the first place is precisely that people don't keep >>> staring at that page. >>> >>> ( >>> >>> For example, I reviewed and pushed 4 patches yesterday (on 2018-Nov-06): >>> >>> 1 e038bde2679b Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF file" >>> 2 98856a724c2a Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" >>> 3 438ada5aa5a1 Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port I/O." >>> 4 328409ce8de7 Revert "OvmfPkg: VMWare SVGA display device register definitions" >>> >>> which are the first four patches (out of five) from the following >>> series: >>> >>> [edk2] [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga >>> >>> These reverts are arguably not bugfixes; they are preparation for >>> re-implementing a feature from scratch (the last patch in that series). >>> Thus, had I known we were already in the Soft Feature Freeze, I wouldn't >>> have pushed them, because the review was not complete before the soft >>> freeze start. >>> >>> But I had just returned from a week (or more) of PTO, there was no >>> announcement on the list yet, and I didn't remember the wiki page. >>> >>> (In the technical sense, the reverts are not disruptive, luckily; they >>> remove code that is dead anyway.) >>> >>> ) >>> >>> This is my opinion at least -- I'm ready to be overruled, but I wanted >>> to voice it. >> >> I don't disagree with anything you say, but my feeling is that we're >> still learning to work with the new process, and we have seen other >> mistakes during this cycle. >> >> So, I'm happy to consider this post the announcement of the >> hard-freeze with the soft-freeze date being included for context. >> >> I agree that for the next cycle, separate announcements of soft-freeze >> and hard-freeze would be preferable. >> >> I too am OK with being overruled :) > > OK, let's stick with the current dates as they are. > > I do think we should send separate announcements about soft & hard > freezes. The soft freeze is the first time in a cycle when maintainers > have to stop and think about non-technical reasons before they push. I'd > really like to be poked about that. > > Thanks > Laszlo >