From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.68, mailfrom: philmd@redhat.com) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 04 Jul 2019 11:13:17 -0700 Received: by mail-wr1-f68.google.com with SMTP id c27so7509859wrb.2 for ; Thu, 04 Jul 2019 11:13:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GPBwrEVjOYRbXAHWKDsNLvMUKhX9lsV56146a9c0hEA=; b=lwsEagOpRKFR43J1SjQ13Gh3Hs0kj0WLGo13PzXWw784L6cv8Cj2DSKOekJ/hd2dag G75spW3AVGqpYy0G6oQJ1b8gFF03Vuc5qecT/RtBz3oZNkCM1tzDuRUx8oWz6ggSvvQP AGDU3OHI8qKX1az7DHETYhN1akVkxl/EFER8oIV16nXh2RrXi8w0EqOxmCD8+4wS7gIr QlmDL01GjbUS0SlF+aFlQMmioHUXcQgGd0Elf45tulS95b64voWEGmxzxJRmJhtaMjeR SoBtc9C8jsTdpGB6X6jsxzuns/tiVOiVUT5nBBF5SnMCJaK838ZQSzOwkWc1aBV2cQRq Ms/A== X-Gm-Message-State: APjAAAU7zWy34ynDFdVikfK4sEeSQHx6tHl1hxobSTEXgtmzcIwteQR7 /3If+7PQQ07J7Eul+lISIfme/A== X-Google-Smtp-Source: APXvYqzA4z7m/cOmgETaQ7LBeH5XutluAYGqCAlIsgBADlTxLT+BBwG83GWOoqzto1SQiV9s+89NpQ== X-Received: by 2002:a5d:664e:: with SMTP id f14mr12707798wrw.192.1562263995405; Thu, 04 Jul 2019 11:13:15 -0700 (PDT) Return-Path: Received: from [192.168.1.38] (56.red-88-18-140.staticip.rima-tde.net. [88.18.140.56]) by smtp.gmail.com with ESMTPSA id h9sm4707531wrw.85.2019.07.04.11.13.14 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2019 11:13:14 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches To: devel@edk2.groups.io, lersek@redhat.com, Imran Desai Cc: Ard Biesheuvel , Chao Zhang , Jian Wang , Jiewen Yao , Jordan Justen , Leif Lindholm , Liming Gao , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Michael D Kinney , Stefan Berger References: <20190704094624.21057-1-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <63834fb8-7839-d22d-38af-61337e4c8b10@redhat.com> Date: Thu, 4 Jul 2019 20:13:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/4/19 6:05 PM, Laszlo Ersek wrote: > On 07/04/19 11:46, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: revert_unreviewed_bz1781 >> >> The MdePkg patch and the OvmfPkg patch committed for >> had not been >> reviewed appropriately, so they must be reverted. Due to the MdePkg >> patch being the basis of the entire series, the SecurityPkg patches in >> the middle have to be reverted as well. (Leif pointed out that at least >> some of the SecurityPkg patches were not reviewed *on the list* either, >> so there's that too.) > > I've now pushed this series (commit range 1ec05b81e59f..6a34c1ce7054), > with Leif's (as a steward's) R-b, and Phil's R-b. > > If these patches had been normal patches, obviously I would have waited > for package maintainer review. However, these are *not* normal patches; > they are reverts which return the tree to an earlier state -- to a state > where unreviewed patches had not gone in yet. There's an argument to be > made that Jian should have reverted the original patches without me > having to post a revert series to the list at all -- either way, this > has been urgent because the delta with the unreviewed patches "in" > should be as minimal as possible. (Which is why I took it upon me to > send the set.) For example, a bisection should preferably not hit the > unreviewed range (good point from Leif). Furthermore, if we diverge too > much meanwhile, then the reverts themselves could become messy. Agreed, this is why I wanted this merged quickly, thanks. > Imran: please resubmit your patches now. Please pay attention to shallow > threading, and to actually working CC's. Regarding the SecurityPkg > patches, if you are going to post them unchanged, please preserve the > Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those > Reviewed-by tags had been given publicly, on the list. (In other words, > if they can be found in the mailing list archive.) > > Thanks > Laszlo