Re: [PATCH 1/1] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

ping?

On 12/19/19 3:12 PM, Philippe Mathieu-Daude wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113
> 
> Strip the trailing characters before checking the subject line is
> less than 72 characters.
> 
> Fixes: e61406708c83f
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> ---
>   BaseTools/Scripts/PatchCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 2a4e6f603e79..b72e71963ea8 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -196,7 +196,7 @@ class CommitMessageCheck:
>               self.error('Empty commit message!')
>               return
>   
> -        if count >= 1 and len(lines[0]) >= 72:
> +        if count >= 1 and len(lines[0].strip()) >= 72:
>               self.error('First line of commit message (subject line) ' +
>                          'is too long.')
>   
>