From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.2967.1577798621183910955 for ; Tue, 31 Dec 2019 05:23:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AxM/tOY8; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577798620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ynmQAxL+KVUmyyVKpkx1wnQA+zgm1XPiBzDPyysbjXs=; b=AxM/tOY8rwdCWiIPinsabuPQYSZ0SbqurjhdmpE8d9YuCzGhAKJxMQcetFqVyajezJDDaL 1jlc9DLptykhsTuhALqnM/iyci/g4ZCj245ujIFh0SyMiL/f8bGeHhj7NKMfkcIKd1mpDk zc1fVtkd9ugoNvC0viZynLVIzJs6dNA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-41-4K8_-8JSNeGOcPG3-D5hhw-1; Tue, 31 Dec 2019 08:23:34 -0500 Received: by mail-wr1-f69.google.com with SMTP id f17so5039626wrt.19 for ; Tue, 31 Dec 2019 05:23:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ynmQAxL+KVUmyyVKpkx1wnQA+zgm1XPiBzDPyysbjXs=; b=UJ8y4INbIFRXJ3B1+RSKvNFSLOe6/37j1wpGiRYpTrSmwPMTx8aVLXenKDPT50eYx6 WXT5nrQ7+RoofBESgj7Sz7VkLzhKDNWinSu9dsl4l3xXONmR7pdo63yFxkSxDeZQyBMh dJxM9bFsY42bEPCQ5GF1eXhFpjRsNwhakeFZvRqQpGPDpqiyYglUXe6EJwSiJN0FVfLS whtI+jMfgw6DTS6pGT7qyq15apdA8UQicH0CjzFUH280Fo6GfUSJxJdd2wL4fI54rcRd HzYh7X1zeNHjq48u/pfqWg66TKlT7QX+TfbQRKN3HM+65Hlq6qZmEnnwF8W2CHaX4WOA Qskw== X-Gm-Message-State: APjAAAXvmM8d4yRjILa2JpkZ8FgqvSSH4rcZQ4FK9aUqn1faI1W3EsxW xblEgORNV4VR4Ng5eaN73mijAzRgLPOZ4QnfYjoNYAoq+MiJwCtlDQbB3A2CQ9g69Mzd5D0qobU HEoshJBpr7X5RtQ== X-Received: by 2002:a1c:1dcd:: with SMTP id d196mr4334760wmd.106.1577798612642; Tue, 31 Dec 2019 05:23:32 -0800 (PST) X-Google-Smtp-Source: APXvYqwq2Srm/miahf1wt8NTC4MrFf8OuX0bHCOo341OhnmuFuuEY52jbsAsezM9Zzy9WwsRdRnqNQ== X-Received: by 2002:a1c:1dcd:: with SMTP id d196mr4334738wmd.106.1577798612460; Tue, 31 Dec 2019 05:23:32 -0800 (PST) Return-Path: Received: from [192.168.1.25] (abayonne-654-1-140-248.w86-222.abo.wanadoo.fr. [86.222.91.248]) by smtp.gmail.com with ESMTPSA id s15sm50243202wrp.4.2019.12.31.05.23.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Dec 2019 05:23:31 -0800 (PST) Subject: Re: [PATCH 1/1] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length To: devel@edk2.groups.io Cc: Liming Gao , Jordan Justen , Yonghong Zhu , Zhichao Gao References: <20191219141256.25752-1-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <638d4890-f540-1a83-b5aa-2f4dee47ec85@redhat.com> Date: Tue, 31 Dec 2019 14:23:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191219141256.25752-1-philmd@redhat.com> X-MC-Unique: 4K8_-8JSNeGOcPG3-D5hhw-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit ping? On 12/19/19 3:12 PM, Philippe Mathieu-Daude wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=113 > > Strip the trailing characters before checking the subject line is > less than 72 characters. > > Fixes: e61406708c83f > Cc: Liming Gao > Cc: Jordan Justen > Signed-off-by: Philippe Mathieu-Daude > --- > Cc: Yonghong Zhu > Cc: Zhichao Gao > --- > BaseTools/Scripts/PatchCheck.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py > index 2a4e6f603e79..b72e71963ea8 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -196,7 +196,7 @@ class CommitMessageCheck: > self.error('Empty commit message!') > return > > - if count >= 1 and len(lines[0]) >= 72: > + if count >= 1 and len(lines[0].strip()) >= 72: > self.error('First line of commit message (subject line) ' + > 'is too long.') > >