From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
To: Jian J Wang <jian.j.wang@intel.com>, edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [PATCH 1/5] MdeModulePkg/DxeIplPeim: expire the use of PcdSetNxForStack
Date: Tue, 11 Sep 2018 17:00:07 +0800 [thread overview]
Message-ID: <6391fa71-56f4-f8e7-cd26-e739a80910f8@Intel.com> (raw)
In-Reply-To: <20180911051636.4888-2-jian.j.wang@intel.com>
On 9/11/2018 1:16 PM, Jian J Wang wrote:
> + if ((PcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT4) != 0
I suggest to use (1 << EfiBootServicesData) to replace BIT4.
--
Thanks,
Ray
next prev parent reply other threads:[~2018-09-11 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 5:16 [PATCH 0/5] expire the use of PcdSetNxForStack Jian J Wang
2018-09-11 5:16 ` [PATCH 1/5] MdeModulePkg/DxeIplPeim: " Jian J Wang
2018-09-11 9:00 ` Ni, Ruiyu [this message]
2018-09-11 5:16 ` [PATCH 2/5] OvmfPkg/PlatformPei: " Jian J Wang
2018-09-11 15:53 ` Laszlo Ersek
2018-09-12 2:11 ` Wang, Jian J
2018-09-12 10:41 ` Laszlo Ersek
2018-09-13 0:45 ` Wang, Jian J
2018-09-11 5:16 ` [PATCH 3/5] OvmfPkg: " Jian J Wang
2018-09-11 5:16 ` [PATCH 4/5] ArmVirtPkg/ArmVirt.dsc.inc: " Jian J Wang
2018-09-11 5:16 ` [PATCH 5/5] MdeModulePkg: expire PcdSetNxForStack Jian J Wang
2018-09-11 5:52 ` [PATCH 0/5] expire the use of PcdSetNxForStack Yao, Jiewen
2018-09-11 8:57 ` Ard Biesheuvel
2018-09-11 9:13 ` Ni, Ruiyu
2018-09-11 21:02 ` Ard Biesheuvel
2018-09-12 0:55 ` Ni, Ruiyu
2018-09-12 15:04 ` Ard Biesheuvel
2018-09-11 11:07 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6391fa71-56f4-f8e7-cd26-e739a80910f8@Intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox