From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ruiyu.ni@intel.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=192.55.52.115; helo=mga14.intel.com;
 envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org 
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 084DF21127CDF
 for <edk2-devel@lists.01.org>; Tue, 11 Sep 2018 01:59:18 -0700 (PDT)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 11 Sep 2018 01:59:17 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.53,359,1531810800"; d="scan'208";a="82536075"
Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.8]) ([10.239.9.8])
 by orsmga003.jf.intel.com with ESMTP; 11 Sep 2018 01:59:16 -0700
To: Jian J Wang <jian.j.wang@intel.com>, edk2-devel@lists.01.org
Cc: Star Zeng <star.zeng@intel.com>, Laszlo Ersek <lersek@redhat.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>, Jiewen Yao <jiewen.yao@intel.com>
References: <20180911051636.4888-1-jian.j.wang@intel.com>
 <20180911051636.4888-2-jian.j.wang@intel.com>
From: "Ni, Ruiyu" <ruiyu.ni@Intel.com>
Message-ID: <6391fa71-56f4-f8e7-cd26-e739a80910f8@Intel.com>
Date: Tue, 11 Sep 2018 17:00:07 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20180911051636.4888-2-jian.j.wang@intel.com>
Subject: Re: [PATCH 1/5] MdeModulePkg/DxeIplPeim: expire the use of PcdSetNxForStack
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Sep 2018 08:59:18 -0000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 9/11/2018 1:16 PM, Jian J Wang wrote:
> +    if ((PcdGet64 (PcdDxeNxMemoryProtectionPolicy) & BIT4) != 0

I suggest to use (1 << EfiBootServicesData) to replace BIT4.



-- 
Thanks,
Ray