From: Laszlo Ersek <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>
Cc: edk2-devel@lists.01.org
Subject: Re: [Patch 0/2] Add missed Depex Protocol/Ppi.
Date: Tue, 7 Nov 2017 19:17:59 +0100 [thread overview]
Message-ID: <639c28f8-99fc-600c-cc2c-b6573677aa1b@redhat.com> (raw)
In-Reply-To: <1509971214-9732-1-git-send-email-eric.dong@intel.com>
Hi Eric,
On 11/06/17 13:26, Eric Dong wrote:
> The Protocol/Ppi used in the drivers but the it not add them
> in the dependence section, it may cause driver assert.
> This patch series add the missed Protocol/Ppi.
>
> Eric Dong (2):
> UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol.
> UefiCpuPkg/CpuFeaturesPei.inf: Add missed Depex Ppi.
>
> UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 2 +-
> UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
(hopefully I'm commenting soon enough,)
where exactly are the MP protocol and PPI used in UefiCpuPkg/CpuFeatures/?
I grepped the directory for both protocol and PPI, and I found no matches.
If the dependencies are incurred via library instances, then those
library instances should spell out the depex.
The only library class used by CpuFeaturesDxe.inf and
CpuFeaturesPei.inf, for which multi-processing looks remotely relevant,
is: RegisterCpuFeaturesLib.
For this class, two instances appear to exist:
UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.inf
UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.inf
The DXE instance consumes gEfiMpServiceProtocolGuid alright, but it also
spells out the protocol in the depex:
[Depex]
gEfiMpServiceProtocolGuid AND gEdkiiCpuFeaturesSetDoneGuid
The PEI instance is similar, wrt. the PPI:
[Depex]
gEfiPeiMpServicesPpiGuid AND gEdkiiCpuFeaturesSetDoneGuid
So, this series appears unnecessary. What am I missing?
Thanks
Laszlo
next prev parent reply other threads:[~2017-11-07 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 12:26 [Patch 0/2] Add missed Depex Protocol/Ppi Eric Dong
2017-11-06 12:26 ` [Patch 1/2] UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol Eric Dong
2017-11-06 12:26 ` [Patch 2/2] UefiCpuPkg/CpuFeaturesPei.inf: Add missed Depex Ppi Eric Dong
2017-11-07 18:17 ` Laszlo Ersek [this message]
2017-11-08 1:54 ` [Patch 0/2] Add missed Depex Protocol/Ppi Dong, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639c28f8-99fc-600c-cc2c-b6573677aa1b@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox