From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A5BDE2034CF7D for ; Tue, 7 Nov 2017 10:14:01 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EDDD7EAA6; Tue, 7 Nov 2017 18:18:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4EDDD7EAA6 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-123-130.rdu2.redhat.com [10.10.123.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id A846160BF2; Tue, 7 Nov 2017 18:18:00 +0000 (UTC) To: Eric Dong References: <1509971214-9732-1-git-send-email-eric.dong@intel.com> Cc: edk2-devel@lists.01.org From: Laszlo Ersek Message-ID: <639c28f8-99fc-600c-cc2c-b6573677aa1b@redhat.com> Date: Tue, 7 Nov 2017 19:17:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509971214-9732-1-git-send-email-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 07 Nov 2017 18:18:01 +0000 (UTC) Subject: Re: [Patch 0/2] Add missed Depex Protocol/Ppi. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 18:14:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Eric, On 11/06/17 13:26, Eric Dong wrote: > The Protocol/Ppi used in the drivers but the it not add them > in the dependence section, it may cause driver assert. > This patch series add the missed Protocol/Ppi. > > Eric Dong (2): > UefiCpuPkg/CpuFeaturesDxe.inf: Add missed Depex protocol. > UefiCpuPkg/CpuFeaturesPei.inf: Add missed Depex Ppi. > > UefiCpuPkg/CpuFeatures/CpuFeaturesDxe.inf | 2 +- > UefiCpuPkg/CpuFeatures/CpuFeaturesPei.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > (hopefully I'm commenting soon enough,) where exactly are the MP protocol and PPI used in UefiCpuPkg/CpuFeatures/? I grepped the directory for both protocol and PPI, and I found no matches. If the dependencies are incurred via library instances, then those library instances should spell out the depex. The only library class used by CpuFeaturesDxe.inf and CpuFeaturesPei.inf, for which multi-processing looks remotely relevant, is: RegisterCpuFeaturesLib. For this class, two instances appear to exist: UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.inf UefiCpuPkg/Library/RegisterCpuFeaturesLib/PeiRegisterCpuFeaturesLib.inf The DXE instance consumes gEfiMpServiceProtocolGuid alright, but it also spells out the protocol in the depex: [Depex] gEfiMpServiceProtocolGuid AND gEdkiiCpuFeaturesSetDoneGuid The PEI instance is similar, wrt. the PPI: [Depex] gEfiPeiMpServicesPpiGuid AND gEdkiiCpuFeaturesSetDoneGuid So, this series appears unnecessary. What am I missing? Thanks Laszlo