public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
Date: Wed, 31 Jan 2018 14:17:04 +0100	[thread overview]
Message-ID: <63afefb4-6b2d-bbb7-36ba-2b9cd9e12ad9@redhat.com> (raw)
In-Reply-To: <1517401630-7904-1-git-send-email-liming.gao@intel.com>

On 01/31/18 13:27, Liming Gao wrote:
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library implementation
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/SafeIntLib.h b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt16ToUint8 (
>    IN INT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint16ToUint8 (
>    IN UINT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt32ToUint8 (
>    IN INT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint32ToUint8 (
>    IN UINT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeIntnToUint8 (
>    IN INTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUintnToUint8 (
>    IN UINTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2018-01-31 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31 12:27 [Patch] MdePkg SafeIntLib: Update API definition to use the same output name Liming Gao
2018-01-31 13:17 ` Laszlo Ersek [this message]
2018-01-31 19:29 ` Kinney, Michael D
2018-02-27 19:00   ` Bret Barkelew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63afefb4-6b2d-bbb7-36ba-2b9cd9e12ad9@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox