From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 6840322364892
 for <edk2-devel@lists.01.org>; Wed, 31 Jan 2018 05:11:31 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id B80F178523;
 Wed, 31 Jan 2018 13:17:06 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-185.rdu2.redhat.com
 [10.10.120.185])
 by smtp.corp.redhat.com (Postfix) with ESMTP id DFEF660BE7;
 Wed, 31 Jan 2018 13:17:05 +0000 (UTC)
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
References: <1517401630-7904-1-git-send-email-liming.gao@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <63afefb4-6b2d-bbb7-36ba-2b9cd9e12ad9@redhat.com>
Date: Wed, 31 Jan 2018 14:17:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <1517401630-7904-1-git-send-email-liming.gao@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.28]); Wed, 31 Jan 2018 13:17:07 +0000 (UTC)
Subject: Re: [Patch] MdePkg SafeIntLib: Update API definition to use the same output name
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2018 13:11:31 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/31/18 13:27, Liming Gao wrote:
> In SafeUintnToChar8(), update its output parameter name.
> Update pui8Result --> Result to match its library implementation
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdePkg/Include/Library/SafeIntLib.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdePkg/Include/Library/SafeIntLib.h b/MdePkg/Include/Library/SafeIntLib.h
> index 5839301..8c5003f 100644
> --- a/MdePkg/Include/Library/SafeIntLib.h
> +++ b/MdePkg/Include/Library/SafeIntLib.h
> @@ -375,7 +375,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt16ToUint8 (
>    IN INT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -564,7 +564,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint16ToUint8 (
>    IN UINT16 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -672,7 +672,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeInt32ToUint8 (
>    IN INT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -889,7 +889,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUint32ToUint8 (
>    IN UINT32 Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1078,7 +1078,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeIntnToUint8 (
>    IN INTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> @@ -1321,7 +1321,7 @@ RETURN_STATUS
>  EFIAPI
>  SafeUintnToUint8 (
>    IN UINTN Operand,
> -  OUT UINT8 *pui8Result
> +  OUT UINT8 *Result
>    );
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>