From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mx.groups.io with SMTP id smtpd.web10.13692.1679318562402096970 for ; Mon, 20 Mar 2023 06:22:42 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=Mi42qxME; spf=pass (domain: bsdio.com, ip: 66.111.4.27, mailfrom: rebecca@bsdio.com) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A691F5C0102; Mon, 20 Mar 2023 09:22:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 20 Mar 2023 09:22:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1679318561; x=1679404961; bh=np0o6H78D5FjzhCM51Gk5Lpiu43dJp/VF7D 7Oevt1Cg=; b=Mi42qxMEGY5S4yHtzFjrfWvDlmxuy7YPH/Vbdpe1n3umvTDP3o/ Q83pD3r28omqIsZJjw4QqL5Ru20TjFjBPm/3hcZWAvWS/DgbHLQr3/hfbf//TyR8 4xxo6QHDaUkyaOo3ZJT4diktZERR0dURvyv5LOmuQBbFsfz0XBVg35AYAoc2Bz5G JOkhlvc8ZWmdYalVk8YDqLDBm6cW1S0+LhOEmPrC4kUG5DN44+2BtfsOnirQvfks CBGsfovYsbKANo99Drr6y5hu4zBKC6u2y94jdsGri6HXX8WExUjf/TILdcTsnIhv 7NUqc16hvAsARXKgZsNdBILHbgClEZwhW6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679318561; x=1679404961; bh=np0o6H78D5FjzhCM51Gk5Lpiu43dJp/VF7D 7Oevt1Cg=; b=Fk1KMd2P2SDXIJOTaOG13UrCNnOktktyWUuIadLMgaZa0mRC5qI oCPQuEtJPYs9L03hGGRmzJCDvnTnhspgO5yPf1uHBo0WG1rnfzCaqUQUCPUKY8Pj m/DhgppOoxDaZVaGZHOfFos6WW2cN2d7kAFcJwmnELuqdMrANovLJAGV1nPkIYXR ZTK8yv34SxdO6tYz+0YccJmoc+aF5EoxER4cmN2DQi8OLKoxJGqy1JciRCMp8eeY Elkuh+tDdzQe1FJPAj7SATbso3+l1yvbt4TtI4adhX7GlQ5udsIoAjCioV9ZRKvV 9lacQt6CIfRJ9acs7XeQYdAHX/HF65Ijj1A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdefkedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeehleekgfdutedugeehgeffgffhteefhffhteetfeevhefgvdejhedthfff ieffleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 20 Mar 2023 09:22:40 -0400 (EDT) Message-ID: <63c29923-228e-7577-d309-c33061e920f6@bsdio.com> Date: Mon, 20 Mar 2023 07:22:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version To: Tinh Nguyen , devel@edk2.groups.io Cc: patches@amperecomputing.com, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, nhi@os.amperecomputing.com References: <20230320083302.1035934-1-tinhnguyen@os.amperecomputing.com> From: "Rebecca Cran" In-Reply-To: <20230320083302.1035934-1-tinhnguyen@os.amperecomputing.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/20/23 2:33 AM, Tinh Nguyen wrote: > -/** > - Fetches the firmware ('BIOS') version from the > - FirmwareVersionInfo HOB. > +/** Fetches the Firmware version string for SMBIOS type 0 > > - @return The version as a UTF-16 string > + This function get the Firmware version string from OemMiscLib first, > + if it is invalid then PcdFirmwareVersionString is used as a fallback. > + > + @retval VOID > **/ > -CHAR16 * > -GetBiosVersion ( > +VOID > +SetBiosVersion ( > VOID > ) Don't use @retval on a function that doesn't return anything. With that fixed: Reviewed-by: Rebecca Cran -- Rebecca Cran