Re: [edk2-devel] [edk2-platforms PATCH 13/19] JadePkg/PCF85063RealTimeClockLib: hide LibRtcVirtualNotifyEvent

["Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>]

It looks good to me.

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

Thanks,
Nhi

On 10/12/2023 4:09 PM, Laszlo Ersek wrote:
> The RealTimeClockLib class header in edk2 mistakenly declares a function
> called LibRtcVirtualNotifyEvent(). No component ever calls this function
> crossing module boundaries; all RealTimeClockLib instances in edk2 and
> edk2-platforms are supposed to register (and do register) their
> SetVirtualAddressMap() notification functions.
> 
> Rename LibRtcVirtualNotifyEvent() to VirtualNotifyEvent(), and make it
> static, in preparation for removing the LibRtcVirtualNotifyEvent()
> declaration from the lib class header later.
> 
> Build-tested only (with "Jade.dsc").
> 
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>   Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c
> index ef8c71e92c18..1df781364bbc 100644
> --- a/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c
> +++ b/Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063RealTimeClockLib.c
> @@ -201,9 +201,10 @@ LibSetWakeupTime (
>     @param[in]    Event   The Event that is being processed
>     @param[in]    Context Event Context
>   **/
> +STATIC
>   VOID
>   EFIAPI
> -LibRtcVirtualNotifyEvent (
> +VirtualNotifyEvent (
>     IN EFI_EVENT        Event,
>     IN VOID             *Context
>     )
> @@ -246,7 +247,7 @@ LibRtcInitialize (
>     Status = gBS->CreateEventEx (
>                     EVT_NOTIFY_SIGNAL,
>                     TPL_NOTIFY,
> -                  LibRtcVirtualNotifyEvent,
> +                  VirtualNotifyEvent,
>                     NULL,
>                     &gEfiEventVirtualAddressChangeGuid,
>                     &mVirtualAddressChangeEvent
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109580): https://edk2.groups.io/g/devel/message/109580
Mute This Topic: https://groups.io/mt/101914668/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-